Skip to content

Conversation

tabacitu
Copy link
Member

@tabacitu tabacitu commented Jan 3, 2025

I didn't find any place where we had this documented, so here goes:

I didn't find any place where we had this documented, so here goes:
@tabacitu tabacitu requested a review from pxpm January 3, 2025 10:45
@pxpm
Copy link
Contributor

pxpm commented Jan 3, 2025

Hey @tabacitu thanks for your contribution.
I 100% LOVE this docs and examples you gave. ❤️

We have a little "explanation" about addBaseClause here:

CRUD::addBaseClause('where', 'name', '=', 'car');

I think this would be worth to add in both places (here, in filters) and in the list entries docs. Should I copy this over there too ?

Cheers

@tabacitu tabacitu merged commit 6fd1485 into master Jan 6, 2025
2 checks passed
@tabacitu
Copy link
Member Author

tabacitu commented Jan 6, 2025

Ah ok, that's great. That's why it didn't show up in search, because it's in a code block. I think it's fine as it is - people can see it in the ListOperation docs, then they'll search for it if they want more info.

We could have provided a link, though 👀

@tabacitu tabacitu deleted the add-docs-for-addbaseclause branch January 6, 2025 10:34
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
Status: Done
Development

Successfully merging this pull request may close these issues.

2 participants