-
-
Notifications
You must be signed in to change notification settings - Fork 22
Create 6 Shopkeeper payment integration #134
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Open
adam8797
wants to merge
19
commits into
Layers-of-Railways:1.21.1/1.0.x-next
Choose a base branch
from
adam8797:feature/shopkeeper_integration
base: 1.21.1/1.0.x-next
Could not load branches
Branch not found: {{ refName }}
Loading
Could not load tags
Nothing to show
Loading
Are you sure you want to change the base?
Some commits from the old base branch may be removed from the timeline,
and old review comments may become outdated.
Open
Create 6 Shopkeeper payment integration #134
adam8797
wants to merge
19
commits into
Layers-of-Railways:1.21.1/1.0.x-next
from
adam8797:feature/shopkeeper_integration
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR implements a workflow for users to both make and accept payments using numismatics coins (or cards) at Create shopkeepers.
Player Experience
Enabling the shopkeeper to accept coins
Opting into these features is as simple as placing a coin depositor next to the same stock ticker that serves the shop. It can be placed on any orthogonal side, like so:

The player may then optionally place a card in the depositor. If they do not insert a card, coins will be accepted but they will remain in the depositor.
Placing an order as a customer
If a customer attempts a transaction that does not include any numismatics coins in its costs, the player will not experience any difference. The standard Create shop mechanics will take over and fulfill the order.
If the order does have costs in the form of coins, they'll be prompted with a payment screen:
They can then place a card in the slot, or pay with coins out of their inventory. The
Pay with Coins
button is disabled if they do not have the requisite amount of coins available in their inventory.Upon clicking one of the payment buttons, the transaction is processed, and then any non-coin item costs are processed in the standard way.
If the player pays with coins, we withdraw coins in a greedy fashion, and will break a coin into change if needed. This is a one-click coin payment, regardless of the number and variety of coins needed.
This patch does allow for payment of mixed item & coin, but each individual item can still only have a cost of a single item or coin.
Technical details
The main flow here is that of a deferred payment system. We intercept calls to the Create
interactWithShop()
function which is called whenever the player right clicks on a stock keeper with a shopping list. We check a handful of preconditions, and if they all pass we:resolves #119