WIP: Fix: Force delete prior to force download #721
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Before submitting
What does this PR do?
Fixes a deadlock in deleting a chunk and forces a delete prior to redownloading.
This avoids timeouts in cases where there is a deadlock.
Successful runs show a dip in performance around the point deadlock would occur, but future deadlock points don't result in the same dip.

Before adding
skip_lock
to_apply_delete
debug logs showed:Followed by:
What this means is:
When adding in the delete we see that it is skipped because of a deadlock situation with 3 workers wanting the file.
After forcing a delete, the download to the cache operates properly and a pipeline timeout is avoided.
PR review
Anyone in the community is free to review the PR once the tests have passed.
If we didn't discuss your PR in GitHub issues there's a high chance it will not be merged.
Did you have fun?
Make sure you had fun coding 🙃