[Refactor] Add network sockaddr data structure in sysdefs lib #162
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Yaxuan-w
changed the title
Yaxuan-w
requested review from
JustinCappos,
rennergade,
ChinmayShringi,
Yaxuan-w,
qianxichen233 and
celinehoang177
rennergade
reviewed
Jun 9, 2025
|
Looks fine. I'm a bit confused though is the only thing this file is doing is exposing a unix sockaddr constructor? If so does it make sense to do this in a different file. |
Yaxuan-w
requested changes
Sep 8, 2025
Comment on lines
+1
to
+2
| use libc::{sa_family_t, sockaddr_un, sockaddr_in, sockaddr_in6, AF_UNIX, AF_INET, AF_INET6}; | ||
| use libc::sockaddr; |
Comment on lines
90
to
+104
| #[repr(C)] | ||
| pub struct PollStruct { | ||
| pub fd: i32, | ||
| pub events: i16, | ||
| pub revents: i16, | ||
| } | ||
|
|
||
| #[derive(Debug)] | ||
| #[repr(C)] | ||
| pub struct EpollEvent { | ||
| pub events: u32, | ||
| pub fd: i32, //in native this is a union which could be one of a number of things | ||
| //however, we only support EPOLL_CTL subcommands which take the fd | ||
| } | ||
|
|
There was a problem hiding this comment.
We don't need to include poll/epoll related things in this PR
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.