Skip to content

Conversation

stupendoussuperpowers
Copy link
Contributor

This adds a brief design documentation for the in memory file system.

Co-authored-by: Justin Cappos <[email protected]>
Copy link
Member

@Yaxuan-w Yaxuan-w left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Awesome!

@stupendoussuperpowers stupendoussuperpowers marked this pull request as ready for review September 6, 2025 20:30
@stupendoussuperpowers
Copy link
Contributor Author

Have made the suggested changes and polished up the structure a bit. I've also added more comments on the IMFS source code.

@rennergade
Copy link
Contributor

This looks great.

My only questions here are more to the group as a whole, since this is about a grate (and I'm guessing we'll also merge the grate code somewhere) where should the docs for this as well as the grate code live logically in the repository?

@stupendoussuperpowers
Copy link
Contributor Author

Might make sense to have a top-level folder for all example grates, since they are compiled out-of-tree. (e.g./lind-wasm/example_grates/imfs)

Not sure which would be better for the docs: each example grate having a readme.md doc file along side the code, or having all of them within an example_grates folder within docs

@rennergade
Copy link
Contributor

Yeah agree there. My inclination is to include them in a readme alongside the code since they're not really a part of the main codebase?

@rennergade
Copy link
Contributor

I think this has been ported to a new repo so lets close this PR.

@stupendoussuperpowers
Copy link
Contributor Author

Moved to: Lind-Project/lind-wasm-example-grates#4

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants