-
Notifications
You must be signed in to change notification settings - Fork 12
Add documentation for In Memory File System #367
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add documentation for In Memory File System #367
Conversation
Co-authored-by: Justin Cappos <[email protected]>
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Awesome!
Have made the suggested changes and polished up the structure a bit. I've also added more comments on the IMFS source code. |
This looks great. My only questions here are more to the group as a whole, since this is about a grate (and I'm guessing we'll also merge the grate code somewhere) where should the docs for this as well as the grate code live logically in the repository? |
Might make sense to have a top-level folder for all example grates, since they are compiled out-of-tree. (e.g. Not sure which would be better for the docs: each example grate having a |
Yeah agree there. My inclination is to include them in a readme alongside the code since they're not really a part of the main codebase? |
I think this has been ported to a new repo so lets close this PR. |
Moved to: Lind-Project/lind-wasm-example-grates#4 |
This adds a brief design documentation for the in memory file system.