Skip to content

🧰: fix crash on opening module in browser #1773

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 3 commits into from
Oct 8, 2025
Merged

🧰: fix crash on opening module in browser #1773

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
3 commits
Select commit Hold shift + click to select a range
2b3abd4
🧰: fix crash on opening module in browser
merryman Sep 1, 2025
f214d48
🧰: fix faulty unsaved changes warning on selecting same module in bro…
merryman Sep 1, 2025
55b5c26
🧰: fix component browser button layout
merryman Oct 8, 2025
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
8 changes: 5 additions & 3 deletions lively.ide/js/browser/index.js
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -1257,8 +1257,9 @@ export class BrowserModel extends ViewModel {

if (m) {
if (this.alreadySelectedModule(m.url)) return;
this.state.selectedModule = { url: m.url };

await columnView.selectNode(m, animated);
this.state.selectedModule = { url: m.url };
columnView.submorphs.forEach(list => {
list.scrollSelectionIntoView();
});
Expand All @@ -1278,7 +1279,7 @@ export class BrowserModel extends ViewModel {
}

if (url) {
if (this.alreadySelectedModule(m.url)) return;
if (this.alreadySelectedModule(url)) return;
this.state.selectedModule = { url };
const td = columnView.treeData;
await columnView.setExpandedPath(node => {
Expand Down Expand Up @@ -1377,7 +1378,8 @@ export class BrowserModel extends ViewModel {
async onModuleSelected (m, cleanupComponents = true) {
const pack = this.selectedPackage;

if (this._return) return;
if (this._return || this.alreadySelectedModule(m.url)) return;

let proceed = true;
if (this.selectedModule && this.hasUnsavedChanges()) {
proceed = await this.warnForUnsavedChanges();
Expand Down
3 changes: 1 addition & 2 deletions lively.ide/studio/component-browser.cp.js
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -1693,8 +1693,7 @@ const ComponentBrowser = component({
textAndAttributes: ['', {
fontColor: Color.rgb(74, 174, 79),
fontFamily: 'Font Awesome',
fontWeight: '900',
lineHeight: 1
fontWeight: '900'
}, ' Open', {
fontFamily: 'IBM Plex Sans'
}]
Expand Down