Skip to content

Commit 304e851

Browse files
committed
run linting on all files
1 parent 47832fe commit 304e851

File tree

21 files changed

+44
-37
lines changed

21 files changed

+44
-37
lines changed

.github/ISSUE_TEMPLATE/bug_report.md

Lines changed: 3 additions & 3 deletions
Original file line numberDiff line numberDiff line change
@@ -11,9 +11,9 @@ assignees: nathanhhughes
1111
A clear and concise description of what the bug is.
1212

1313
**System Information:**
14-
- OS [e.g. Ubuntu 18.04, Ubuntu 20.04]:
15-
- Any build warnings? [yes/no]:
16-
- Any non-system dependency versions that you know of? [yes/no]:
14+
- OS [e.g. Ubuntu 18.04, Ubuntu 20.04]:
15+
- Any build warnings? [yes/no]:
16+
- Any non-system dependency versions that you know of? [yes/no]:
1717

1818
**Additional Information:**
1919
If possible and/or relevant, please take a look [here](/MIT-SPARK/Hydra/blob/main/doc/debugging.md) and try to obtain the following (attached as files preferrably):

.github/ISSUE_TEMPLATE/feature_request.md

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -13,5 +13,5 @@ assignees: nathanhhughes
1313
**Relation to a paper or application (it's useful for us to understand how Hydra is potentially being applied)**:
1414
[N/A]
1515

16-
**Is this something you would be comfortable contributing yourself? Is there any additional information that would enable the contribution of this feature?:**
16+
**Is this something you would be comfortable contributing yourself? Is there any additional information that would enable the contribution of this feature?:**
1717
[e.g. yes, but what would be the best way to integrate feature X into the backend?]

.github/ISSUE_TEMPLATE/question.md

Lines changed: 0 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -6,5 +6,3 @@ labels: question
66
assignees: nathanhhughes
77

88
---
9-
10-

.gitignore

Lines changed: 0 additions & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -217,4 +217,3 @@ pyrightconfig.json
217217

218218
# ROS2
219219
log/
220-

docker/Makefile

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -40,7 +40,7 @@ build: check-profile check-env
4040
run: check-profile check-env
4141
docker compose --env-file .env -f $(DOCKER_DIR)/docker-compose.yml run --rm $(SERVICE_NAME) bash
4242

43-
#start the container in detached mode to keep container running
43+
#start the container in detached mode to keep container running
4444
up: check-profile check-env
4545
docker compose --env-file .env -f $(DOCKER_DIR)/docker-compose.yml up -d
4646

docker/README.md

Lines changed: 4 additions & 4 deletions
Original file line numberDiff line numberDiff line change
@@ -3,7 +3,7 @@
33
This directory contains multiple examples to build and run Hydra with different Docker configurations.
44

55
## Requirements
6-
You will need `git`, `make`, and `vcstool` as well as [docker](https://docs.docker.com/engine/install/ubuntu/) and the [NVIDIA Container Toolkit](https://docs.nvidia.com/datacenter/cloud-native/container-toolkit/latest/install-guide.html) for the profiles with GPU support. You may need to run `sudo usermod -aG docker $USER` + `newgrp docker` after installing docker, and similarly, you may need to run `sudo systemctl restart docker` after installing the toolkit.
6+
You will need `git`, `make`, and `vcstool` as well as [docker](https://docs.docker.com/engine/install/ubuntu/) and the [NVIDIA Container Toolkit](https://docs.nvidia.com/datacenter/cloud-native/container-toolkit/latest/install-guide.html) for the profiles with GPU support. You may need to run `sudo usermod -aG docker $USER` + `newgrp docker` after installing docker, and similarly, you may need to run `sudo systemctl restart docker` after installing the toolkit.
77

88
## Profiles
99

@@ -98,7 +98,7 @@ ros2 launch hydra_ros uhumans2.launch.yaml
9898
```
9999

100100

101-
> **:warning: Warning**<br>
101+
> **:warning: Warning**<br>
102102
> If you encounter graphical issues (e.g. rviz not displaying), make sure you run `xhost +local:root` on the host machine and that `DISPLAY` is correctly set.
103103

104104
2. In a separate terminal, open another shell in the container:
@@ -116,13 +116,13 @@ ros2 bag play /root/data/path/to/rosbag --clock --qos-profile-overrides-path ~/.
116116
```
117117

118118

119-
> **:warning: Warning**<br>
119+
> **:warning: Warning**<br>
120120
> You must convert the ROS 1 bag to a ROS 2 bag before playing it. The `rosbags-convert` tool is preinstalled in the container, and you can use it to convert the bag using the following command: `rosbags-convert --src path/to/office.bag --dst path/to/office` (in ROS2, you do not need `.bag` since a ROS 2 bag is a directory). You should run this in the container if you don't have `rosbags-convert` installed on your host machine.
121121
122122
## Quick Start (PROFILE=zed)
123123
124124
### Host (PROFILE=zed)
125-
You can repeat the steps above using the `zed` profile instead of `minimal`, but you must complete a few additional steps on the host to run with hardware.
125+
You can repeat the steps above using the `zed` profile instead of `minimal`, but you must complete a few additional steps on the host to run with hardware.
126126
127127
1. Add the `zed-ros2-wrapper` to your workspace, and the dependencies will be installed automatically via the dockerfile (if you forget this step, you must rebuild the image):
128128

docker/dev/Dockerfile

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -44,7 +44,7 @@ RUN apt-get update && apt-get install -y pipx && \
4444
echo 'export PATH=$PATH:/root/.local/bin' >> /root/.bashrc && \
4545
rm -rf /var/lib/apt/lists/*
4646

47-
#install tensorrt (must remove conflicting cuda repo to make work, unsure why
47+
#install tensorrt (must remove conflicting cuda repo to make work, unsure why
4848
#cuda12.8 comes with the base image instead of cuda12.6)
4949
RUN rm -f /etc/apt/sources.list.d/cuda-ubuntu2404-x86_64.list && \
5050
rm -f /etc/apt/sources.list.d/cuda*.list && \

docker/dev/docker-compose.yml

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -22,4 +22,4 @@ services:
2222
- /dev/dri
2323
privileged: true
2424
stdin_open: true
25-
tty: true
25+
tty: true

docker/minimal/docker-compose.yml

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -19,4 +19,4 @@ services:
1919
- /dev/dri
2020
privileged: true
2121
stdin_open: true
22-
tty: true
22+
tty: true

docker/zed/Dockerfile

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -45,7 +45,7 @@ RUN apt-get update && apt-get install -y pipx && \
4545
echo 'export PATH=$PATH:/root/.local/bin' >> /root/.bashrc && \
4646
rm -rf /var/lib/apt/lists/*
4747

48-
#install tensorrt (must remove conflicting cuda repo to make work, unsure why
48+
#install tensorrt (must remove conflicting cuda repo to make work, unsure why
4949
#cuda12.8 comes with the base image instead of cuda12.6)
5050
RUN rm -f /etc/apt/sources.list.d/cuda-ubuntu2404-x86_64.list && \
5151
rm -f /etc/apt/sources.list.d/cuda*.list && \

0 commit comments

Comments
 (0)