Skill multipliers addition and refactoring #652
Draft
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
ze-dom
commented
Oct 24, 2025
Comment on lines
+208
to
+211
| if (skill.Skill!.Number == 265 && !isPvp) // DragonSlasher | ||
| { | ||
| multiplier *= 3; | ||
| } |
There was a problem hiding this comment.
zTeamS6.3
emu: ObjAttack.cpp and BuffSkillEffect.xml.
ze-dom
commented
Oct 24, 2025
| result.BaseAttributeValues.Add(this.CreateConstValueAttribute(39, Stats.MaximumHealth)); | ||
| result.BaseAttributeValues.Add(this.CreateConstValueAttribute(6, Stats.MaximumMana)); | ||
| result.BaseAttributeValues.Add(this.CreateConstValueAttribute(1, Stats.SkillMultiplier)); | ||
| result.BaseAttributeValues.Add(this.CreateConstValueAttribute(2, Stats.SkillMultiplier)); |
There was a problem hiding this comment.
Only TripleShot and MultiShot have a skill multiplier of 1 (multiple arrow skills), which are effected in SkillsInitializer.cs.
ze-dom
commented
Oct 24, 2025
| result.AttributeCombinations.Add(this.CreateAttributeRelationship(Stats.MinimumPhysBaseDmg, 1.0f / 15, Stats.TotalVitality)); | ||
| result.AttributeCombinations.Add(this.CreateAttributeRelationship(Stats.MaximumPhysBaseDmg, 1.0f / 12, Stats.TotalVitality)); | ||
| result.AttributeCombinations.Add(this.CreateAttributeRelationship(Stats.SkillMultiplier, 0.001f, Stats.TotalEnergy)); | ||
| result.AttributeCombinations.Add(this.CreateAttributeRelationship(Stats.VitalitySkillMultiplier, 0.001f, Stats.TotalVitality)); |
ze-dom
commented
Oct 24, 2025
| var powerUpDefinition = this.Context.CreateNew<PowerUpDefinition>(); | ||
| magicEffect.PowerUpDefinitions.Add(powerUpDefinition); | ||
| powerUpDefinition.TargetAttribute = Stats.MaximumHealth.GetPersistent(this.GameConfiguration); | ||
| powerUpDefinition.TargetAttribute = Stats.TotalVitality.GetPersistent(this.GameConfiguration); |
There was a problem hiding this comment.
zTeamS6.3: ObjUseSkill.cpp, ItemAddOption.h, BuffEffect.cpp
emu: ObjUseSkill.cpp, ObjCalCharacter.cpp
The max bonus is 200: MuMain5.2, emu (we need to add cap values 😃 )
ze-dom
commented
Oct 24, 2025
| decDmgPowerUpDefinition.Boost.ConstantValue.Value = 0.05f; | ||
| decDmgPowerUpDefinition.Boost.ConstantValue.AggregateType = AggregateType.AddRaw; | ||
| } | ||
| } No newline at end of file |
There was a problem hiding this comment.
zTeamS6.3: ObjUseSkill.cpp, ObjAttack.cpp
ze-dom
commented
Oct 24, 2025
| { Stats.IceResistance, 254f / 255 }, | ||
| { Stats.WaterResistance, 150f / 255 }, | ||
| { Stats.FireResistance, 150f / 255 }, | ||
| { Stats.SkillMultiplier, 2 }, |
There was a problem hiding this comment.
zTeamS6.3: ObjAttack.cpp
He has 4 skill attacks, which correspond to skill numbers: 250, 251, 252, 253
ze-dom
commented
Oct 24, 2025
| // Originally, starting weapon skills for DL (FallingSlash, Lunge, Uppercut, Cyclone) and RF (FallingSlash) have a constant multiplier of 2. | ||
| // In OpenMU they might be able to do more damage with such skills, if their Stats.SkillMultiplier increases above 2. | ||
| // Since this only applies to early game weapons, this is acceptable. | ||
| this.AddAttributeRelationship(SkillNumber.FallingSlash, Stats.SkillFinalMultiplier, 2.0f, Stats.SkillMultiplier, InputOperator.Maximum); // For RF |
There was a problem hiding this comment.
This is needed because RF has a base Stats.SkillMultiplier of 0.5
zTeamS6.3
ze-dom
commented
Oct 24, 2025
Comment on lines
611
to
613
| this.AddAttributeRelationship(SkillNumber.Explosion223, Stats.SkillFinalDamageBonus, Stats.IsBookEquipped, Stats.ExplosionBonusDmg); | ||
| this.AddAttributeRelationship(SkillNumber.Requiem, Stats.SkillFinalDamageBonus, Stats.IsBookEquipped, Stats.RequiemBonusDmg); | ||
| this.AddAttributeRelationship(SkillNumber.Pollution, Stats.SkillFinalDamageBonus, Stats.IsBookEquipped, Stats.PollutionBonusDmg); |
ze-dom
commented
Oct 24, 2025
Comment on lines
+615
to
+617
| this.AddAttributeRelationship(SkillNumber.PlasmaStorm, Stats.SkillFinalMultiplier, 0.002f, Stats.TotalLevel); | ||
| this.AddAttributeRelationship(SkillNumber.PlasmaStorm, Stats.SkillFinalMultiplier, -0.6f, Stats.MaximumHealth, InputOperator.Minimum); // 0.002 * 300(min lvl) | ||
| this.AddAttributeRelationship(SkillNumber.PlasmaStorm, Stats.SkillFinalMultiplier, 2.0f, Stats.MaximumHealth, InputOperator.Minimum); |
ze-dom
commented
Oct 24, 2025
| this.AddAttributeRelationship(SkillNumber.PlasmaStorm, Stats.SkillFinalMultiplier, -0.6f, Stats.MaximumHealth, InputOperator.Minimum); // 0.002 * 300(min lvl) | ||
| this.AddAttributeRelationship(SkillNumber.PlasmaStorm, Stats.SkillFinalMultiplier, 2.0f, Stats.MaximumHealth, InputOperator.Minimum); | ||
|
|
||
| this.AddAttributeRelationship(SkillNumber.ChaoticDiseier, Stats.SkillFinalMultiplier, 0.8f, Stats.SkillMultiplier); |
There was a problem hiding this comment.
zTeamS6.3 (it's usually energy / 20)
ze-dom
commented
Oct 24, 2025
Comment on lines
+621
to
+631
| this.AddAttributeRelationship(SkillNumber.KillingBlow, Stats.SkillFinalMultiplier, 1.0f, Stats.VitalitySkillMultiplier); | ||
| this.AddAttributeRelationship(SkillNumber.BeastUppercut, Stats.SkillFinalMultiplier, 1.0f, Stats.VitalitySkillMultiplier); | ||
| this.AddAttributeRelationship(SkillNumber.ChainDrive, Stats.SkillFinalMultiplier, 1.0f, Stats.VitalitySkillMultiplier); | ||
| this.AddAttributeRelationship(SkillNumber.Charge, Stats.SkillFinalMultiplier, 1.0f, Stats.VitalitySkillMultiplier); | ||
| this.AddAttributeRelationship(SkillNumber.PhoenixShot, Stats.SkillFinalMultiplier, 1.0f, Stats.VitalitySkillMultiplier); | ||
|
|
||
| this.AddAttributeRelationship(SkillNumber.DarkSide, Stats.SkillFinalMultiplier, 0.5f, Stats.SkillMultiplier, InputOperator.Add); | ||
| this.AddAttributeRelationship(SkillNumber.DarkSide, Stats.SkillFinalMultiplier, 1.0f / 800, Stats.TotalAgility); | ||
|
|
||
| this.AddAttributeRelationship(SkillNumber.DragonRoar, Stats.SkillFinalMultiplier, 1.0f, Stats.SkillMultiplier); | ||
| this.AddAttributeRelationship(SkillNumber.DragonSlasher, Stats.SkillFinalMultiplier, 1.0f, Stats.SkillMultiplier); |
There was a problem hiding this comment.
zTeamS6.3: Normal, Master (I have left out the additions to simplify, and emu also doesn't have them).
emu: ObjectAttack.cpp, BuffSkillEffect.xml
For PhoenixShot (270) emu has a higher multiplier. For now I've left it like zTeamS6.3's. These skills still need to be revised for magic effects, number of hits, etc.
ze-dom
commented
Oct 24, 2025
|
|
||
| this.AddAttributeRelationship(SkillNumber.Explosion223, Stats.SkillFinalDamageBonus, 1.0f, Stats.ExplosionBonusDmg); | ||
| this.AddAttributeRelationship(SkillNumber.Requiem, Stats.SkillFinalDamageBonus, 1.0f, Stats.RequiemBonusDmg); | ||
| this.AddAttributeRelationship(SkillNumber.Pollution, Stats.SkillFinalDamageBonus, 1.0f, Stats.PollutionBonusDmg); |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
To-do
Developments
Bugfixes
There is still quite some work to do to finalize the Rage Fighter skills. They are lacking some particular magic effects and I don't think all of them have the correct number of hits.