Skip to content

AutoBuySell.cs: Fixed bug where armor isn't sold. #6

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
wants to merge 1 commit into
base: master
Choose a base branch
from
Open

AutoBuySell.cs: Fixed bug where armor isn't sold. #6

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
74 changes: 51 additions & 23 deletions Mag-Tools/Macros/AutoBuySell.cs
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -124,26 +124,49 @@ void Current_RenderFrame(object sender, EventArgs e)
/// </summary>
private void KickOffBuySell()
{
if (!Settings.SettingsManager.AutoBuySell.Enabled.Value)

if (!Settings.SettingsManager.AutoBuySell.Enabled.Value)
return;

if (VirindiItemTool.PluginCore.ActivityState != VirindiItemTool.PluginCore.ePluginActivityState.Idle)
return;
return;


using (Vendor openVendor = CoreManager.Current.WorldFilter.OpenVendor)
{
if (openVendor == null || openVendor.MerchantId == 0)
return;

int buyAmount;
if (openVendor == null || openVendor.MerchantId == 0)
return;



int buyAmount;
WorldObject buyItem = GetBuyItem(((VTClassic.LootCore)lootProfile), openVendor, out buyAmount);
WorldObject sellItem = GetSellItem(((VTClassic.LootCore)lootProfile));

if (buyItem != null && sellItem != null && (buyItem.ObjectClass != ObjectClass.TradeNote || sellItem.ObjectClass != ObjectClass.TradeNote))
// Give the user some feedback regarding operation.
// It's better to know that there is nothing to sell or buy than
// for nothing to happen.

if (buyItem == null)
{
Debug.WriteToChat("Nothing to Buy");
return;
}
if (sellItem == null)
{
Debug.WriteToChat("Nothing to Sell");
return;
}
if (buyItem.ObjectClass != ObjectClass.TradeNote && sellItem.ObjectClass != ObjectClass.TradeNote)
{
Debug.WriteToChat("No TradeNotes to buy or sell. Check Loot Profile");
}

if (buyItem != null && sellItem != null && (buyItem.ObjectClass != ObjectClass.TradeNote || sellItem.ObjectClass != ObjectClass.TradeNote))
{
VirindiItemTool.PluginCore.ActivityStateChanged += new VirindiItemTool.PluginCore.delActivityStateChanged(PluginCore_ActivityStateChanged);
VirindiItemTool.PluginCore.ActivityStateChanged += new VirindiItemTool.PluginCore.delActivityStateChanged(PluginCore_ActivityStateChanged);
VirindiItemTool.PluginCore.BeginSellBuy(sellItem.Name, buyItem.Name, buyAmount);
}
}
}
}

Expand Down Expand Up @@ -265,8 +288,10 @@ private WorldObject GetSellItem(VTClassic.LootCore looter)

foreach (WorldObject playerObj in CoreManager.Current.WorldFilter.GetInventory())
{
// Safety check to prevent equipped items from being sold.
if (playerObj.Values(LongValueKey.EquipableSlots, 0) > 0)
// Safety check to prevent equipped items from being sold.
// Changed from -- if (playerObj.Values(LongValueKey.EquipableSlots, 0) > 0)
// Equipable slots is always > 0 for armor. Equipped Slots is only > 0 if equiped
if (playerObj.Values(LongValueKey.EquippedSlots, 0) > 0)
continue;

// Convert the vendor item into a VT GameItemInfo object
Expand Down Expand Up @@ -351,14 +376,17 @@ private void DoTestMode()

foreach (WorldObject playerObj in CoreManager.Current.WorldFilter.GetInventory())
{
// Safety check to prevent equipped items from being sold.
if (playerObj.Values(LongValueKey.EquipableSlots, 0) > 0)
continue;

// Convert the vendor item into a VT GameItemInfo object
uTank2.LootPlugins.GameItemInfo itemInfo = uTank2.PluginCore.PC.FWorldTracker_GetWithID(playerObj.Id);

if (itemInfo == null)
// Safety check to prevent equipped items from being sold.
// Changed from -- if (playerObj.Values(LongValueKey.EquipableSlots, 0) > 0)
// Equipable slots is always > 0 for armor. Equipped Slots is only > 0 if equiped
if (playerObj.Values(LongValueKey.EquippedSlots, 0) > 0)
continue;

// Convert the vendor item into a VT GameItemInfo object
uTank2.LootPlugins.GameItemInfo itemInfo = uTank2.PluginCore.PC.FWorldTracker_GetWithID(playerObj.Id);

if (itemInfo == null)
{
Debug.WriteToChat("AutoBuySell.DoTestMode(), itemInfo == null for " + playerObj.Name);
continue;
Expand All @@ -367,10 +395,10 @@ private void DoTestMode()
// Get the loot profile result for this object
// result.IsNoLoot will always be false so we must check the Keep # against items in inventory.
uTank2.LootPlugins.LootAction result = ((VTClassic.LootCore)lootProfile).GetLootDecision(itemInfo);

if (result.IsSell)
Debug.WriteToChat(playerObj.Name);
}
}
if (result.IsSell)
Debug.WriteToChat("Sell: " + playerObj.Name);
}
}
}
}