Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What is the purpose of this pull request?
Overview of changes:
Fixes #2672
Repeating what was mentioned in the original issue:
The fix simply adjusts the destination path of the
fonts
to match with ourcore-web
package's directory structure, i.e.fonts
folder will now be built outside of thecss
folder:This would align with the relative path used by
markbind.min.css
to access the font files, which means math equations should be properly rendered as expected.Anything you'd like to highlight/discuss:
It's possible that adjusting the destination path of the
fonts
folder like this may cause conflicting issues elsewhere in the codebase (though, it's unlikely that thefonts
folder is referenced elsewhere).Testing instructions:
npm run build:backend
Notice the difference in the matrix and Sigma, as well as some minor differences in the other text and notation.
Proposed commit message: (wrap lines at 72 characters)
Fix KaTeX font issue
Adjusts the destination path of the
fonts
folder to align withthe
core-web
package's directory structure, allowing properaccess of the fonts for rendering KaTeX.
Checklist: ☑️
Reviewer checklist:
Indicate the SEMVER impact of the PR:
At the end of the review, please label the PR with the appropriate label:
r.Major
,r.Minor
,r.Patch
.Breaking change release note preparation (if applicable):