Skip to content

Fix issue with 404 page not working locally #2724

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
wants to merge 2 commits into
base: master
Choose a base branch
from
Open

Fix issue with 404 page not working locally #2724

Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
225c6ee
Add handler for error 404 to live-server
AgentHagu Jun 2, 2025
fed4f74
Merge branch 'master' into fix-404-response
AgentHagu Jun 4, 2025
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
17 changes: 15 additions & 2 deletions packages/cli/src/lib/live-server/index.js
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -102,7 +102,7 @@ function staticServer(root) {
}

function error(err) {
if (err.status === 404) return next();
// CHANGED: Removed if condition that checks for 404
next(err);
}

Expand Down Expand Up @@ -262,7 +262,20 @@ LiveServer.start = function(options) {
});
app.use(staticServerHandler) // Custom static server
.use(entryPoint(staticServerHandler, file))
.use(serveIndex(root, { icons: true }));
.use(serveIndex(root, { icons: true }))
// CHANGED: Added error handler to serve 404.html page
.use((err, req, res, next) => {
if (err.status === 404) {
res.statusCode = 404;
res.setHeader("Content-Type", "text/html");
const notFoundPage = path.join(root, "404.html");
fs.createReadStream(notFoundPage).pipe(res)
} else {
console.error(err.stack);
res.statusCode = err.status || 500;
res.end("Internal Server Error");
}
});

var server, protocol;
if (https !== null) {
Expand Down