-
Notifications
You must be signed in to change notification settings - Fork 482
Bump version to v26.0.0-dev.0, adapt release scripting & tests #33983
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
23e921a to
c113d4e
Compare
c113d4e to
fec4922
Compare
5ef9271 to
cf631bd
Compare
|
@teskje We are still seeing a bunch of upgrade test failures: Checks 0dt upgrade across four versions Are there already changes in flight that will fix that? |
bdb5638 to
b3ceb6f
Compare
b3ceb6f to
9a2f60b
Compare
|
Yep, #34027 is supposed to resolve the version jump errors. It changes how the persist shard version gets updated. Currently, the read-only env bumps the shard version, which makes the leader env shut down. With Ben's change, the read-only env only observes the shard version and it doesn't get bumped until the promotion happens. Which means we won't to rush to get any changes into 0.164, we only need to merge Ben's PR before 26.0. |
|
Awesome, then I hope we can merge that soon! CC @bkirwi |
9c2101e to
fa8ba62
Compare
|
Ready for review! |
teskje
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM, provided the tests pass!
fa8ba62 to
960a983
Compare
960a983 to
c4e4497
Compare
|
Nightly is looking mostly ok: https://buildkite.com/materialize/nightly/builds/14041 |
This should be merged on Friday, November 7, after we cut the next v0.X.Y release. Then we have 6 days in testing where we already have a v26.0.0-dev.0 version to play around with before cutting it into v26.0.0-rc.1 on Thursday, November 13.
Status: Currently blocked on #34027
Checklist
$T ⇔ Proto$Tmapping (possibly in a backwards-incompatible way), then it is tagged with aT-protolabel.