-
Notifications
You must be signed in to change notification settings - Fork 482
Make password hash iterations configurable #34048
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
base: main
Are you sure you want to change the base?
Conversation
31cf233 to
d414346
Compare
Move password hash iterations to a system var. Defaults to 600_000 and uses 600_000 for all system users.
d414346 to
7ad5109
Compare
cae1ec5 to
fbbc7bd
Compare
| password, | ||
| &attributes | ||
| .scram_iterations | ||
| .expect("If there's a password there must be hash iterations"), |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
While this should be true, I'm open to other ways to do this. It seems like the attribute field needs to be Optional<NonZeroU32>, at least nothing else really makes sense, and this part of the code doesn't have access to dyncfg so it can't fetch a well known default. I suppose we could set to 600_000 with a soft panic?
Move password hash iterations to a system var.
Defaults to 600_000 and uses 600_000 for
all system users.
Motivation
Tips for reviewer
Checklist
$T ⇔ Proto$Tmapping (possibly in a backwards-incompatible way), then it is tagged with aT-protolabel.