Skip to content

Add password auth support #43

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 3 commits into from
Jun 24, 2025
Merged

Add password auth support #43

merged 3 commits into from
Jun 24, 2025

Conversation

bobbyiliev
Copy link
Collaborator

@bobbyiliev bobbyiliev requested review from alex-hunt-materialize, jubrad, kay-kim and def- and removed request for alex-hunt-materialize June 12, 2025 13:53
def-
def- approved these changes Jun 12, 2025
View reviewed changes
Copy link
Contributor

@def- def- left a comment •
edited
Loading

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Edit: Nonsense was here.

@bobbyiliev bobbyiliev mentioned this pull request Jun 12, 2025
Merged
3 tasks
jubrad
jubrad approved these changes Jun 17, 2025
View reviewed changes
Copy link
Contributor

@jubrad jubrad left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Same comment about making the password a top level var. Big warnings or just move to random_password.

MaterializeInc/terraform-aws-materialize#72 (review)

@jubrad jubrad merged commit 1855279 into main Jun 24, 2025
2 checks passed
@jubrad jubrad deleted the add-auth-support branch June 24, 2025 05:13
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@def- def- def- approved these changes

@jubrad jubrad jubrad approved these changes

@kay-kim kay-kim Awaiting requested review from kay-kim

@alex-hunt-materialize alex-hunt-materialize Awaiting requested review from alex-hunt-materialize

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@bobbyiliev @def- @jubrad