New interface #5
Open
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Net8 update
# Conflicts: # Directory.Packages.props # McQuery.Net.slnx # README.md # sources/McQuery.Net/Data/ChallengeToken.cs # sources/McQuery.Net/Data/Packages/Request.cs # sources/McQuery.Net/Data/Packages/Responses/IResponse.cs # sources/McQuery.Net/Data/Packages/Responses/RawResponse.cs # sources/McQuery.Net/Data/Packages/Responses/ServerBasicStateResponse.cs # sources/McQuery.Net/Data/Packages/Responses/ServerFullStateResponse.cs # sources/McQuery.Net/Data/Packages/Responses/TimeoutResponse.cs # sources/McQuery.Net/Data/Packages/Responses/WrongResponse.cs # sources/McQuery.Net/Data/Server.cs # sources/McQuery.Net/Data/SessionId.cs # sources/McQuery.Net/GlobalUsings.cs # sources/McQuery.Net/Services/McQueryService.cs # sources/McQuery.Net/Services/RequestFormingService.cs # sources/McQuery.Net/Services/ResposeParsingService.cs # sources/McQuery.Net/Services/SessionIdProviderService.cs # sources/McQuery.Net/Services/UdpSendReceiveService.cs
MaxLevs
commented
Nov 19, 2024
Comment on lines
+33
to
+44
| return new FullStatus( | ||
| statusKeyValues["hostname"], | ||
| statusKeyValues["gametype"], | ||
| statusKeyValues["game_id"], | ||
| statusKeyValues["version"], | ||
| statusKeyValues["plugins"], | ||
| statusKeyValues["map"], | ||
| int.Parse(statusKeyValues["numplayers"]), | ||
| int.Parse(statusKeyValues["maxplayers"]), | ||
| players.ToArray(), | ||
| int.Parse(statusKeyValues["hostport"]), | ||
| statusKeyValues["hostip"]) |
There was a problem hiding this comment.
Should add try catch block in order to throw an appropriate exception in case if some field was gone missing for some reason
| namespace McQuery.Net.Exceptions; | ||
|
|
||
| [PublicAPI] | ||
| public class AlreadyExpiredException : ArgumentException |
There was a problem hiding this comment.
I think it can be internal. Should add public common McQuery exception instead to provide an appropriate message.
That's all we need to mark that something goes wrong I belive
MaxLevs
force-pushed
the
new-interface
branch
2 times, most recently
from
be329b2 to
8c88eef
Compare
liven-maksim-infotecs
force-pushed
the
new-interface
branch
from
0f0c256 to
b8a4d98
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Full interface refactoring.
Only public clients and data strucures can be accessed from outside code