tester: Skip package installation if it is already installed in system #24
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
lbt
reviewed
Sep 17, 2018
| skip_already_installed = ( | ||
| 'rpm -qi {package} ||' | ||
| ) | ||
| for name in self.test_packages: |
There was a problem hiding this comment.
Why have we gone from name in test_packages.keys(): to test_packages: ??
There was a problem hiding this comment.
for-loop itself unpacks keys from dict, so calling .keys() is overhead for iterating dict keys
lbt
reviewed
Sep 17, 2018
| install_comm = ['zypper', '-vv', 'in', '-y', '-f', '--force-resolution'] | ||
| install_comm.extend(packages) | ||
| self.commands.ssh(install_comm) | ||
| self.commands.ssh(pre_check+install_comm) |
There was a problem hiding this comment.
this looks like it will result in a command like:
rpm -qi pkgA ||rpm -qi pkgB ||rpm -qi pkgC || zypper', -vv -in -y -f --force-resolution pkgA pkgB pkgC pkgD pkgE
That won't install pkgD or pkgE because pkgA is installed and it will abort
Is that the intention?
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.