feat: Add Messenger error reporting
#6605
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Gudahtt
force-pushed
the
add-messenger-error-reporter
branch
4 times, most recently
from
48dd51d to
cd4e973
Compare
Gudahtt
force-pushed
the
add-messenger-error-reporter
branch
from
cd4e973 to
5265f8d
Compare
The `Messenger` class in `@metamask/messenger` has been updated to accept an optional `captureException` constructor parameter. This is now used to capture subscriber errors, instead of throwing them in a `setTimeout` (which would cause a crash on mobile). This is the implementation of the 2nd option in this ADR: https://github.com/MetaMask/decisions/blob/core-classes-error-reporting-strategy/decisions/core/0016-core-classes-error-reporting.md#optional-captureexception-constructor-parameter-that-inherits-from-parent
Gudahtt
force-pushed
the
add-messenger-error-reporter
branch
from
5265f8d to
57122d1
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Explanation
The
Messengerclass in@metamask/messengerhas been updated to accept an optionalcaptureExceptionconstructor parameter. This is now used to capture subscriber errors, instead of throwing them in asetTimeout(which would cause a crash on mobile).References
This is the implementation of the 2nd option in this ADR: https://github.com/MetaMask/decisions/blob/main/decisions/core/0016-core-classes-error-reporting.md#optional-captureexception-constructor-parameter-that-inherits-from-parent
Relates to #6613
Checklist