Skip to content

Conversation

ccharly
Copy link
Contributor

@ccharly ccharly commented Sep 15, 2025

Explanation

Back-porting fix from:

Basically, coming from our old account model, the selected account could be a Solana account, thus, it might exactly match (speaking of group index here) the equivalent EVM getSelectedAccount.

To fix this, we use getSelectedMultichainAccount which can either select a EVM or non-EVM account, thus, allowing the controller to pick the right account group.

References

N/A

Checklist

  • I've updated the test suite for new or updated code as appropriate
  • I've updated documentation (JSDoc, Markdown, etc.) for new or updated code as appropriate
  • I've communicated my changes to consumers by updating changelogs for packages I've changed, highlighting breaking changes as necessary
  • I've prepared draft pull requests for clients and consumer packages to resolve any breaking changes

@ccharly ccharly marked this pull request as ready for review September 15, 2025 16:16
@ccharly ccharly requested review from a team as code owners September 15, 2025 16:16
@ccharly ccharly changed the title fix(account-tree-controller): use getSelectedMultichainAccount fix(account-tree-controller): use getSelectedMultichainAccount Sep 16, 2025
@ccharly ccharly enabled auto-merge (squash) September 16, 2025 14:43
@ccharly ccharly merged commit c0e81d0 into main Sep 16, 2025
239 checks passed
@ccharly ccharly deleted the fix/account-tree-controller-initial-selected-account branch September 16, 2025 14:50
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants