Expose TransactionController methods needed by SmartTransactionsController through messenger #6615
+248
−1
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…oller through messenger Currently, the `confirmExternalTransaction`, `getNonceLock`, `getTransactions`, and `updateTransaction` methods in `TransactionController` are accessed by the `SmartTransactionsController` constructor, but in a non-standard way: `SmartTransactionsController` takes function references, when we would like to call these methods via the messenger instead. This commit exposes these methods through TransactionController's messenger so we can do this.
mcmire
force-pushed
the
expose-more-txn-controller-actions
branch
from
2215843 to
a31aa8a
Compare
![cursor[bot]](https://avatars.githubusercontent.com/in/1210556?s=60&v=4){kind=small}
This comment was marked as outdated.
This comment was marked as outdated.
Sorry, something went wrong.
OGPoyraz
approved these changes
Sep 16, 2025
matthewwalsh0
approved these changes
Sep 16, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Explanation
Currently, the
confirmExternalTransaction,getNonceLock,getTransactions, andupdateTransactionmethods inTransactionControllerare accessed by theSmartTransactionsControllerconstructor, but in a non-standard way:SmartTransactionsControllertakes function references, when we would like it to call these methods via the messenger instead.This commit exposes these methods through TransactionController's messenger so we can do this.
References
Unblocks MetaMask/smart-transactions-controller#533.
Also see https://github.com/MetaMask/metamask-mobile/blob/d5893bdcb0fa9c5e73b23ba566b6619730849b4c/app/core/Engine/Engine.ts#L1131 for how SmartTransactionsController is instantiated in Mobile today.
Checklist