feat: add tracing to multichain account service #7006
+2,105
−110
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
![cursor[bot]](https://avatars.githubusercontent.com/in/1210556?s=60&v=4){kind=small}
This comment was marked as outdated.
This comment was marked as outdated.
Sorry, something went wrong.
This comment was marked as outdated.
This comment was marked as outdated.
Sorry, something went wrong.
montelaidev
force-pushed
the
fix/mul-1186
branch
from
5a26cc8 to
3190bca
Compare
ccharly
reviewed
Oct 30, 2025
packages/multichain-account-service/src/MultichainAccountWallet.ts
Outdated
Show resolved
Hide resolved
packages/multichain-account-service/src/MultichainAccountWallet.ts
Outdated
Show resolved
Hide resolved
packages/multichain-account-service/src/MultichainAccountWallet.test.ts
Outdated
Show resolved
Hide resolved
packages/multichain-account-service/src/MultichainAccountWallet.ts
Outdated
Show resolved
Hide resolved
|
@metamaskbot publish-preview |
This comment was marked as outdated.
This comment was marked as outdated.
Sorry, something went wrong.
|
Preview builds have been published. See these instructions for more information about preview builds. Expand for full list of packages and versions. |
ccharly
reviewed
Oct 31, 2025
packages/multichain-account-service/src/providers/EvmAccountProvider.ts
Outdated
Show resolved
Hide resolved
packages/multichain-account-service/src/providers/EvmAccountProvider.test.ts
Outdated
Show resolved
Hide resolved
packages/multichain-account-service/src/providers/EvmAccountProvider.test.ts
Outdated
Show resolved
Hide resolved
packages/multichain-account-service/src/MultichainAccountService.ts
Outdated
Show resolved
Hide resolved
ccharly
reviewed
Nov 5, 2025
packages/multichain-account-service/src/providers/SolAccountProvider.test.ts
Outdated
Show resolved
Hide resolved
packages/multichain-account-service/src/providers/SolAccountProvider.test.ts
Outdated
Show resolved
Hide resolved
packages/multichain-account-service/src/providers/TrxAccountProvider.test.ts
Outdated
Show resolved
Hide resolved
Comment on lines
25
to
28
| if (fn) { | ||
| return await fn(); | ||
| } | ||
| return undefined; |
There was a problem hiding this comment.
We can just re-use traceFallback here maybe? Or do we really need to match that at all? 🤔
packages/multichain-account-service/src/providers/BtcAccountProvider.test.ts
Outdated
Show resolved
Hide resolved
packages/multichain-account-service/src/providers/BtcAccountProvider.test.ts
Outdated
Show resolved
Hide resolved
packages/multichain-account-service/src/providers/SnapAccountProvider.test.ts
Outdated
Show resolved
Hide resolved
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Explanation
This PR adds traces to the Multichain Account Service.
References
Checklist
Note
Introduces optional tracing across Multichain Account Service and providers, wrapping EVM/Solana/Bitcoin/Tron account discovery in trace callbacks with a fallback and tests.
config.tracetoMultichainAccountServiceand pass callback to providers; default totraceFallback.analytics/traceswithtraceFallbackandTraceNameenum.EvmAccountProvider,SolAccountProvider,TrxAccountProvider,BtcAccountProvider:TraceCallback; wrapdiscoverAccountsin trace with provider metadata.SnapAccountProvider:tracehelper and concurrency wrapper; support default/custom trace.maxConcurrency: 3for Bitcoin/Tron.Written by Cursor Bugbot for commit defd4e7. This will update automatically on new commits. Configure here.