fix(account-tree-controller)!: automatically removes "outdated" accounts from multichain account groups #7038
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
@metamaskbot publish-previews |
|
Preview builds have been published. See these instructions for more information about preview builds. Expand for full list of packages and versions. |
ccharly
force-pushed
the
fix/account-tree-controller-disabled-accounts
branch
from
8cb8a9e to
60778d9
Compare
|
@metamaskbot publish-previews |
|
Preview builds have been published. See these instructions for more information about preview builds. Expand for full list of packages and versions. |
|
@metamaskbot publish-previews |
|
Preview builds have been published. See these instructions for more information about preview builds. Expand for full list of packages and versions. |
ccharly
commented
Nov 4, 2025
Comment on lines
+257
to
+262
| this.messenger.subscribe( | ||
| 'MultichainAccountService:multichainAccountGroupCreated', | ||
| (group) => { | ||
| this.#handleMultichainAccountWalletGroupCreatedOrUpdated(group); | ||
| }, | ||
| ); |
There was a problem hiding this comment.
Since one should really be useful, but I added it in to avoid having another breaking change with another PR that should replace this one someday:
|
@metamaskbot publish-previews |
|
Preview builds have been published. See these instructions for more information about preview builds. Expand for full list of packages and versions. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Explanation
Multichain account groups can "disable" accounts using
AccountProviderWrappers. This is mostly used in combination with remote feature flags or with the "Basic Functionality" flags.Though, since the account tree is not "consuming" multichain account groups directly, the account list from those groups was not properly updated (since not
:account{Added,Removed}are used in this case), resulting in a de-sync between the groups from the tree and the groups from the service.Note
This PR aims to fix this de-sync in a simple way without involving too many architecture changes (so it's less risky to release this first), but the real fix for this is there:
multichain-account-serviceto build multichain account wallet/group nodes #6646References
N/A
Checklist
Note
AccountTreeController now skips and removes “outdated” BIP‑44 accounts using MultichainAccountService actions/events, MultichainAccountService simplifies provider creation/error handling, and repo scripts/configs are cleaned up (drop build:all, adjust ts-bridge, prettier/yarn).
MultichainAccountService:getMultichainAccountWallets.MultichainAccountService:multichainAccountGroup{Created,Updated}to remove accounts no longer in a group.createMultichainAccountGroupto either await all providers or just EVM, running others in background with logging; aggregate errors when awaiting all.utils.build:allacross packages and relax Yarn constraints; reorderbuild:docswhere needed.@ts-bridge/clito^0.6.1; updateyarn.lock.Written by Cursor Bugbot for commit 3c46556. This will update automatically on new commits. Configure here.