-
-
Notifications
You must be signed in to change notification settings - Fork 252
Feat/expose list of pending revocations in state #7049
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Closed
V00D00-child
wants to merge
15
commits into
main
from
feat/expose-list-of-pending-revocations-in-state
Closed
Feat/expose list of pending revocations in state #7049
V00D00-child
wants to merge
15
commits into
main
from
feat/expose-list-of-pending-revocations-in-state
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…he consumer to submitRevocation
- Add RevocationParams type with delegationHash field - Add PermissionProviderSubmitRevocation RPC method enum - Implement submitRevocation method with proper error handling - Add comprehensive test suite with 100% coverage - Export new types in public API This enables MetaMask clients to submit permission revocations through the gator permissions provider snap using the permissionsProvider_submitRevocation RPC method.
…re into chore/revokation-rpc-request
Member
Author
|
Replaced with #7055 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Explanation
Expose the list of pending revocations in the state to allow MM clients to create custom selectors that filter on
pendingRevocationsto determine whether the revoke CTA should show the "pending" status.pendingRevocationsstate on calls toaddPendingRevocation()pendingRevocationsstate given atransactionIdwhen the handler'scleanup()function is executed.References
Forked from #6713
Checklist
Note
Adds a
pendingRevocationsstate with getter and lifecycle management tied to transaction events and timeout during revocation flow.pendingRevocationsarray toGatorPermissionsControllerState(default[]); update metadata (includeInStateLogs,usedInUi, non-persistent).pendingRevocationsgetter; private helpers#addPendingRevocationToStateand#removePendingRevocationFromState.addPendingRevocationnow records pending item immediately, subscribes totransactionConfirmed/Failed/Dropped, removes pending on any terminal event or timeout, and submits revocation on confirm.pendingRevocationsin logs/UI.pendingRevocations: []where needed; add test validatingpendingRevocationsgetter.Written by Cursor Bugbot for commit f2c2c8d. This will update automatically on new commits. Configure here.