Skip to content

Conversation

@cryptodev-2s
Copy link
Contributor

@cryptodev-2s cryptodev-2s commented Nov 5, 2025

Explanation

Updates the github-tools changelog-check workflow to fix detection of devDependencies-only changes in package.json.

What's Fixed

The previous version failed to properly detect when package.json changes were only in devDependencies because the git diff logic required both the start and end of the devDependencies section to be visible. With limited diff context (-U20), the closing brace was often not included in the diff output.

The new version increases git diff context from -U20 to -U9999 to ensure section headers are always visible, allowing proper detection of devDependencies-only changes.

Changes

  • Updated MetaMask/github-tools/.github/workflows/changelog-check.yml from fc6fe1a to c0ec1c3 (PR containing the fix)

References

Checklist

  • I've updated the test suite for new or updated code as appropriate
  • I've updated documentation (JSDoc, Markdown, etc.) for new or updated code as appropriate
  • I've communicated my changes to consumers by updating changelogs for packages I've changed, highlighting breaking changes as necessary
  • I've prepared draft pull requests for clients and consumer packages to resolve any breaking changes

Note

Updates the changelog-check GitHub Actions workflow to use MetaMask/github-tools commit c0ec1c3.

  • CI:
    • Update changelog-check reusable workflow reference and action-sha to c0ec1c3 in .github/workflows/changelog-check.yml.

Written by Cursor Bugbot for commit 44a036e. This will update automatically on new commits. Configure here.

@cryptodev-2s cryptodev-2s requested a review from mcmire November 5, 2025 15:38
@cryptodev-2s cryptodev-2s self-assigned this Nov 5, 2025
@cryptodev-2s cryptodev-2s marked this pull request as ready for review November 5, 2025 15:38
@cryptodev-2s cryptodev-2s requested a review from a team as a code owner November 5, 2025 15:38
@cryptodev-2s cryptodev-2s enabled auto-merge (squash) November 5, 2025 15:39
@cryptodev-2s cryptodev-2s force-pushed the update-changelog-check-workflow branch from 4de0c6e to 246a272 Compare November 5, 2025 21:07
@cryptodev-2s cryptodev-2s removed the request for review from mcmire November 6, 2025 10:27
@cryptodev-2s cryptodev-2s force-pushed the update-changelog-check-workflow branch from 246a272 to 44a036e Compare November 6, 2025 10:27
@cryptodev-2s cryptodev-2s merged commit 0c4fcb3 into main Nov 6, 2025
266 checks passed
@cryptodev-2s cryptodev-2s deleted the update-changelog-check-workflow branch November 6, 2025 10:41
cryptodev-2s added a commit that referenced this pull request Nov 6, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants