Testing autochangelog update #128
+227
−129
There are no files selected for viewing
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| Original file line number | Diff line number | Diff line change |
|---|---|---|
|
|
@@ -298,7 +298,7 @@ create_changelog_pr() { | |
|
|
||
| # Generate Changelog and Test Plan | ||
| echo "Generating changelog via auto-changelog.." | ||
| yarn auto-changelog update --rc --repo "https://github.com/MetaMask/metamask-extension" --currentVersion "${new_version}" --autoCategorize --useChangelogEntry --useShortPrLink | ||
|
There was a problem hiding this comment. The repo shall not be hardcoded to "https://github.com/MetaMask/metamask-extension". It can also be "https://github.com/MetaMask/metamask-mobile". There was a problem hiding this comment. Oh, yes, that just had to be done so it could run in |
||
|
|
||
| # Skip commits.csv for hotfix releases (previous_version_ref is literal "null") | ||
| # - When we create a new major/minor release, we fetch all commits included in the release, by fetching the diff between HEAD and previous version reference. | ||
|
|
@@ -372,7 +372,7 @@ create_changelog_pr() { | |
|
|
||
| # Use helper functions for push and PR creation | ||
| push_branch_with_handling "${changelog_branch_name}" | ||
| create_pr_if_not_exists "${changelog_branch_name}" "release: ${changelog_branch_name}" "${pr_body}" "${release_branch_name}" "" "search" | ||
|
|
||
| echo "Changelog PR Ready" | ||
| } | ||
|
|
@@ -492,7 +492,7 @@ main() { | |
| # Initialize branch names | ||
| local release_branch_name changelog_branch_name version_bump_branch_name | ||
| release_branch_name=$(get_release_branch_name "$NEW_VERSION") | ||
| changelog_branch_name="release/${NEW_VERSION}-Changelog" | ||
| version_bump_branch_name=$(get_version_bump_branch_name "$next_version") # Execute main workflow | ||
| configure_git | ||
|
|
||
|
|
@@ -521,7 +521,7 @@ main() { | |
| echo "Created PRs:" | ||
| echo "1. Release PR: release: ${NEW_VERSION}" | ||
| if [ "$TEST_ONLY" != "true" ]; then | ||
| echo "2. Changelog PR: release: ${changelog_branch_name}" | ||
| if [[ "${PREVIOUS_VERSION_REF,,}" == "null" ]]; then | ||
| echo "(Hotfix) Skipped version bump PR" | ||
| else | ||
|
|
||
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Oops, something went wrong.
Oops, something went wrong.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Bug: Hardcoded URL Breaks Multi-Platform Changelog
The
auto-changelogcommand now uses a hardcoded repository URL (https://github.com/MetaMask/metamask-extension) instead of the dynamicGITHUB_REPOSITORY_URLenvironment variable. This breaks the script's intended multi-platform support, causing changelogs for other repositories (e.g., mobile) to incorrectly reference the extension repository.