generated from MetaMask/metamask-module-template
-
-
Notifications
You must be signed in to change notification settings - Fork 4
feat(create-pr): Improve the version executed (SHA instead branch) #81
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Open
alucardzom
wants to merge
21
commits into
main
Choose a base branch
from
ale/release-branch-improvement
base: main
Could not load branches
Branch not found: {{ refName }}
Loading
Could not load tags
Nothing to show
Loading
Are you sure you want to change the base?
Some commits from the old base branch may be removed from the timeline,
and old review comments may become outdated.
Open
Changes from all commits
Commits
Show all changes
21 commits
Select commit
Hold shift + click to select a range
c115d1e
chore: comment line
alucardzom bb66c72
chore: added GH a ref
alucardzom 7f7779f
chore: improve the pipeline
alucardzom 3c71867
chore: added SHA
alucardzom e2e7d57
chore: test action ref
alucardzom cd0845d
chore: test print variables
alucardzom 5c25eb4
chore: test workflow SHA
alucardzom 926af03
chore: check SHA
alucardzom 7dd3aac
chore: check gh act re
alucardzom 540b9c2
chore: dump gh context
alucardzom c9e371b
chore: rollback to use the commit id or branch name
alucardzom f80f44e
chore: typo in conditional at create pl script
alucardzom 092bb61
chore: test passing branch name as argument
alucardzom d86a531
chore: comment gsheet step
alucardzom b3aff48
chore: making some tests before passing draft
alucardzom 338ca33
chore: remove dump gh action
alucardzom 0f22ac9
chore: test tricky thing
alucardzom 0fe2ac4
chore: linter
alucardzom 7b60ec0
chore: fix typos
alucardzom e2e1b62
chore: update .github/workflows/create-release-pr.yml
alucardzom bd9d9e7
chore: restore create platform release and generate-rc-commits
alucardzom File filter
Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
There are no files selected for viewing
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| Original file line number | Diff line number | Diff line change |
|---|---|---|
|
|
@@ -254,4 +254,4 @@ else | |
| echo "Changelog PR Created" | ||
| fi | ||
|
|
||
| echo "Changelog PR Ready" | ||
| echo "Changelog PR Ready" | ||
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Oops, something went wrong.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Nit: Presumably this was a mistake? Not super important though