feat: shield subscription error state toasts #36718

lionellbriones · 2025-10-09T09:48:13Z

Description

Added toasts to display Shield subscription's error states.

Shield payment declined

Requirements to show:
- Subscription is paused
- User has not clicked or closed the toast before
When user clicks on the action button, set closed/closed flag to true then app will redirect to shield settings page
When user clicks closes, set closed/closed flag to true

Shield coverage ending

Requirements to show:
- Subscription is cancelled
- is Crypto payment
- User has not clicked or closed the toast before
When user clicks on the action button, set closed/closed flag to true then app will redirect to shield settings page
When user clicks closes, set closed/closed flag to true

Changelog

CHANGELOG entry: Added shield subscription error toasts

Related issues

Fixes:

Manual testing steps

Go to this page...

Screenshots/Recordings

Before

After

Pre-merge author checklist

I've followed MetaMask Contributor Docs and MetaMask Extension Coding Standards.
I've completed the PR template to the best of my ability
I’ve included tests if applicable
I’ve documented my code using JSDoc format if applicable
I’ve applied the right labels on the PR (see labeling guidelines). Not required for external contributors.

Pre-merge reviewer checklist

I've manually tested the PR (e.g. pull and build branch, run the app, test code being changed).
I confirm that this PR addresses all acceptance criteria described in the ticket it closes and includes the necessary testing evidence such as recordings and or screenshots.

Note

Adds Shield “payment declined” and “coverage ending” toasts, with persisted dismiss state, selectors, and subscription paused/ending logic, plus i18n and tests.

UI/Toasts:
- Add ShieldPausedToast and ShieldEndingToast in toast-master.js; wire into ToastMaster and navigate to TRANSACTION_SHIELD_ROUTE on action.
- New selectors selectShowShieldPausedToast and selectShowShieldEndingToast.
- Background actions to persist dismiss timestamps via setShieldPausedToastLastClickedOrClosed and setShieldEndingToastLastClickedOrClosed.
State/Controllers:
- App state: add shieldPausedToastLastClickedOrClosed and shieldEndingToastLastClickedOrClosed (defaults, metadata, setters) in app-state-controller.ts, exposed via metamask-controller.js.
- Include new fields in sentry-state allowlist and background/UI types.
Shield logic (shared/lib/shield.ts):
- Factor out getShieldSubscription; add getIsShieldSubscriptionPaused and getIsShieldSubscriptionEndingSoon; keep getIsShieldSubscriptionActive.
- New PausedSubscriptionStatuses in shared/constants/subscriptions.ts.
- Use new helpers in transaction-shield.tsx.
i18n:
- Add messages for coverage ending and payment declined (titles, actions, descriptions) in app/_locales/en*.json.
Tests/Metrics:
- Add unit tests for new setters; update e2e metrics masks and state snapshots; adjust test fixtures to include new state fields.

^{Written by Cursor Bugbot for commit 541d9fd. This will update automatically on new commits. Configure here.}

- banner radius to 12px - button radius 8px and medium text

github-actions · 2025-10-09T09:48:21Z

CLA Signature Action: All authors have signed the CLA. You may need to manually re-run the blocking PR check if it doesn't pass in a few minutes.

metamaskbot · 2025-10-13T09:16:55Z

📊 Page Load Benchmark Results

Current Commit: a5dae8b | Date: 10/13/2025

📄 Localhost MetaMask Test Dapp

Samples: 100

Summary

pageLoadTime-> current mean value: 1.05s (±73ms) 🟡 | historical mean value: 1.05s ⬇️ (historical data)
domContentLoaded-> current mean value: 737ms (±70ms) 🟢 | historical mean value: 737ms ⬆️ (historical data)
firstContentfulPaint-> current mean value: 76ms (±10ms) 🟢 | historical mean value: 79ms ⬇️ (historical data)

📈 Detailed Results

Metric	Mean	Std Dev	Min	Max	P95	P99
pageLoadTime	1.05s	73ms	1.01s	1.33s	1.30s	1.33s
domContentLoaded	737ms	70ms	700ms	998ms	984ms	998ms
firstPaint	76ms	10ms	60ms	160ms	84ms	160ms
firstContentfulPaint	76ms	10ms	60ms	160ms	84ms	160ms
largestContentfulPaint	0ms	0ms	0ms	0ms	0ms	0ms

Results generated automatically by MetaMask CI

metamaskbot · 2025-10-13T09:16:59Z

Builds ready [a5dae8b]

builds: chrome, firefox
builds (beta): chrome, firefox
builds (flask): chrome, firefox
builds (test): chrome, firefox
builds (test-flask): chrome, firefox
build viz: Build System
bundle size: Bundle Size Stats
user-actions-benchmark: User Actions Stats
storybook: Storybook
typescript migration: Dashboard
all artifacts
bundle viz:
- background: 0, 1, 2, 3, 4, 5, 6, 7, 8
- common: 0, 1, 2, 3, 4, 5, 6, 7, 8, 9, 10, 11, 12, 13
- ui: 0, 1, 2, 3, 4, 5, 6, 7, 8, 9, 10, 11, 12, 13, 14
- content-script: 0
- offscreen: 0

UI Startup Metrics (1256 ± 69 ms)

Platform	BuildType	Page	Metric	Mean (ms)	Min (ms)	Max (ms)	Std Dev (ms)	P 75 (ms)	P 95 (ms)
Chrome	Browserify	Home	uiStartup	1256	1148	1481	69	1291	1383
			load	1079	973	1298	65	1098	1248
			domContentLoaded	1072	945	1294	66	1093	1241
			domInteractive	17	13	66	7	17	27
			firstPaint	637	72	1271	445	1084	1169
			backgroundConnect	257	241	380	15	259	272
			firstReactRender	27	19	118	11	28	48
			getState	12	5	84	10	12	28
			initialActions	5	1	50	7	6	18
			loadScripts	823	695	1043	65	840	987
			setupStore	9	6	26	4	9	18
	Webpack	Home	uiStartup	837	708	1125	76	856	1057
			load	642	584	959	79	642	901
			domContentLoaded	634	576	950	78	635	891
			domInteractive	17	11	70	11	15	43
			firstPaint	172	53	908	158	173	600
			backgroundConnect	22	10	51	7	27	30
			firstReactRender	27	17	37	7	32	34
			getState	8	4	14	3	10	13
			initialActions	2	0	7	2	3	5
			loadScripts	631	574	938	76	633	878
			setupStore	8	4	14	2	9	11
Firefox	Browserify	Home	uiStartup	1454	1245	1972	130	1507	1740
			load	1234	1076	1503	86	1298	1389
			domContentLoaded	1234	1075	1503	86	1298	1389
			domInteractive	105	35	296	60	105	265
			firstPaint	NaN	NaN	NaN	NaN	NaN	NaN
			backgroundConnect	33	20	149	18	34	68
			firstReactRender	31	26	59	5	32	42
			getState	9	3	187	20	6	33
			initialActions	8	0	168	23	2	50
			loadScripts	1210	1058	1485	83	1278	1330
			setupStore	9	4	57	9	7	30
	Webpack	Home	uiStartup	1550	1347	2259	124	1573	1775
			load	1343	1196	1842	92	1372	1504
			domContentLoaded	1342	1196	1842	92	1371	1503
			domInteractive	98	30	381	57	102	176
			firstPaint	NaN	NaN	NaN	NaN	NaN	NaN
			backgroundConnect	33	18	156	18	36	66
			firstReactRender	34	26	84	9	36	43
			getState	8	2	72	11	5	43
			initialActions	4	0	53	8	2	16
			loadScripts	1317	1181	1701	82	1345	1472
			setupStore	12	4	126	18	7	48

Bundle size diffs [🚨 Warning! Bundle size has increased!]

background: 58 Bytes (0%)
ui: 2.26 KiB (0.03%)
common: 432 Bytes (0.01%)

metamaskbot · 2025-10-13T15:47:44Z

📊 Page Load Benchmark Results

Current Commit: 6b061bf | Date: 10/13/2025

📄 Localhost MetaMask Test Dapp

Samples: 100

Summary

pageLoadTime-> current mean value: 1.06s (±71ms) 🟡 | historical mean value: 1.05s ⬆️ (historical data)
domContentLoaded-> current mean value: 745ms (±69ms) 🟢 | historical mean value: 737ms ⬆️ (historical data)
firstContentfulPaint-> current mean value: 78ms (±13ms) 🟢 | historical mean value: 77ms ⬆️ (historical data)

📈 Detailed Results

Metric	Mean	Std Dev	Min	Max	P95	P99
pageLoadTime	1.06s	71ms	1.02s	1.33s	1.28s	1.33s
domContentLoaded	745ms	69ms	706ms	1.01s	954ms	1.01s
firstPaint	78ms	13ms	60ms	188ms	88ms	188ms
firstContentfulPaint	78ms	13ms	60ms	188ms	88ms	188ms
largestContentfulPaint	0ms	0ms	0ms	0ms	0ms	0ms

Results generated automatically by MetaMask CI

metamaskbot · 2025-10-13T15:47:58Z

Builds ready [6b061bf]

builds: chrome, firefox
builds (beta): chrome, firefox
builds (flask): chrome, firefox
builds (test): chrome, firefox
builds (test-flask): chrome, firefox
build viz: Build System
bundle size: Bundle Size Stats
user-actions-benchmark: User Actions Stats
storybook: Storybook
typescript migration: Dashboard
all artifacts
bundle viz:
- background: 0, 1, 2, 3, 4, 5, 6, 7, 8
- common: 0, 1, 2, 3, 4, 5, 6, 7, 8, 9, 10, 11, 12, 13
- ui: 0, 1, 2, 3, 4, 5, 6, 7, 8, 9, 10, 11, 12, 13, 14
- content-script: 0
- offscreen: 0

UI Startup Metrics (1223 ± 58 ms)

Platform	BuildType	Page	Metric	Mean (ms)	Min (ms)	Max (ms)	Std Dev (ms)	P 75 (ms)	P 95 (ms)
Chrome	Browserify	Home	uiStartup	1223	1108	1439	58	1257	1327
			load	1054	957	1183	48	1086	1134
			domContentLoaded	1048	951	1172	48	1079	1128
			domInteractive	18	13	135	13	17	38
			firstPaint	676	138	1180	427	1070	1128
			backgroundConnect	250	238	273	7	253	263
			firstReactRender	24	17	49	6	26	39
			getState	12	5	66	9	13	33
			initialActions	4	0	43	6	4	14
			loadScripts	804	715	919	47	831	879
			setupStore	8	5	39	4	9	15
	Webpack	Home	uiStartup	826	700	1272	84	846	983
			load	632	577	1124	81	634	832
			domContentLoaded	624	571	1117	80	627	828
			domInteractive	16	11	52	8	14	36
			firstPaint	178	55	898	165	189	592
			backgroundConnect	20	10	39	6	22	31
			firstReactRender	28	17	73	10	32	52
			getState	8	3	22	3	9	14
			initialActions	2	0	9	2	3	6
			loadScripts	622	569	1106	78	625	818
			setupStore	8	4	15	2	9	12
Firefox	Browserify	Home	uiStartup	1409	1226	2017	132	1463	1662
			load	1196	1059	1447	90	1266	1361
			domContentLoaded	1196	1058	1447	90	1266	1360
			domInteractive	102	34	302	49	113	234
			firstPaint	NaN	NaN	NaN	NaN	NaN	NaN
			backgroundConnect	28	18	79	10	30	45
			firstReactRender	29	25	52	4	31	39
			getState	8	3	219	22	5	13
			initialActions	4	0	108	12	2	14
			loadScripts	1176	1041	1423	88	1248	1337
			setupStore	11	4	221	24	6	47
	Webpack	Home	uiStartup	1585	1389	2019	136	1647	1902
			load	1378	1230	1773	100	1434	1546
			domContentLoaded	1378	1230	1772	100	1433	1546
			domInteractive	107	31	507	81	106	355
			firstPaint	NaN	NaN	NaN	NaN	NaN	NaN
			backgroundConnect	33	18	113	15	35	63
			firstReactRender	34	27	79	10	35	64
			getState	8	3	169	19	5	15
			initialActions	5	0	64	10	3	25
			loadScripts	1353	1208	1748	99	1411	1520
			setupStore	12	4	152	22	7	47

Bundle size diffs [🚀 Bundle size reduced!]

background: 710 Bytes (0.02%)
ui: 2.82 KiB (0.04%)
common: -26.08 KiB (-0.31%)

metamaskbot · 2025-10-14T05:14:42Z

📊 Page Load Benchmark Results

Current Commit: 00568d5 | Date: 10/14/2025

📄 Localhost MetaMask Test Dapp

Samples: 100

Summary

pageLoadTime-> current mean value: 1.08s (±85ms) 🟡 | historical mean value: 1.05s ⬆️ (historical data)
domContentLoaded-> current mean value: 758ms (±84ms) 🟢 | historical mean value: 739ms ⬆️ (historical data)
firstContentfulPaint-> current mean value: 79ms (±9ms) 🟢 | historical mean value: 77ms ⬆️ (historical data)

📈 Detailed Results

Metric	Mean	Std Dev	Min	Max	P95	P99
pageLoadTime	1.08s	85ms	1.04s	1.41s	1.35s	1.41s
domContentLoaded	758ms	84ms	719ms	1.09s	1.02s	1.09s
firstPaint	79ms	9ms	64ms	152ms	92ms	152ms
firstContentfulPaint	79ms	9ms	64ms	152ms	92ms	152ms
largestContentfulPaint	0ms	0ms	0ms	0ms	0ms	0ms

Results generated automatically by MetaMask CI

metamaskbot · 2025-10-14T05:14:53Z

Builds ready [00568d5]

builds: chrome, firefox
builds (beta): chrome, firefox
builds (flask): chrome, firefox
builds (test): chrome, firefox
builds (test-flask): chrome, firefox
build viz: Build System
bundle size: Bundle Size Stats
user-actions-benchmark: User Actions Stats
storybook: Storybook
typescript migration: Dashboard
all artifacts
bundle viz:
- background: 0, 1, 2, 3, 4, 5, 6, 7, 8
- common: 0, 1, 2, 3, 4, 5, 6, 7, 8, 9, 10, 11, 12, 13
- ui: 0, 1, 2, 3, 4, 5, 6, 7, 8, 9, 10, 11, 12, 13, 14
- content-script: 0
- offscreen: 0

UI Startup Metrics (1224 ± 66 ms)

Platform	BuildType	Page	Metric	Mean (ms)	Min (ms)	Max (ms)	Std Dev (ms)	P 75 (ms)	P 95 (ms)
Chrome	Browserify	Home	uiStartup	1224	1098	1497	66	1269	1333
			load	1054	959	1317	60	1093	1148
			domContentLoaded	1048	946	1311	59	1087	1143
			domInteractive	17	13	42	5	16	33
			firstPaint	718	81	1183	412	1065	1146
			backgroundConnect	251	238	294	8	254	262
			firstReactRender	24	18	47	6	25	37
			getState	12	5	91	11	13	29
			initialActions	4	0	40	6	4	14
			loadScripts	803	708	1063	59	841	896
			setupStore	9	5	20	3	10	16
	Webpack	Home	uiStartup	773	666	1037	60	794	897
			load	588	539	879	61	591	700
			domContentLoaded	580	533	867	60	584	695
			domInteractive	15	11	48	8	14	35
			firstPaint	194	53	872	193	163	664
			backgroundConnect	21	10	38	6	25	32
			firstReactRender	25	16	50	7	31	33
			getState	8	3	21	3	10	14
			initialActions	2	0	12	2	2	6
			loadScripts	578	531	860	59	583	694
			setupStore	8	4	17	2	9	11
Firefox	Browserify	Home	uiStartup	1429	1221	1958	129	1502	1663
			load	1214	1051	1439	90	1290	1381
			domContentLoaded	1214	1051	1439	89	1289	1381
			domInteractive	103	35	296	52	104	234
			firstPaint	NaN	NaN	NaN	NaN	NaN	NaN
			backgroundConnect	30	19	116	12	34	51
			firstReactRender	30	25	56	6	31	48
			getState	9	3	197	23	5	27
			initialActions	3	0	87	9	2	8
			loadScripts	1192	1034	1418	89	1267	1340
			setupStore	11	4	155	23	6	55
	Webpack	Home	uiStartup	1564	1375	2086	122	1603	1802
			load	1358	1222	1646	84	1392	1534
			domContentLoaded	1357	1222	1646	84	1392	1534
			domInteractive	98	34	406	55	101	177
			firstPaint	NaN	NaN	NaN	NaN	NaN	NaN
			backgroundConnect	31	19	91	12	37	54
			firstReactRender	34	27	80	9	35	42
			getState	8	3	124	16	6	31
			initialActions	3	0	27	5	2	15
			loadScripts	1334	1205	1590	80	1366	1501
			setupStore	10	4	61	12	7	46

Bundle size diffs [🚨 Warning! Bundle size has increased!]

background: 720 Bytes (0.02%)
ui: 2.82 KiB (0.04%)
common: 1.22 KiB (0.01%)

metamaskbot · 2025-10-14T06:25:33Z

📊 Page Load Benchmark Results

Current Commit: bd18b04 | Date: 10/14/2025

📄 Localhost MetaMask Test Dapp

Samples: 100

Summary

pageLoadTime-> current mean value: 1.04s (±73ms) 🟡 | historical mean value: 1.05s ⬇️ (historical data)
domContentLoaded-> current mean value: 731ms (±70ms) 🟢 | historical mean value: 739ms ⬇️ (historical data)
firstContentfulPaint-> current mean value: 75ms (±11ms) 🟢 | historical mean value: 77ms ⬇️ (historical data)

📈 Detailed Results

Metric	Mean	Std Dev	Min	Max	P95	P99
pageLoadTime	1.04s	73ms	1.00s	1.31s	1.30s	1.31s
domContentLoaded	731ms	70ms	693ms	1.00s	975ms	1.00s
firstPaint	75ms	11ms	56ms	164ms	88ms	164ms
firstContentfulPaint	75ms	11ms	56ms	164ms	88ms	164ms
largestContentfulPaint	0ms	0ms	0ms	0ms	0ms	0ms

Results generated automatically by MetaMask CI

metamaskbot · 2025-10-14T06:25:38Z

Builds ready [bd18b04]

builds: chrome, firefox
builds (beta): chrome, firefox
builds (flask): chrome, firefox
builds (test): chrome, firefox
builds (test-flask): chrome, firefox
build viz: Build System
bundle size: Bundle Size Stats
user-actions-benchmark: User Actions Stats
storybook: Storybook
typescript migration: Dashboard
all artifacts
bundle viz:
- background: 0, 1, 2, 3, 4, 5, 6, 7, 8
- common: 0, 1, 2, 3, 4, 5, 6, 7, 8, 9, 10, 11, 12, 13
- ui: 0, 1, 2, 3, 4, 5, 6, 7, 8, 9, 10, 11, 12, 13, 14
- content-script: 0
- offscreen: 0

UI Startup Metrics (1238 ± 72 ms)

Platform	BuildType	Page	Metric	Mean (ms)	Min (ms)	Max (ms)	Std Dev (ms)	P 75 (ms)	P 95 (ms)
Chrome	Browserify	Home	uiStartup	1238	1100	1408	72	1286	1359
			load	1071	962	1216	66	1121	1184
			domContentLoaded	1065	957	1208	65	1110	1171
			domInteractive	18	14	87	9	17	35
			firstPaint	729	84	1228	430	1095	1188
			backgroundConnect	251	239	276	8	256	268
			firstReactRender	27	17	47	7	30	39
			getState	11	5	37	6	14	26
			initialActions	5	0	45	7	7	19
			loadScripts	820	721	965	64	870	930
			setupStore	9	5	19	3	10	18
	Webpack	Home	uiStartup	811	695	1116	68	828	919
			load	634	575	974	69	641	753
			domContentLoaded	627	569	966	69	637	747
			domInteractive	16	11	56	9	14	44
			firstPaint	184	57	898	178	188	590
			backgroundConnect	20	10	37	6	25	31
			firstReactRender	25	16	63	9	31	35
			getState	8	3	23	4	10	16
			initialActions	2	0	10	2	3	6
			loadScripts	624	567	955	68	636	746
			setupStore	7	4	15	2	8	10
Firefox	Browserify	Home	uiStartup	1398	1223	1804	130	1478	1710
			load	1192	1059	1446	86	1272	1333
			domContentLoaded	1192	1059	1446	86	1272	1333
			domInteractive	102	34	297	55	105	244
			firstPaint	NaN	NaN	NaN	NaN	NaN	NaN
			backgroundConnect	29	18	99	10	33	42
			firstReactRender	29	25	64	4	30	35
			getState	6	3	82	8	6	16
			initialActions	2	0	20	3	2	7
			loadScripts	1171	1043	1424	84	1248	1314
			setupStore	12	3	215	28	7	50
	Webpack	Home	uiStartup	1543	1370	2047	117	1601	1797
			load	1339	1197	1632	88	1383	1504
			domContentLoaded	1339	1197	1632	88	1383	1504
			domInteractive	98	32	393	68	99	318
			firstPaint	NaN	NaN	NaN	NaN	NaN	NaN
			backgroundConnect	32	18	118	16	35	61
			firstReactRender	35	26	84	11	37	75
			getState	9	2	163	21	6	19
			initialActions	3	0	42	7	2	23
			loadScripts	1315	1173	1605	87	1358	1477
			setupStore	12	4	230	27	6	58

Bundle size diffs [🚨 Warning! Bundle size has increased!]

background: 720 Bytes (0.02%)
ui: 2.35 KiB (0.04%)
common: 1.22 KiB (0.01%)

metamaskbot · 2025-10-14T07:22:20Z

📊 Page Load Benchmark Results

Current Commit: d4bd7fb | Date: 10/14/2025

📄 Localhost MetaMask Test Dapp

Samples: 100

Summary

pageLoadTime-> current mean value: 1.05s (±74ms) 🟡 | historical mean value: 1.05s ⬇️ (historical data)
domContentLoaded-> current mean value: 735ms (±72ms) 🟢 | historical mean value: 739ms ⬇️ (historical data)
firstContentfulPaint-> current mean value: 77ms (±13ms) 🟢 | historical mean value: 77ms ⬇️ (historical data)

📈 Detailed Results

Metric	Mean	Std Dev	Min	Max	P95	P99
pageLoadTime	1.05s	74ms	1.01s	1.38s	1.27s	1.38s
domContentLoaded	735ms	72ms	699ms	1.05s	940ms	1.05s
firstPaint	77ms	13ms	60ms	196ms	88ms	196ms
firstContentfulPaint	77ms	13ms	60ms	196ms	88ms	196ms
largestContentfulPaint	0ms	0ms	0ms	0ms	0ms	0ms

Results generated automatically by MetaMask CI

metamaskbot · 2025-10-14T07:22:25Z

Builds ready [d4bd7fb]

builds: chrome, firefox
builds (beta): chrome, firefox
builds (flask): chrome, firefox
builds (test): chrome, firefox
builds (test-flask): chrome, firefox
build viz: Build System
bundle size: Bundle Size Stats
user-actions-benchmark: User Actions Stats
storybook: Storybook
typescript migration: Dashboard
all artifacts
bundle viz:
- background: 0, 1, 2, 3, 4, 5, 6, 7, 8
- common: 0, 1, 2, 3, 4, 5, 6, 7, 8, 9, 10, 11, 12, 13
- ui: 0, 1, 2, 3, 4, 5, 6, 7, 8, 9, 10, 11, 12, 13, 14
- content-script: 0
- offscreen: 0

UI Startup Metrics (1224 ± 64 ms)

Platform	BuildType	Page	Metric	Mean (ms)	Min (ms)	Max (ms)	Std Dev (ms)	P 75 (ms)	P 95 (ms)
Chrome	Browserify	Home	uiStartup	1224	1103	1377	64	1271	1337
			load	1056	950	1219	61	1087	1172
			domContentLoaded	1050	928	1211	61	1083	1166
			domInteractive	18	13	50	7	17	38
			firstPaint	680	152	1242	425	1077	1165
			backgroundConnect	249	236	337	11	252	262
			firstReactRender	24	17	113	10	24	36
			getState	10	5	30	5	11	22
			initialActions	4	0	24	4	4	12
			loadScripts	807	681	975	61	839	928
			setupStore	8	5	22	3	9	15
	Webpack	Home	uiStartup	810	703	1084	63	820	933
			load	623	579	932	66	628	775
			domContentLoaded	615	572	923	65	618	767
			domInteractive	16	11	57	10	14	48
			firstPaint	201	55	856	200	183	698
			backgroundConnect	20	11	48	6	23	30
			firstReactRender	26	17	62	8	31	34
			getState	7	3	15	3	9	11
			initialActions	2	0	8	2	3	6
			loadScripts	613	570	912	63	617	756
			setupStore	8	4	11	2	9	10
Firefox	Browserify	Home	uiStartup	1410	1207	1966	126	1464	1679
			load	1200	1046	1575	88	1255	1335
			domContentLoaded	1199	1046	1574	88	1254	1334
			domInteractive	101	34	356	56	101	223
			firstPaint	NaN	NaN	NaN	NaN	NaN	NaN
			backgroundConnect	30	20	80	11	33	61
			firstReactRender	30	25	81	7	32	43
			getState	6	3	42	7	5	18
			initialActions	2	0	24	4	2	8
			loadScripts	1177	1029	1553	86	1229	1314
			setupStore	11	4	132	17	7	50
	Webpack	Home	uiStartup	1535	1325	2055	139	1582	1863
			load	1329	1181	1624	92	1378	1526
			domContentLoaded	1329	1181	1624	92	1378	1526
			domInteractive	99	31	381	66	93	326
			firstPaint	NaN	NaN	NaN	NaN	NaN	NaN
			backgroundConnect	34	17	180	25	35	74
			firstReactRender	35	25	78	13	36	75
			getState	8	2	141	19	6	24
			initialActions	3	0	38	6	2	16
			loadScripts	1302	1164	1568	86	1350	1488
			setupStore	12	4	250	28	7	46

Bundle size diffs [🚨 Warning! Bundle size has increased!]

background: 720 Bytes (0.02%)
ui: 2.47 KiB (0.04%)
common: 1.22 KiB (0.01%)

ui/components/app/toast-master/toast-master.js

- updated the shield library

ui/components/app/toast-master/toast-master.js

metamaskbot · 2025-10-14T08:20:10Z

📊 Page Load Benchmark Results

Current Commit: 541d9fd | Date: 10/14/2025

📄 Localhost MetaMask Test Dapp

Samples: 100

Summary

pageLoadTime-> current mean value: 1.04s (±71ms) 🟡 | historical mean value: 1.05s ⬇️ (historical data)
domContentLoaded-> current mean value: 727ms (±68ms) 🟢 | historical mean value: 737ms ⬇️ (historical data)
firstContentfulPaint-> current mean value: 75ms (±11ms) 🟢 | historical mean value: 77ms ⬇️ (historical data)

📈 Detailed Results

Metric	Mean	Std Dev	Min	Max	P95	P99
pageLoadTime	1.04s	71ms	1.00s	1.32s	1.25s	1.32s
domContentLoaded	727ms	68ms	696ms	997ms	922ms	997ms
firstPaint	75ms	11ms	60ms	164ms	84ms	164ms
firstContentfulPaint	75ms	11ms	60ms	164ms	84ms	164ms
largestContentfulPaint	0ms	0ms	0ms	0ms	0ms	0ms

Results generated automatically by MetaMask CI

metamaskbot · 2025-10-14T08:20:24Z

Builds ready [541d9fd]

builds: chrome, firefox
builds (beta): chrome, firefox
builds (flask): chrome, firefox
builds (test): chrome, firefox
builds (test-flask): chrome, firefox
build viz: Build System
bundle size: Bundle Size Stats
user-actions-benchmark: User Actions Stats
storybook: Storybook
typescript migration: Dashboard
all artifacts
bundle viz:
- background: 0, 1, 2, 3, 4, 5, 6, 7, 8
- common: 0, 1, 2, 3, 4, 5, 6, 7, 8, 9, 10, 11, 12, 13
- ui: 0, 1, 2, 3, 4, 5, 6, 7, 8, 9, 10, 11, 12, 13, 14
- content-script: 0
- offscreen: 0

UI Startup Metrics (1248 ± 68 ms)

Platform	BuildType	Page	Metric	Mean (ms)	Min (ms)	Max (ms)	Std Dev (ms)	P 75 (ms)	P 95 (ms)
Chrome	Browserify	Home	uiStartup	1248	1108	1413	68	1303	1393
			load	1078	967	1234	61	1117	1184
			domContentLoaded	1071	962	1228	60	1113	1179
			domInteractive	19	13	131	13	17	37
			firstPaint	685	122	1242	437	1096	1174
			backgroundConnect	253	241	276	7	257	268
			firstReactRender	27	19	49	7	31	44
			getState	13	5	40	8	15	32
			initialActions	5	0	63	8	7	16
			loadScripts	824	717	980	59	865	931
			setupStore	9	5	32	4	10	18
	Webpack	Home	uiStartup	841	715	1050	72	864	997
			load	657	590	891	75	695	832
			domContentLoaded	649	584	885	75	667	823
			domInteractive	16	11	42	8	14	38
			firstPaint	198	57	827	194	198	672
			backgroundConnect	20	11	43	7	24	33
			firstReactRender	25	17	62	9	32	35
			getState	7	3	19	3	9	13
			initialActions	2	0	18	3	3	7
			loadScripts	647	582	874	73	665	812
			setupStore	8	4	13	2	9	11
Firefox	Browserify	Home	uiStartup	1487	1273	2276	158	1542	1808
			load	1257	1098	1483	87	1329	1408
			domContentLoaded	1257	1097	1483	87	1329	1407
			domInteractive	105	34	343	62	104	295
			firstPaint	NaN	NaN	NaN	NaN	NaN	NaN
			backgroundConnect	32	20	129	17	34	58
			firstReactRender	31	25	59	5	32	39
			getState	10	2	187	24	6	19
			initialActions	6	0	168	22	2	18
			loadScripts	1233	1082	1448	84	1303	1387
			setupStore	13	4	261	31	7	48
	Webpack	Home	uiStartup	1539	1361	2198	139	1578	1811
			load	1332	1185	1748	96	1377	1522
			domContentLoaded	1332	1185	1748	96	1377	1522
			domInteractive	100	30	385	74	98	340
			firstPaint	NaN	NaN	NaN	NaN	NaN	NaN
			backgroundConnect	30	17	92	13	35	55
			firstReactRender	36	26	84	14	37	78
			getState	10	3	193	26	6	34
			initialActions	3	0	43	6	2	17
			loadScripts	1309	1168	1672	93	1345	1495
			setupStore	11	3	124	18	7	55

Bundle size diffs [🚨 Warning! Bundle size has increased!]

background: 743 Bytes (0.02%)
ui: 2.1 KiB (0.03%)
common: 1.73 KiB (0.02%)

lionellbriones added 16 commits September 29, 2025 14:18

feat: added toast component

bbc58d2

Merge branch 'main' into feat/new-toast

62b7920

feat: fix toast snapshot

afd09f0

Merge branch 'main' into feat/new-toast

b9d5bfe

feat: updated current toast component

9ba7f3c

feat: remove new toast component

a1207dd

feat: update snapshot

228f418

feat: update survey toast snapshot

d8fd3e7

Merge branch 'main' into feat/new-toast

2de317c

feat: use base button on action button

664e94f

feat: use button secondary on action button

cd938b5

feat: update snapshot

494b4f8

feat: use dark toast for dark mode and same for light mode

a3731d9

feat: use iconSize.MD for close icon

961ff4b

- banner radius to 12px - button radius 8px and medium text

feat: updated snapshots

fde6dbd

feat: added toasts for shield subscription

3051074

metamaskbot added the team-web3auth Web3Auth team label Oct 9, 2025

github-actions bot added the size-M label Oct 9, 2025

Base automatically changed from feat/new-toast to main October 11, 2025 01:30

lionellbriones added 3 commits October 13, 2025 12:01

Merge branch 'main' into feat/shield-subscription-toasts

a80e5e3

feat: fixed failing e2e

bc9816f

Merge branch 'main' into feat/shield-subscription-toasts

a5dae8b

lionellbriones added 5 commits October 13, 2025 17:53

feat: add flag when to show toast again

fd021f7

feat: add flag when to show shield ending toast again

a68c703

feat: use lib to check paused subscription

d483729

feat: fix lint

9c62924

Merge branch 'main' into feat/shield-subscription-toasts

4e454fe

lionellbriones added 2 commits October 14, 2025 02:37

Merge branch 'main' into feat/shield-subscription-toasts

826a503

Merge branch 'main' into feat/shield-subscription-toasts

00568d5

lionellbriones marked this pull request as ready for review October 14, 2025 04:46

lionellbriones requested review from chaitanyapotti and tuna1207 October 14, 2025 04:46

This comment was marked as outdated.

Sign in to view

feat: redirects user to settings shield on action button

bd18b04

This comment was marked as outdated.

Sign in to view

feat: fix showing shield ending modal

d4bd7fb

tuna1207 requested changes Oct 14, 2025

View reviewed changes

ui/components/app/toast-master/toast-master.js Outdated Show resolved Hide resolved

feat: fix logic on showing shield ending toast

541d9fd

- updated the shield library

cursor bot reviewed Oct 14, 2025

View reviewed changes

ui/components/app/toast-master/toast-master.js Show resolved Hide resolved

tuna1207 approved these changes Oct 14, 2025

View reviewed changes

chaitanyapotti approved these changes Oct 14, 2025

View reviewed changes

chaitanyapotti added this pull request to the merge queue Oct 14, 2025

Merged via the queue into main with commit c402448 Oct 14, 2025
170 checks passed

chaitanyapotti deleted the feat/shield-subscription-toasts branch October 14, 2025 12:04

github-actions bot locked and limited conversation to collaborators Oct 14, 2025

metamaskbot added the release-13.6.0 Issue or pull request that will be included in release 13.6.0 label Oct 14, 2025

feat: shield subscription error state toasts #36718

feat: shield subscription error state toasts #36718

Conversation

lionellbriones commented Oct 9, 2025 • edited by cursor bot Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Description

Changelog

Related issues

Manual testing steps

Screenshots/Recordings

Before

After

Pre-merge author checklist

Pre-merge reviewer checklist

Uh oh!

github-actions bot commented Oct 9, 2025

Uh oh!

metamaskbot commented Oct 13, 2025

📊 Page Load Benchmark Results

📄 Localhost MetaMask Test Dapp

Summary

Uh oh!

metamaskbot commented Oct 13, 2025

Uh oh!

metamaskbot commented Oct 13, 2025

📊 Page Load Benchmark Results

📄 Localhost MetaMask Test Dapp

Summary

Uh oh!

metamaskbot commented Oct 13, 2025

Uh oh!

This comment was marked as outdated.

Uh oh!

metamaskbot commented Oct 14, 2025

📊 Page Load Benchmark Results

📄 Localhost MetaMask Test Dapp

Summary

Uh oh!

metamaskbot commented Oct 14, 2025

Uh oh!

This comment was marked as outdated.

Uh oh!

metamaskbot commented Oct 14, 2025

📊 Page Load Benchmark Results

📄 Localhost MetaMask Test Dapp

Summary

Uh oh!

metamaskbot commented Oct 14, 2025

Uh oh!

metamaskbot commented Oct 14, 2025

📊 Page Load Benchmark Results

📄 Localhost MetaMask Test Dapp

Summary

Uh oh!

metamaskbot commented Oct 14, 2025

Uh oh!

Uh oh!

Uh oh!

metamaskbot commented Oct 14, 2025

📊 Page Load Benchmark Results

📄 Localhost MetaMask Test Dapp

Summary

Uh oh!

metamaskbot commented Oct 14, 2025

Uh oh!

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

4 participants

lionellbriones commented Oct 9, 2025 •

edited by cursor bot

Loading