-
Notifications
You must be signed in to change notification settings - Fork 5.4k
refactor: migrate controllers to @metamask/messenger
#36721
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
base: main
Are you sure you want to change the base?
Conversation
190c1fe to
0a66e1a
Compare
|
Review the following changes in direct dependencies. Learn more about Socket for GitHub.
|
📊 Page Load Benchmark ResultsCurrent Commit: 📄 Localhost MetaMask Test DappSamples: 100 Summary
📈 Detailed Results
Results generated automatically by MetaMask CI |
Builds ready [7440b16]
Bundle size diffs [🚨 Warning! Bundle size has increased!]
|
|
Caution MetaMask internal reviewing guidelines:
|
✨ Files requiring CODEOWNER review ✨✅ @MetaMask/confirmations (11 files, +30 -22)
|
📊 Page Load Benchmark ResultsCurrent Commit: 📄 Localhost MetaMask Test DappSamples: 100 Summary
📈 Detailed Results
Results generated automatically by MetaMask CI |
Builds ready [a8e5611]
Bundle size diffs [🚀 Bundle size reduced!]
|
📊 Page Load Benchmark ResultsCurrent Commit: 📄 Localhost MetaMask Test DappSamples: 100 Summary
📈 Detailed Results
Results generated automatically by MetaMask CI |
Builds ready [21d0646]
Bundle size diffs [🚀 Bundle size reduced!]
|
e8ff207 to
7563aae
Compare
|
@metamaskbot update-policies |
|
Policies updated. 🧠 Learn how: https://lavamoat.github.io/guides/policy-diff/#what-to-look-for-when-reviewing-a-policy-diff |
📊 Page Load Benchmark ResultsCurrent Commit: 📄 Localhost MetaMask Test DappSamples: 100 Summary
📈 Detailed Results
Results generated automatically by MetaMask CI |
Builds ready [4009462]
UI Startup Metrics (1319 ± 74 ms)
Bundle size diffs [🚨 Warning! Bundle size has increased!]
|
📊 Page Load Benchmark ResultsCurrent Commit: 📄 Localhost MetaMask Test DappSamples: 100 Summary
📈 Detailed Results
Results generated automatically by MetaMask CI |
Builds ready [ddfbcd7]
UI Startup Metrics (1283 ± 82 ms)
Bundle size diffs [🚨 Warning! Bundle size has increased!]
|
📊 Page Load Benchmark ResultsCurrent Commit: 📄 Localhost MetaMask Test DappSamples: 100 Summary
📈 Detailed Results
Results generated automatically by MetaMask CI |
Builds ready [cd5f040]
UI Startup Metrics (1285 ± 82 ms)
Bundle size diffs [🚨 Warning! Bundle size has increased!]
|
|
@metamaskbot update-policies |
|
Policies updated. 🧠 Learn how: https://lavamoat.github.io/guides/policy-diff/#what-to-look-for-when-reviewing-a-policy-diff |
📊 Page Load Benchmark ResultsCurrent Commit: 📄 Localhost MetaMask Test DappSamples: 100 Summary
📈 Detailed Results
Results generated automatically by MetaMask CI |
Builds ready [0d1c328]
UI Startup Metrics (1330 ± 103 ms)
Bundle size diffs [🚨 Warning! Bundle size has increased!]
|
📊 Page Load Benchmark ResultsCurrent Commit: 📄 Localhost MetaMask Test DappSamples: 100 Summary
📈 Detailed Results
Results generated automatically by MetaMask CI |
Builds ready [1105374]
UI Startup Metrics (1211 ± 117 ms)
Bundle size diffs [🚨 Warning! Bundle size has increased!]
|
* origin/main: (46 commits) feat: refresh add/update rpc page (#36640) test: add e2e tests for swap and bridge SSE endpoint (#37037) refactor: migrated `ui/components/app/assets` to react-router-dom-v5-compat (#37157) feat(ramps): fixes btc buy button deeplink bug (#37146) fix: BTC activity is not shown on asset details (#37170) Merge origin/main into stable-sync fix: missing solana and bitcoin icon entries (#37065) fix: prevent phishing redirect when still on google.com (#37029) feat: added chain ID and display backend errors properly (#37174) fix: normalize basePath trailing slash in getRelativeLocationForNestedRoutes (#37161) fix: Use account group address in `SnapUIAvatar` when applicable (#37173) fix: Add `@metamask-previews/*` to NPM age gate exceptions (#37181) feat: enhance AppHeaderUnlockedContent with network address copy icon (#37112) feat: confirm screen fix styles (#37159) feat: Display dynamic gas station fee (#36961) chore: Bump Yarn to `4.10.3` and configure NPM age gate (#37119) fix: in redesigned send add filtering by chainId in address book contacts (#36941) fix: missing `await` on the onboarding flow (#37164) fix: fix manual refresh (#37130) release: Bump main version to 13.8.0 (#37167) ...
📊 Page Load Benchmark ResultsCurrent Commit: 📄 Localhost MetaMask Test DappSamples: 100 Summary
📈 Detailed Results
Results generated automatically by MetaMask CI |
Builds ready [da9e2db]
UI Startup Metrics (1266 ± 92 ms)
Bundle size diffs [🚨 Warning! Bundle size has increased!]
|
Description
WIP - migrating all extension controllers to new
@metamask/messengerpackage.Changelog
CHANGELOG entry:
Related issues
Fixes: #31843
Manual testing steps
Screenshots/Recordings
Before
After
Pre-merge author checklist
Pre-merge reviewer checklist