Fix bg broken #36729

davidmurdoch · 2025-10-09T17:15:02Z

Description

Changelog

CHANGELOG entry:

Related issues

Fixes:

Manual testing steps

Go to this page...

Screenshots/Recordings

Before

After

Pre-merge author checklist

I've followed MetaMask Contributor Docs and MetaMask Extension Coding Standards.
I've completed the PR template to the best of my ability
I’ve included tests if applicable
I’ve documented my code using JSDoc format if applicable
I’ve applied the right labels on the PR (see labeling guidelines). Not required for external contributors.

Pre-merge reviewer checklist

I've manually tested the PR (e.g. pull and build branch, run the app, test code being changed).
I confirm that this PR addresses all acceptance criteria described in the ticket it closes and includes the necessary testing evidence such as recordings and or screenshots.

github-actions · 2025-10-09T17:15:13Z

CLA Signature Action: All authors have signed the CLA. You may need to manually re-run the blocking PR check if it doesn't pass in a few minutes.

metamaskbot · 2025-10-10T19:39:41Z

📊 Page Load Benchmark Results

Current Commit: 3250836 | Date: 10/10/2025

📄 Localhost MetaMask Test Dapp

Samples: 100

Summary

pageLoadTime-> current mean value: 1.07s (±77ms) 🟡 | historical mean value: 1.05s ⬆️ (historical data)
domContentLoaded-> current mean value: 749ms (±74ms) 🟢 | historical mean value: 738ms ⬆️ (historical data)
firstContentfulPaint-> current mean value: 79ms (±14ms) 🟢 | historical mean value: 81ms ⬇️ (historical data)

📈 Detailed Results

Metric	Mean	Std Dev	Min	Max	P95	P99
pageLoadTime	1.07s	77ms	1.03s	1.41s	1.31s	1.41s
domContentLoaded	749ms	74ms	710ms	1.07s	974ms	1.07s
firstPaint	79ms	14ms	60ms	208ms	88ms	208ms
firstContentfulPaint	79ms	14ms	60ms	208ms	88ms	208ms
largestContentfulPaint	0ms	0ms	0ms	0ms	0ms	0ms

Results generated automatically by MetaMask CI

metamaskbot · 2025-10-10T19:39:56Z

Builds ready [3250836]

builds: chrome, firefox
builds (beta): chrome, firefox
builds (flask): chrome, firefox
builds (test): chrome, firefox
builds (test-flask): chrome, firefox
build viz: Build System
bundle size: Bundle Size Stats
user-actions-benchmark: User Actions Stats
storybook: Storybook
typescript migration: Dashboard
all artifacts
bundle viz:
- background: 0, 1, 2, 3, 4, 5, 6, 7, 8
- common: 0, 1, 2, 3, 4, 5, 6, 7, 8, 9, 10, 11, 12, 13
- ui: 0, 1, 2, 3, 4, 5, 6, 7, 8, 9, 10, 11, 12, 13, 14
- content-script: 0
- offscreen: 0

UI Startup Metrics (1246 ± 69 ms)

Platform	BuildType	Page	Metric	Mean (ms)	Min (ms)	Max (ms)	Std Dev (ms)	P 75 (ms)	P 95 (ms)
Chrome	Browserify	Home	uiStartup	1246	1119	1431	69	1293	1396
			load	1073	978	1247	61	1107	1186
			domContentLoaded	1067	973	1239	60	1100	1177
			domInteractive	19	13	115	12	17	41
			firstPaint	751	74	1250	433	1101	1188
			backgroundConnect	255	239	295	11	260	279
			firstReactRender	26	19	52	6	27	38
			getState	12	5	70	9	15	26
			initialActions	5	0	47	7	5	19
			loadScripts	818	728	1000	58	851	916
			setupStore	9	5	22	3	9	13
	Webpack	Home	uiStartup	836	712	1176	86	843	1091
			load	644	584	1023	89	644	927
			domContentLoaded	636	577	1019	88	638	915
			domInteractive	16	11	63	10	14	47
			firstPaint	192	55	1022	206	159	609
			backgroundConnect	22	10	44	6	25	33
			firstReactRender	27	17	63	8	32	35
			getState	8	4	14	2	9	12
			initialActions	2	0	10	2	3	6
			loadScripts	633	576	1008	85	636	903
			setupStore	8	4	18	2	10	12
Firefox	Browserify	Home	uiStartup	1392	1196	1909	146	1435	1744
			load	1189	1044	1617	89	1250	1331
			domContentLoaded	1188	1043	1616	89	1250	1330
			domInteractive	102	33	352	59	98	249
			firstPaint	NaN	NaN	NaN	NaN	NaN	NaN
			backgroundConnect	30	19	214	22	32	55
			firstReactRender	28	24	50	4	30	38
			getState	7	3	100	12	5	31
			initialActions	4	0	165	17	2	13
			loadScripts	1167	1027	1569	87	1228	1311
			setupStore	14	3	208	31	6	59
	Webpack	Home	uiStartup	1506	1319	1876	112	1535	1768
			load	1308	1160	1629	81	1353	1467
			domContentLoaded	1307	1159	1628	81	1353	1467
			domInteractive	90	31	347	40	98	146
			firstPaint	NaN	NaN	NaN	NaN	NaN	NaN
			backgroundConnect	32	18	143	25	32	117
			firstReactRender	33	25	81	10	35	53
			getState	7	2	88	12	5	19
			initialActions	4	0	147	15	2	11
			loadScripts	1283	1142	1521	72	1326	1418
			setupStore	11	4	55	13	7	45

Bundle size diffs [🚨 Warning! Bundle size has increased!]

background: -1.84 KiB (-0.04%)
ui: 7.04 KiB (0.11%)
common: 8.01 KiB (0.1%)

metamaskbot · 2025-10-10T20:34:56Z

📊 Page Load Benchmark Results

Current Commit: 4bbc060 | Date: 10/10/2025

📄 Localhost MetaMask Test Dapp

Samples: 100

Summary

pageLoadTime-> current mean value: 1.06s (±73ms) 🟡 | historical mean value: 1.05s ⬆️ (historical data)
domContentLoaded-> current mean value: 744ms (±70ms) 🟢 | historical mean value: 737ms ⬆️ (historical data)
firstContentfulPaint-> current mean value: 76ms (±11ms) 🟢 | historical mean value: 81ms ⬇️ (historical data)

📈 Detailed Results

Metric	Mean	Std Dev	Min	Max	P95	P99
pageLoadTime	1.06s	73ms	1.02s	1.34s	1.30s	1.34s
domContentLoaded	744ms	70ms	713ms	1.01s	966ms	1.01s
firstPaint	76ms	11ms	60ms	168ms	88ms	168ms
firstContentfulPaint	76ms	11ms	60ms	168ms	88ms	168ms
largestContentfulPaint	0ms	0ms	0ms	0ms	0ms	0ms

Results generated automatically by MetaMask CI

metamaskbot · 2025-10-10T20:35:06Z

Builds ready [4bbc060]

builds: chrome, firefox
builds (beta): chrome, firefox
builds (flask): chrome, firefox
builds (test): chrome, firefox
builds (test-flask): chrome, firefox
build viz: Build System
bundle size: Bundle Size Stats
user-actions-benchmark: User Actions Stats
storybook: Storybook
typescript migration: Dashboard
all artifacts
bundle viz:
- background: 0, 1, 2, 3, 4, 5, 6, 7, 8
- common: 0, 1, 2, 3, 4, 5, 6, 7, 8, 9, 10, 11, 12, 13
- ui: 0, 1, 2, 3, 4, 5, 6, 7, 8, 9, 10, 11, 12, 13, 14
- content-script: 0
- offscreen: 0

UI Startup Metrics (1230 ± 57 ms)

Platform	BuildType	Page	Metric	Mean (ms)	Min (ms)	Max (ms)	Std Dev (ms)	P 75 (ms)	P 95 (ms)
Chrome	Browserify	Home	uiStartup	1230	1108	1413	57	1265	1319
			load	1061	962	1175	51	1097	1148
			domContentLoaded	1054	955	1166	51	1089	1137
			domInteractive	18	14	41	6	17	35
			firstPaint	706	91	1156	420	1072	1133
			backgroundConnect	255	238	289	10	258	271
			firstReactRender	26	17	55	7	29	41
			getState	11	5	34	6	13	25
			initialActions	5	0	26	5	5	17
			loadScripts	806	713	910	50	840	891
			setupStore	10	6	27	4	11	19
	Webpack	Home	uiStartup	844	716	1189	81	861	1064
			load	646	589	978	73	648	782
			domContentLoaded	637	581	960	72	642	773
			domInteractive	16	11	47	8	14	36
			firstPaint	174	60	776	164	177	607
			backgroundConnect	23	10	42	7	27	34
			firstReactRender	28	17	68	9	33	42
			getState	8	3	15	3	10	12
			initialActions	2	0	8	2	3	5
			loadScripts	634	579	948	70	639	762
			setupStore	8	5	21	3	10	13
Firefox	Browserify	Home	uiStartup	1421	1247	1969	139	1468	1726
			load	1215	1084	1531	88	1285	1364
			domContentLoaded	1214	1084	1530	88	1285	1364
			domInteractive	98	34	285	50	105	231
			firstPaint	NaN	NaN	NaN	NaN	NaN	NaN
			backgroundConnect	31	19	104	13	35	60
			firstReactRender	30	25	53	5	31	39
			getState	8	2	131	17	5	15
			initialActions	3	0	64	8	2	17
			loadScripts	1191	1068	1457	83	1262	1339
			setupStore	12	4	196	27	7	57
	Webpack	Home	uiStartup	1530	1364	1925	121	1554	1858
			load	1334	1208	1680	91	1383	1516
			domContentLoaded	1334	1208	1680	91	1382	1516
			domInteractive	95	30	365	42	102	165
			firstPaint	NaN	NaN	NaN	NaN	NaN	NaN
			backgroundConnect	33	17	188	22	35	70
			firstReactRender	34	26	78	10	35	70
			getState	10	2	201	25	6	50
			initialActions	3	0	23	4	2	12
			loadScripts	1307	1190	1659	84	1355	1486
			setupStore	9	4	53	9	7	31

Bundle size diffs [🚨 Warning! Bundle size has increased!]

background: 1.28 KiB (0.03%)
ui: 7 Bytes (0%)
common: 5 Bytes (0%)

davidmurdoch added 4 commits October 8, 2025 17:35

wip

b6e994c

clean up

bb7214d

for later

19cb484

Merge branch 'main' into fix-bg-broken

e2c8c1f

metamaskbot added the team-extension-platform Extension Platform team label Oct 9, 2025

github-actions bot added the size-M label Oct 9, 2025

davidmurdoch and others added 5 commits October 9, 2025 13:27

this one

520d8fb

fix comment

3c49ee5

WIP

b99b431

wip

d775c18

WIP

3250836

davidmurdoch and others added 3 commits October 10, 2025 15:45

lint

f13e217

Merge branch 'main' into fix-bg-broken

876bbc9

handle lazy port

4bbc060

davidmurdoch and others added 6 commits October 14, 2025 19:27

WIP

76317ae

WIP

d397cb0

wip

a530c08

lint

ddebc12

wip

78c9dfe

wip

5c306f5

github-actions bot added size-L and removed size-M labels Oct 16, 2025

davidmurdoch added 3 commits October 16, 2025 18:46

Merge branch 'main' into fix-bg-broken

e12fdb4

wip

5fa3ccb

update and add tests

cb7eb47

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

Uh oh!

Fix bg broken #36729

Fix bg broken #36729

Uh oh!

davidmurdoch commented Oct 9, 2025 •

edited by github-actions bot

Loading

Uh oh!

github-actions bot commented Oct 9, 2025

Uh oh!

metamaskbot commented Oct 10, 2025

Uh oh!

metamaskbot commented Oct 10, 2025

Uh oh!

metamaskbot commented Oct 10, 2025

Uh oh!

metamaskbot commented Oct 10, 2025

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

2 participants

Fix bg broken #36729

Are you sure you want to change the base?

Fix bg broken #36729

Uh oh!

Conversation

davidmurdoch commented Oct 9, 2025 • edited by github-actions bot Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Description

Changelog

Related issues

Manual testing steps

Screenshots/Recordings

Before

After

Pre-merge author checklist

Pre-merge reviewer checklist

Uh oh!

github-actions bot commented Oct 9, 2025

Uh oh!

metamaskbot commented Oct 10, 2025

📊 Page Load Benchmark Results

📄 Localhost MetaMask Test Dapp

Summary

Uh oh!

metamaskbot commented Oct 10, 2025

Uh oh!

metamaskbot commented Oct 10, 2025

📊 Page Load Benchmark Results

📄 Localhost MetaMask Test Dapp

Summary

Uh oh!

metamaskbot commented Oct 10, 2025

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

2 participants

davidmurdoch commented Oct 9, 2025 •

edited by github-actions bot

Loading