-
Notifications
You must be signed in to change notification settings - Fork 5.4k
chore: Set BIP-44 stage 2 as default #36737
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
|
CLA Signature Action: All authors have signed the CLA. You may need to manually re-run the blocking PR check if it doesn't pass in a few minutes. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Bug: `withFixtures` Missing `dapp` Parameter Causes Issues
The dapp parameter in withFixtures no longer defaults to true. If dapp isn't explicitly passed, it now becomes undefined, which could lead to unexpected behavior in consuming code expecting a boolean value.
test/e2e/tests/multichain-accounts/common.ts#L62-L63
metamask-extension/test/e2e/tests/multichain-accounts/common.ts
Lines 62 to 63 in e9aaebc
| testSpecificMock, | |
| title, |
✨ Files requiring CODEOWNER review ✨🔑 @MetaMask/accounts-engineers (1 files, +0 -1)
|
📊 Page Load Benchmark ResultsCurrent Commit: 📄 Localhost MetaMask Test DappSamples: 100 Summary
📈 Detailed Results
Results generated automatically by MetaMask CI |
Builds ready [e9aaebc]
UI Startup Metrics (1226 ± 75 ms)
|
Description
Changelog
CHANGELOG entry:
Related issues
Fixes:
Manual testing steps
Screenshots/Recordings
Before
After
Pre-merge author checklist
Pre-merge reviewer checklist
Note
Increase delays in Sentry error e2e tests and remove hardcoded dapp flag in multichain accounts test helper.
test/e2e/tests/metrics/errors.spec.ts): Increase pre-error delay from2000msto3000msin background/UI state capture tests to improve stability.test/e2e/tests/multichain-accounts/common.ts): Remove hardcodeddapp: trueinwithFixturesto honor provideddapp/dappPathsoptions.Written by Cursor Bugbot for commit e9aaebc. This will update automatically on new commits. Configure here.