Skip to content

Conversation

@davibroc
Copy link
Contributor

@davibroc davibroc commented Oct 10, 2025

Description

Open in GitHub Codespaces

Changelog

CHANGELOG entry:

Related issues

Fixes:

Manual testing steps

  1. Go to this page...

Screenshots/Recordings

Before

After

Pre-merge author checklist

Pre-merge reviewer checklist

  • I've manually tested the PR (e.g. pull and build branch, run the app, test code being changed).
  • I confirm that this PR addresses all acceptance criteria described in the ticket it closes and includes the necessary testing evidence such as recordings and or screenshots.

Note

Increase delays in Sentry error e2e tests and remove hardcoded dapp flag in multichain accounts test helper.

  • Tests:
    • Sentry errors e2e (test/e2e/tests/metrics/errors.spec.ts): Increase pre-error delay from 2000ms to 3000ms in background/UI state capture tests to improve stability.
    • Multichain accounts helper (test/e2e/tests/multichain-accounts/common.ts): Remove hardcoded dapp: true in withFixtures to honor provided dapp/dappPaths options.

Written by Cursor Bugbot for commit e9aaebc. This will update automatically on new commits. Configure here.

@davibroc davibroc requested a review from a team as a code owner October 10, 2025 00:21
@github-actions
Copy link
Contributor

CLA Signature Action: All authors have signed the CLA. You may need to manually re-run the blocking PR check if it doesn't pass in a few minutes.

@metamaskbot metamaskbot added the team-qa QA team label Oct 10, 2025
Copy link

@cursor cursor bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Bug: `withFixtures` Missing `dapp` Parameter Causes Issues

The dapp parameter in withFixtures no longer defaults to true. If dapp isn't explicitly passed, it now becomes undefined, which could lead to unexpected behavior in consuming code expecting a boolean value.

test/e2e/tests/multichain-accounts/common.ts#L62-L63

Fix in Cursor Fix in Web


@metamaskbot
Copy link
Collaborator

✨ Files requiring CODEOWNER review ✨

🔑 @MetaMask/accounts-engineers (1 files, +0 -1)
  • 📁 test/
    • 📁 e2e/
      • 📁 tests/
        • 📁 multichain-accounts/
          • 📄 common.ts +0 -1

@davibroc davibroc changed the base branch from gar/chore/set-bip44-default to main October 10, 2025 00:29
@davibroc davibroc requested review from a team as code owners October 10, 2025 00:29
@davibroc davibroc added the no-changelog no-changelog Indicates no external facing user changes, therefore no changelog documentation needed label Oct 10, 2025
@metamaskbot
Copy link
Collaborator

📊 Page Load Benchmark Results

Current Commit: e9aaebc | Date: 10/10/2025

📄 Localhost MetaMask Test Dapp

Samples: 100

Summary

  • pageLoadTime-> current mean value: 1.08s (±117ms) 🟡 | historical mean value: 1.04s ⬆️ (historical data)
  • domContentLoaded-> current mean value: 757ms (±114ms) 🟢 | historical mean value: 732ms ⬆️ (historical data)
  • firstContentfulPaint-> current mean value: 85ms (±72ms) 🟢 | historical mean value: 78ms ⬆️ (historical data)
📈 Detailed Results
Metric Mean Std Dev Min Max P95 P99
pageLoadTime 1.08s 117ms 1.02s 1.96s 1.32s 1.96s
domContentLoaded 757ms 114ms 706ms 1.62s 1.00s 1.62s
firstPaint 85ms 72ms 68ms 800ms 84ms 800ms
firstContentfulPaint 85ms 72ms 68ms 800ms 84ms 800ms
largestContentfulPaint 0ms 0ms 0ms 0ms 0ms 0ms

Results generated automatically by MetaMask CI

@metamaskbot
Copy link
Collaborator

Builds ready [e9aaebc]
UI Startup Metrics (1226 ± 75 ms)
PlatformBuildTypePageMetricMean (ms)Min (ms)Max (ms)Std Dev (ms)P 75 (ms)P 95 (ms)
ChromeBrowserifyHomeuiStartup1226108414197512781363
load106594712276711191187
domContentLoaded105994312166711101181
domInteractive2013128191640
firstPaint65785122742910701151
backgroundConnect2492372797253263
firstReactRender25165682944
getState1153661326
initialActions6011213525
loadScripts81570097166868931
setupStore953241117
WebpackHomeuiStartup18061549221116519192137
load15011359176010615651728
domContentLoaded14871349174310315531720
domInteractive1911203251452
firstPaint3085817574741951647
backgroundConnect321472123758
firstReactRender4419167215169
getState134122151220
initialActions4014615319
loadScripts14831341174110215491715
setupStore134150181229
FirefoxBrowserifyHomeuiStartup13641182183313014261650
load1177103114949612471356
domContentLoaded1177103114949612461356
domInteractive101323866498252
firstPaintNaNNaNNaNNaNNaNNaN
backgroundConnect281895113246
firstReactRender28246252932
getState63436518
initialActions30456213
loadScripts1156101214799412291336
setupStore9310213632
WebpackHomeuiStartup15151326204913215401812
load1325117316979913701551
domContentLoaded1325117316979913701550
domInteractive1013046470102280
firstPaintNaNNaNNaNNaNNaNNaN
backgroundConnect3017108153350
firstReactRender332579113468
getState72449641
initialActions4013414216
loadScripts1301115616789413391506
setupStore1238616756

@davibroc davibroc changed the title fix: Sentry e2e tests and lint chose: Set BIP-44 stage 2 as default Oct 10, 2025
@davibroc davibroc changed the title chose: Set BIP-44 stage 2 as default chore: Set BIP-44 stage 2 as default Oct 10, 2025
@davibroc davibroc changed the base branch from main to gar/chore/set-bip44-default October 10, 2025 07:26
@davibroc davibroc closed this Oct 22, 2025
@github-actions github-actions bot locked and limited conversation to collaborators Oct 22, 2025
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.

Labels

no-changelog no-changelog Indicates no external facing user changes, therefore no changelog documentation needed size-XS team-qa QA team

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants