-
Notifications
You must be signed in to change notification settings - Fork 5.4k
feat: Implement BTC labels in send flow #36761
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
✨ Files requiring CODEOWNER review ✨✅ @MetaMask/confirmations (12 files, +130 -8)
|
📊 Page Load Benchmark ResultsCurrent Commit: 📄 Localhost MetaMask Test DappSamples: 100 Summary
📈 Detailed Results
Results generated automatically by MetaMask CI |
Builds ready [d09e2de]
UI Startup Metrics (1236 ± 72 ms)
Bundle size diffs [🚨 Warning! Bundle size has increased!]
|
pedronfigueiredo
approved these changes
Oct 16, 2025
vinistevam
approved these changes
Oct 17, 2025
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Labels
no-changelog
no-changelog Indicates no external facing user changes, therefore no changelog documentation needed
release-13.7.0
Issue or pull request that will be included in release 13.7.0
size-M
team-confirmations
Push issues to confirmations team
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
This PR aims to add BTC labels to the send flow asset and accounts.
Changelog
CHANGELOG entry: null
Related issues
Fixes: https://github.com/MetaMask/MetaMask-planning/issues/5965
Manual testing steps
Screenshots/Recordings
Before
After
Pre-merge author checklist
Pre-merge reviewer checklist
Note
Adds Bitcoin account type labels (Legacy, Nested SegWit, Native SegWit, Taproot) to asset and recipient UI, with supporting types, hooks, and tests.
UI/asset/asset.tsxand next to address inUI/recipient/recipient.tsxviaAccountTypeLabel.UI/account-type-label/account-type-label.tsxwith tests.constants/network.ts:accountTypeLabelmap forKeyringAccountType(BTC variants).types/send.ts:Assetnow includesaccountType.hooks/send/useRecipients.ts:Recipientnow includesaccountType.hooks/send/useAccountRecipients.ts: passes throughaccount.typeto recipients.asset.test.tsx,recipient.test.tsx,useAccountRecipients.test.tsfor label rendering and BTC account types.Written by Cursor Bugbot for commit d09e2de. This will update automatically on new commits. Configure here.