Skip to content

Conversation

@GuillaumeRx
Copy link
Contributor

@GuillaumeRx GuillaumeRx commented Oct 10, 2025

Description

This PR bumps the @metamask/ens-resolver-snap to 1.0.0.

This major bump refactors the snap and adds the possibility to resolve on non-evm networks.

Open in GitHub Codespaces

Changelog

CHANGELOG entry: null

Related issues

Fixes:

Manual testing steps

  1. Go to the send flow
  2. Try various ENS names

Screenshots/Recordings

Before

After

2025-10-10.15-44-13.mp4

Pre-merge author checklist

Pre-merge reviewer checklist

  • I've manually tested the PR (e.g. pull and build branch, run the app, test code being changed).
  • I confirm that this PR addresses all acceptance criteria described in the ticket it closes and includes the necessary testing evidence such as recordings and or screenshots.

Note

Cursor Bugbot is generating a summary for commit 971d59c. Configure here.

@github-actions
Copy link
Contributor

CLA Signature Action: All authors have signed the CLA. You may need to manually re-run the blocking PR check if it doesn't pass in a few minutes.

@metamaskbot metamaskbot added the team-core-platform Core Platform team label Oct 10, 2025
@socket-security
Copy link

Review the following changes in direct dependencies. Learn more about Socket for GitHub.

Diff Package Supply Chain
Security
Vulnerability Quality Maintenance License
Updated@​metamask/​ens-resolver-snap@​0.1.4 ⏵ 1.0.099 +510067 -190 -1100

View full report

@metamaskbot
Copy link
Collaborator

📊 Page Load Benchmark Results

Current Commit: 971d59c | Date: 10/10/2025

📄 Localhost MetaMask Test Dapp

Samples: 100

Summary

  • pageLoadTime-> current mean value: 1.05s (±70ms) 🟡 | historical mean value: 1.05s ⬇️ (historical data)
  • domContentLoaded-> current mean value: 734ms (±67ms) 🟢 | historical mean value: 736ms ⬇️ (historical data)
  • firstContentfulPaint-> current mean value: 75ms (±13ms) 🟢 | historical mean value: 82ms ⬇️ (historical data)
📈 Detailed Results
Metric Mean Std Dev Min Max P95 P99
pageLoadTime 1.05s 70ms 1.01s 1.31s 1.26s 1.31s
domContentLoaded 734ms 67ms 699ms 994ms 943ms 994ms
firstPaint 75ms 13ms 56ms 184ms 84ms 184ms
firstContentfulPaint 75ms 13ms 56ms 184ms 84ms 184ms
largestContentfulPaint 0ms 0ms 0ms 0ms 0ms 0ms

Results generated automatically by MetaMask CI

@metamaskbot
Copy link
Collaborator

Builds ready [971d59c]
UI Startup Metrics (1261 ± 73 ms)
PlatformBuildTypePageMetricMean (ms)Min (ms)Max (ms)Std Dev (ms)P 75 (ms)P 95 (ms)
ChromeBrowserifyHomeuiStartup1261111714197313131392
load108898012386411321209
domContentLoaded108197412296411221203
domInteractive18144661837
firstPaint76386123043111051208
backgroundConnect2572432909261276
firstReactRender27205282946
getState1353371527
initialActions60407723
loadScripts83172497763875958
setupStore1062431018
WebpackHomeuiStartup813691103071819964
load63257488572639804
domContentLoaded62556987671630797
domInteractive15115381336
firstPaint19253888181197591
backgroundConnect21114172534
firstReactRender26176393135
getState831931014
initialActions2015236
loadScripts62256786369627787
setupStore74112810
FirefoxBrowserifyHomeuiStartup1344118116358213871509
load1159103213376712061276
domContentLoaded1158103213376712061275
domInteractive943524436104192
firstPaintNaNNaNNaNNaNNaNNaN
backgroundConnect2819122133046
firstReactRender28235553039
getState63637515
initialActions4018218213
loadScripts1138101513206511881249
setupStore6434469
WebpackHomeuiStartup15891400220914916251913
load13781219178110714361613
domContentLoaded13781219178110714351612
domInteractive1033240164105244
firstPaintNaNNaNNaNNaNNaNNaN
backgroundConnect3319111163676
firstReactRender362781113777
getState8310212528
initialActions5012014226
loadScripts13521202175710414041595
setupStore1046514747
Bundle size diffs [🚨 Warning! Bundle size has increased!]
  • background: 58 Bytes (0%)
  • ui: 0 Bytes (0%)
  • common: 10 Bytes (0%)

@GuillaumeRx GuillaumeRx added this pull request to the merge queue Oct 13, 2025
Merged via the queue into main with commit 49cc847 Oct 13, 2025
184 of 185 checks passed
@GuillaumeRx GuillaumeRx deleted the gr/bump-ens-resolver-snap-v1 branch October 13, 2025 09:33
@github-actions github-actions bot locked and limited conversation to collaborators Oct 13, 2025
@metamaskbot metamaskbot added the release-13.6.0 Issue or pull request that will be included in release 13.6.0 label Oct 13, 2025
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.

Labels

release-13.6.0 Issue or pull request that will be included in release 13.6.0 size-XS team-core-platform Core Platform team

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants