fix: bump `@metamask/account-tree-controller` to `v1.4.2` cp-13.5.0 #36778

mathieuartu · 2025-10-10T14:16:17Z

Description

This PR bumps @metamask/account-tree-controller to ^1.4.2 which contains a fix for the backup and sync related sev1 bug linked below.

Changelog

CHANGELOG entry: null

Related issues

Fixes: #36766

Manual testing steps

No manual testing steps

Screenshots/Recordings

Before

After

Pre-merge author checklist

I've followed MetaMask Contributor Docs and MetaMask Extension Coding Standards.
I've completed the PR template to the best of my ability
I’ve included tests if applicable
I’ve documented my code using JSDoc format if applicable
I’ve applied the right labels on the PR (see labeling guidelines). Not required for external contributors.

Pre-merge reviewer checklist

I've manually tested the PR (e.g. pull and build branch, run the app, test code being changed).
I confirm that this PR addresses all acceptance criteria described in the ticket it closes and includes the necessary testing evidence such as recordings and or screenshots.

Note

Updates @metamask/account-tree-controller from ^1.4.0 to ^1.4.2 and refreshes the lockfile.

Dependencies:
- Upgrade @metamask/account-tree-controller to ^1.4.2 in package.json.
- Refresh yarn.lock to reflect the new version.

^{Written by Cursor Bugbot for commit 8173e2e. This will update automatically on new commits. Configure here.}

github-actions · 2025-10-10T14:16:27Z

CLA Signature Action: All authors have signed the CLA. You may need to manually re-run the blocking PR check if it doesn't pass in a few minutes.

socket-security · 2025-10-10T14:19:33Z

Review the following changes in direct dependencies. Learn more about Socket for GitHub.

Diff	Package	Supply Chain Security	Vulnerability	Quality	Maintenance	License
	@metamask/account-tree-controller@1.4.0 ⏵ 1.4.2			⁺¹	⁺¹

View full report

mathieuartu · 2025-10-10T14:39:33Z

@metamaskbot update-policies

mathieuartu · 2025-10-10T15:39:32Z

@metamaskbot update-policies

metamaskbot · 2025-10-10T15:55:38Z

Policies updated.
👀 Please review the diff for suspicious new powers.

🧠 Learn how: https://lavamoat.github.io/guides/policy-diff/#what-to-look-for-when-reviewing-a-policy-diff

metamaskbot · 2025-10-10T16:22:03Z

📊 Page Load Benchmark Results

Current Commit: 55af4b5 | Date: 10/10/2025

📄 Localhost MetaMask Test Dapp

Samples: 100

Summary

pageLoadTime-> current mean value: 1.05s (±74ms) 🟡 | historical mean value: 1.05s ⬆️ (historical data)
domContentLoaded-> current mean value: 737ms (±71ms) 🟢 | historical mean value: 737ms ⬆️ (historical data)
firstContentfulPaint-> current mean value: 77ms (±10ms) 🟢 | historical mean value: 80ms ⬇️ (historical data)

📈 Detailed Results

Metric	Mean	Std Dev	Min	Max	P95	P99
pageLoadTime	1.05s	74ms	1.01s	1.35s	1.31s	1.35s
domContentLoaded	737ms	71ms	703ms	1.01s	987ms	1.01s
firstPaint	77ms	10ms	60ms	156ms	88ms	156ms
firstContentfulPaint	77ms	10ms	60ms	156ms	88ms	156ms
largestContentfulPaint	0ms	0ms	0ms	0ms	0ms	0ms

Results generated automatically by MetaMask CI

metamaskbot · 2025-10-10T16:22:12Z

Builds ready [55af4b5]

builds: chrome, firefox
builds (beta): chrome, firefox
builds (flask): chrome, firefox
builds (test): chrome, firefox
builds (test-flask): chrome, firefox
build viz: Build System
bundle size: Bundle Size Stats
user-actions-benchmark: User Actions Stats
storybook: Storybook
typescript migration: Dashboard
all artifacts
bundle viz:
- background: 0, 1, 2, 3, 4, 5, 6, 7, 8
- common: 0, 1, 2, 3, 4, 5, 6, 7, 8, 9, 10, 11, 12, 13
- ui: 0, 1, 2, 3, 4, 5, 6, 7, 8, 9, 10, 11, 12, 13, 14
- content-script: 0
- offscreen: 0

UI Startup Metrics (1322 ± 69 ms)

Platform	BuildType	Page	Metric	Mean (ms)	Min (ms)	Max (ms)	Std Dev (ms)	P 75 (ms)	P 95 (ms)
Chrome	Browserify	Home	uiStartup	1322	1159	1541	69	1368	1447
			load	1131	992	1319	67	1172	1259
			domContentLoaded	1122	974	1314	69	1166	1253
			domInteractive	19	14	89	9	19	34
			firstPaint	722	90	1320	458	1155	1225
			backgroundConnect	273	249	393	19	276	288
			firstReactRender	30	18	138	14	33	53
			getState	13	5	48	8	15	27
			initialActions	4	0	26	5	5	15
			loadScripts	858	712	1042	67	906	984
			setupStore	11	6	30	5	11	26
	Webpack	Home	uiStartup	821	703	1086	69	838	977
			load	638	580	936	70	648	777
			domContentLoaded	630	575	917	69	641	773
			domInteractive	15	11	50	8	14	36
			firstPaint	207	53	956	219	193	752
			backgroundConnect	21	11	45	7	26	34
			firstReactRender	26	16	59	8	31	33
			getState	8	4	22	3	10	12
			initialActions	2	0	17	2	3	6
			loadScripts	627	573	904	67	639	771
			setupStore	8	4	17	2	9	11
Firefox	Browserify	Home	uiStartup	1445	1253	1745	121	1518	1692
			load	1239	1083	1530	93	1319	1371
			domContentLoaded	1239	1083	1530	93	1319	1371
			domInteractive	105	32	311	57	111	245
			firstPaint	NaN	NaN	NaN	NaN	NaN	NaN
			backgroundConnect	30	21	97	11	33	49
			firstReactRender	29	26	40	3	30	35
			getState	7	3	65	8	6	16
			initialActions	4	0	95	11	2	22
			loadScripts	1217	1063	1507	91	1291	1349
			setupStore	10	4	142	17	7	45
	Webpack	Home	uiStartup	1520	1351	2074	106	1555	1756
			load	1324	1188	1766	81	1353	1470
			domContentLoaded	1323	1187	1765	81	1352	1470
			domInteractive	94	30	372	57	99	203
			firstPaint	NaN	NaN	NaN	NaN	NaN	NaN
			backgroundConnect	31	17	118	16	34	51
			firstReactRender	34	27	81	11	36	74
			getState	6	3	45	6	5	15
			initialActions	4	0	55	9	2	18
			loadScripts	1299	1172	1680	77	1335	1451
			setupStore	10	4	66	12	7	46

Bundle size diffs [🚨 Warning! Bundle size has increased!]

background: 102 Bytes (0%)
ui: 1.48 KiB (0.02%)
common: 10 KiB (0.12%)

mathieuartu · 2025-10-13T07:40:12Z

@metamaskbot update-policies

metamaskbot · 2025-10-13T07:56:21Z

Policies updated.
👀 Please review the diff for suspicious new powers.

🧠 Learn how: https://lavamoat.github.io/guides/policy-diff/#what-to-look-for-when-reviewing-a-policy-diff

metamaskbot · 2025-10-13T08:22:51Z

📊 Page Load Benchmark Results

Current Commit: 8173e2e | Date: 10/13/2025

📄 Localhost MetaMask Test Dapp

Samples: 100

Summary

pageLoadTime-> current mean value: 1.02s (±76ms) 🟡 | historical mean value: 1.05s ⬇️ (historical data)
domContentLoaded-> current mean value: 711ms (±88ms) 🟢 | historical mean value: 737ms ⬇️ (historical data)
firstContentfulPaint-> current mean value: 80ms (±40ms) 🟢 | historical mean value: 80ms ⬆️ (historical data)

📈 Detailed Results

Metric	Mean	Std Dev	Min	Max	P95	P99
pageLoadTime	1.02s	76ms	977ms	1.33s	1.27s	1.33s
domContentLoaded	711ms	88ms	675ms	1.28s	935ms	1.28s
firstPaint	80ms	40ms	60ms	476ms	88ms	476ms
firstContentfulPaint	80ms	40ms	60ms	476ms	88ms	476ms
largestContentfulPaint	0ms	0ms	0ms	0ms	0ms	0ms

Results generated automatically by MetaMask CI

metamaskbot · 2025-10-13T08:22:55Z

Builds ready [8173e2e]

builds: chrome, firefox
builds (beta): chrome, firefox
builds (flask): chrome, firefox
builds (test): chrome, firefox
builds (test-flask): chrome, firefox
build viz: Build System
bundle size: Bundle Size Stats
user-actions-benchmark: User Actions Stats
storybook: Storybook
typescript migration: Dashboard
all artifacts
bundle viz:
- background: 0, 1, 2, 3, 4, 5, 6, 7, 8
- common: 0, 1, 2, 3, 4, 5, 6, 7, 8, 9, 10, 11, 12, 13
- ui: 0, 1, 2, 3, 4, 5, 6, 7, 8, 9, 10, 11, 12, 13, 14
- content-script: 0
- offscreen: 0

UI Startup Metrics (1319 ± 64 ms)

Platform	BuildType	Page	Metric	Mean (ms)	Min (ms)	Max (ms)	Std Dev (ms)	P 75 (ms)	P 95 (ms)
Chrome	Browserify	Home	uiStartup	1319	1201	1512	64	1358	1426
			load	1127	1025	1257	56	1162	1229
			domContentLoaded	1121	1019	1247	55	1154	1223
			domInteractive	18	15	38	4	18	28
			firstPaint	741	98	1256	452	1142	1218
			backgroundConnect	267	254	305	8	272	282
			firstReactRender	31	18	201	21	32	51
			getState	14	5	45	8	17	34
			initialActions	4	0	24	4	5	13
			loadScripts	859	769	980	55	891	958
			setupStore	10	7	37	5	11	25
	Webpack	Home	uiStartup	867	732	1169	85	888	1107
			load	676	602	974	87	684	925
			domContentLoaded	667	594	967	88	677	919
			domInteractive	17	12	74	11	15	45
			firstPaint	199	59	952	188	201	667
			backgroundConnect	22	12	42	6	27	31
			firstReactRender	26	17	40	8	34	36
			getState	9	4	27	4	11	18
			initialActions	2	0	11	2	3	6
			loadScripts	664	592	965	86	674	917
			setupStore	8	5	15	2	10	12
Firefox	Browserify	Home	uiStartup	1388	1195	1929	132	1454	1627
			load	1187	1036	1373	83	1258	1343
			domContentLoaded	1187	1036	1373	83	1258	1343
			domInteractive	97	33	284	52	100	242
			firstPaint	NaN	NaN	NaN	NaN	NaN	NaN
			backgroundConnect	27	18	69	7	31	36
			firstReactRender	29	25	48	4	30	34
			getState	9	3	254	27	5	16
			initialActions	7	0	211	28	2	18
			loadScripts	1166	1022	1344	82	1241	1320
			setupStore	12	4	232	28	7	48
	Webpack	Home	uiStartup	1542	1348	2184	116	1573	1760
			load	1343	1203	1708	80	1388	1478
			domContentLoaded	1342	1203	1708	80	1388	1477
			domInteractive	93	30	340	46	98	154
			firstPaint	NaN	NaN	NaN	NaN	NaN	NaN
			backgroundConnect	31	19	79	13	34	69
			firstReactRender	35	26	77	12	35	73
			getState	6	2	58	8	5	15
			initialActions	5	0	126	15	2	13
			loadScripts	1318	1186	1639	78	1366	1461
			setupStore	10	4	82	12	7	40

Bundle size diffs [🚨 Warning! Bundle size has increased!]

background: 58 Bytes (0%)
ui: 0 Bytes (0%)
common: 128 Bytes (0%)

fix: bump @metamask/account-tree-controller to v1.4.2

dac7a00

mathieuartu self-assigned this Oct 10, 2025

mathieuartu added the team-accounts-framework Accounts Framework team label Oct 10, 2025

github-actions bot added the size-XS label Oct 10, 2025

mathieuartu marked this pull request as ready for review October 10, 2025 14:19

Update LavaMoat policies

55af4b5

metamaskbot requested review from a team as code owners October 10, 2025 15:55

mathieuartu added 2 commits October 10, 2025 22:23

fix: yarn dedupe

b39379e

Merge branch 'main' into chore/bump-account-tree-controller-1.4.2

fb1d329

Update LavaMoat policies

8173e2e

mathieuartu changed the title ~~fix: bump @metamask/account-tree-controller to v1.4.2~~ fix: bump @metamask/account-tree-controller to v1.4.2 cp-13.5.0 Oct 13, 2025

fabiobozzo approved these changes Oct 13, 2025

View reviewed changes

mathieuartu enabled auto-merge October 13, 2025 10:16

ccharly approved these changes Oct 13, 2025

View reviewed changes

mathieuartu added this pull request to the merge queue Oct 13, 2025

Merged via the queue into main with commit 32d8ce0 Oct 13, 2025
173 checks passed

mathieuartu deleted the chore/bump-account-tree-controller-1.4.2 branch October 13, 2025 10:43

github-actions bot locked and limited conversation to collaborators Oct 13, 2025

metamaskbot added the release-13.6.0 Issue or pull request that will be included in release 13.6.0 label Oct 13, 2025

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

Uh oh!

fix: bump `@metamask/account-tree-controller` to `v1.4.2` cp-13.5.0 #36778

fix: bump `@metamask/account-tree-controller` to `v1.4.2` cp-13.5.0 #36778

mathieuartu commented Oct 10, 2025 •

edited by cursor bot

Loading

Uh oh!

github-actions bot commented Oct 10, 2025

Uh oh!

socket-security bot commented Oct 10, 2025 •

edited

Loading

Uh oh!

mathieuartu commented Oct 10, 2025

Uh oh!

mathieuartu commented Oct 10, 2025

Uh oh!

metamaskbot commented Oct 10, 2025

Uh oh!

metamaskbot commented Oct 10, 2025

Uh oh!

metamaskbot commented Oct 10, 2025

Uh oh!

mathieuartu commented Oct 13, 2025

Uh oh!

metamaskbot commented Oct 13, 2025

Uh oh!

metamaskbot commented Oct 13, 2025

Uh oh!

metamaskbot commented Oct 13, 2025

Uh oh!

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

4 participants

fix: bump @metamask/account-tree-controller to v1.4.2 cp-13.5.0 #36778

fix: bump @metamask/account-tree-controller to v1.4.2 cp-13.5.0 #36778

Conversation

mathieuartu commented Oct 10, 2025 • edited by cursor bot Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Description

Changelog

Related issues

Manual testing steps

Screenshots/Recordings

Before

After

Pre-merge author checklist

Pre-merge reviewer checklist

Uh oh!

github-actions bot commented Oct 10, 2025

Uh oh!

socket-security bot commented Oct 10, 2025 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Uh oh!

mathieuartu commented Oct 10, 2025

Uh oh!

mathieuartu commented Oct 10, 2025

Uh oh!

metamaskbot commented Oct 10, 2025

Uh oh!

metamaskbot commented Oct 10, 2025

📊 Page Load Benchmark Results

📄 Localhost MetaMask Test Dapp

Summary

Uh oh!

metamaskbot commented Oct 10, 2025

Uh oh!

mathieuartu commented Oct 13, 2025

Uh oh!

metamaskbot commented Oct 13, 2025

Uh oh!

metamaskbot commented Oct 13, 2025

📊 Page Load Benchmark Results

📄 Localhost MetaMask Test Dapp

Summary

Uh oh!

metamaskbot commented Oct 13, 2025

Uh oh!

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

4 participants

fix: bump `@metamask/account-tree-controller` to `v1.4.2` cp-13.5.0 #36778

fix: bump `@metamask/account-tree-controller` to `v1.4.2` cp-13.5.0 #36778

mathieuartu commented Oct 10, 2025 •

edited by cursor bot

Loading

socket-security bot commented Oct 10, 2025 •

edited

Loading