Skip to content

Conversation

mikesposito
Copy link
Member

@mikesposito mikesposito commented Jul 14, 2025

Description

This PR uses the @metamask/eth-qr-keyring package to handle QR code keyring functionality, replacing the previous implementation from @keystonehq/metamask-airgapped-keyring.

Along with this change, these controllers are being updated:

  • keyring-controller from ^22.1.1 to ^23.1.0
  • preferences-controller from ^18.4.0 to ^19.0.0
  • signature-controller from ^32.0.0 to ^33.0.0

And this patch is being deleted:

  • patches/@metamask+keyring-controller+22.1.1.patch - no longer needed due to the update to keyring-controller@^23.1.0

Changelog

CHANGELOG entry: null

Related issues

Fixes:

Manual testing steps

  1. Go to this page...

Screenshots/Recordings

Before

After

Pre-merge author checklist

Pre-merge reviewer checklist

  • I've manually tested the PR (e.g. pull and build branch, run the app, test code being changed).
  • I confirm that this PR addresses all acceptance criteria described in the ticket it closes and includes the necessary testing evidence such as recordings and or screenshots.

@mikesposito mikesposito force-pushed the mikesposito/feat/qr-keyring branch from 26c8f29 to 231f780 Compare July 14, 2025 13:22
@mikesposito mikesposito marked this pull request as ready for review August 26, 2025 09:43
@mikesposito mikesposito requested review from a team as code owners August 26, 2025 09:43
@mikesposito mikesposito force-pushed the mikesposito/feat/qr-keyring branch from 441c3a9 to 9ed0a75 Compare August 26, 2025 12:01
@danroc danroc added skip-sonar-cloud Only used for bypassing sonar cloud when failures are not relevant to the changes. and removed No E2E Smoke Needed If the PR does not need E2E smoke test run labels Sep 23, 2025
danroc
danroc previously approved these changes Sep 24, 2025
Copy link

Quality Gate Failed Quality Gate failed

Failed conditions
62.9% Coverage on New Code (required ≥ 80%)

See analysis details on SonarQube Cloud

Copy link
Contributor

@salimtb salimtb left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

assets changes lgtm

@danroc danroc added this pull request to the merge queue Sep 24, 2025
Merged via the queue into main with commit ae3b181 Sep 24, 2025
99 of 103 checks passed
@danroc danroc deleted the mikesposito/feat/qr-keyring branch September 24, 2025 14:33
@github-actions github-actions bot locked and limited conversation to collaborators Sep 24, 2025
@metamaskbot metamaskbot added the release-999.9.0 Issue or pull request that will be included in release 999.9.0 label Sep 24, 2025
@XxdpavelxX XxdpavelxX added release-7.57.0 Issue or pull request that will be included in release 7.57.0 and removed release-999.9.0 Issue or pull request that will be included in release 999.9.0 labels Sep 24, 2025
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
no-changelog no-changelog Indicates no external facing user changes, therefore no changelog documentation needed QA Passed QA testing has been completed and passed release-7.57.0 Issue or pull request that will be included in release 7.57.0 size-XL skip-sonar-cloud Only used for bypassing sonar cloud when failures are not relevant to the changes. team-core-platform Core Platform team
Projects
None yet
Development

Successfully merging this pull request may close these issues.