-
-
Notifications
You must be signed in to change notification settings - Fork 1.4k
refactor: use @metamask/eth-qr-keyring
#17157
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Merged
Merged
+527
−782
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
26c8f29
to
231f780
Compare
441c3a9
to
9ed0a75
Compare
6bf1542
danroc
previously approved these changes
Sep 24, 2025
danroc
approved these changes
Sep 24, 2025
Gudahtt
approved these changes
Sep 24, 2025
|
PatrykLucka
approved these changes
Sep 24, 2025
matthewwalsh0
approved these changes
Sep 24, 2025
shane-t
approved these changes
Sep 24, 2025
ameliejyc
approved these changes
Sep 24, 2025
salimtb
approved these changes
Sep 24, 2025
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
assets changes lgtm
tommasini
approved these changes
Sep 24, 2025
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Labels
no-changelog
no-changelog Indicates no external facing user changes, therefore no changelog documentation needed
QA Passed
QA testing has been completed and passed
release-7.57.0
Issue or pull request that will be included in release 7.57.0
size-XL
skip-sonar-cloud
Only used for bypassing sonar cloud when failures are not relevant to the changes.
team-core-platform
Core Platform team
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
This PR uses the
@metamask/eth-qr-keyring
package to handle QR code keyring functionality, replacing the previous implementation from@keystonehq/metamask-airgapped-keyring
.Along with this change, these controllers are being updated:
keyring-controller
from^22.1.1
to^23.1.0
preferences-controller
from^18.4.0
to^19.0.0
signature-controller
from^32.0.0
to^33.0.0
And this patch is being deleted:
patches/@metamask+keyring-controller+22.1.1.patch
- no longer needed due to the update tokeyring-controller@^23.1.0
Changelog
CHANGELOG entry: null
Related issues
Fixes:
Manual testing steps
Screenshots/Recordings
Before
After
Pre-merge author checklist
Pre-merge reviewer checklist