-
-
Notifications
You must be signed in to change notification settings - Fork 1.4k
refactor(deposit): use sdk env according MetaMask env #20520
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Merged
+112
−11
Merged
Changes from all commits
Commits
Show all changes
5 commits
Select commit
Hold shift + click to select a range
4dd555f
refactor(deposit): use sdk env according MetaMask env
wachunei 0ade382
refactor(deposit): move env reading inside util
wachunei ae14817
Merge branch 'main' into refactor/ramp-use-metamask-env
wachunei 9191af6
Merge branch 'main' into refactor/ramp-use-metamask-env
wachunei 2adc2e8
Merge branch 'main' into refactor/ramp-use-metamask-env
wachunei File filter
Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
There are no files selected for viewing
90 changes: 90 additions & 0 deletions
90
app/components/UI/Ramp/Deposit/sdk/getSdkEnvironment.test.ts
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Original file line number | Diff line number | Diff line change |
---|---|---|
@@ -0,0 +1,90 @@ | ||
import { SdkEnvironment } from '@consensys/native-ramps-sdk'; | ||
import { getSdkEnvironment } from './getSdkEnvironment'; | ||
|
||
describe('getSdkEnvironment', () => { | ||
const originalEnv = process.env.METAMASK_ENVIRONMENT; | ||
|
||
afterEach(() => { | ||
process.env.METAMASK_ENVIRONMENT = originalEnv; | ||
}); | ||
|
||
describe('Production Environment', () => { | ||
it('returns Production for production environment', () => { | ||
process.env.METAMASK_ENVIRONMENT = 'production'; | ||
const result = getSdkEnvironment(); | ||
expect(result).toBe(SdkEnvironment.Production); | ||
}); | ||
|
||
it('returns Production for beta environment', () => { | ||
process.env.METAMASK_ENVIRONMENT = 'beta'; | ||
const result = getSdkEnvironment(); | ||
expect(result).toBe(SdkEnvironment.Production); | ||
}); | ||
|
||
it('returns Production for rc environment', () => { | ||
process.env.METAMASK_ENVIRONMENT = 'rc'; | ||
const result = getSdkEnvironment(); | ||
expect(result).toBe(SdkEnvironment.Production); | ||
}); | ||
}); | ||
|
||
describe('Staging Environment', () => { | ||
it('returns Staging for dev environment', () => { | ||
process.env.METAMASK_ENVIRONMENT = 'dev'; | ||
const result = getSdkEnvironment(); | ||
expect(result).toBe(SdkEnvironment.Staging); | ||
}); | ||
|
||
it('returns Staging for exp environment', () => { | ||
process.env.METAMASK_ENVIRONMENT = 'exp'; | ||
const result = getSdkEnvironment(); | ||
expect(result).toBe(SdkEnvironment.Staging); | ||
}); | ||
|
||
it('returns Staging for test environment', () => { | ||
process.env.METAMASK_ENVIRONMENT = 'test'; | ||
const result = getSdkEnvironment(); | ||
expect(result).toBe(SdkEnvironment.Staging); | ||
}); | ||
|
||
it('returns Staging for e2e environment', () => { | ||
process.env.METAMASK_ENVIRONMENT = 'e2e'; | ||
const result = getSdkEnvironment(); | ||
expect(result).toBe(SdkEnvironment.Staging); | ||
}); | ||
}); | ||
|
||
describe('Default/Unknown Environment', () => { | ||
it('returns Staging for undefined environment', () => { | ||
delete process.env.METAMASK_ENVIRONMENT; | ||
const result = getSdkEnvironment(); | ||
expect(result).toBe(SdkEnvironment.Staging); | ||
}); | ||
|
||
it('returns Staging for unknown environment value', () => { | ||
process.env.METAMASK_ENVIRONMENT = 'unknown-env'; | ||
const result = getSdkEnvironment(); | ||
expect(result).toBe(SdkEnvironment.Staging); | ||
}); | ||
|
||
it('returns Staging for empty string environment', () => { | ||
process.env.METAMASK_ENVIRONMENT = ''; | ||
const result = getSdkEnvironment(); | ||
expect(result).toBe(SdkEnvironment.Staging); | ||
}); | ||
}); | ||
|
||
describe('Edge Cases', () => { | ||
it('handles case sensitivity correctly', () => { | ||
process.env.METAMASK_ENVIRONMENT = 'PRODUCTION'; | ||
const result = getSdkEnvironment(); | ||
expect(result).toBe(SdkEnvironment.Staging); | ||
}); | ||
|
||
it('handles whitespace in environment value', () => { | ||
process.env.METAMASK_ENVIRONMENT = ' production '; | ||
const result = getSdkEnvironment(); | ||
expect(result).toBe(SdkEnvironment.Staging); | ||
}); | ||
}); | ||
}); |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Original file line number | Diff line number | Diff line change |
---|---|---|
@@ -0,0 +1,18 @@ | ||
import { SdkEnvironment } from '@consensys/native-ramps-sdk'; | ||
|
||
export function getSdkEnvironment() { | ||
const metamaskEnvironment = process.env.METAMASK_ENVIRONMENT; | ||
switch (metamaskEnvironment) { | ||
case 'production': | ||
case 'beta': | ||
case 'rc': | ||
return SdkEnvironment.Production; | ||
|
||
case 'dev': | ||
case 'exp': | ||
case 'test': | ||
case 'e2e': | ||
default: | ||
return SdkEnvironment.Staging; | ||
} | ||
} | ||
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Oops, something went wrong.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Uh oh!
There was an error while loading. Please reload this page.