Skip to content

Conversation

bergarces
Copy link
Contributor

@bergarces bergarces commented Sep 29, 2025

Description

Height of the list seems to now be variable even with no items, which renders the previous solution ineffective, as it some times renders the message out of the view port.

This PR moves the remaining DeFi loading and error messages to the top.

DO NOT MERGE FOR NOW

Changelog

CHANGELOG entry: Fixed a bug in which DeFi messages loaded out of view

Related issues

Fixes: #20501

Manual testing steps

Feature: my feature name

  Scenario: user [verb for user action]
    Given [describe expected initial app state]

    When user [verb for user action]
    Then [describe expected outcome]

Screenshots/Recordings

Before

After

Simulator Screenshot - iPhone 15 Pro - 2025-09-29 at 14 35 26 Simulator Screenshot - iPhone 15 Pro - 2025-09-29 at 14 35 43

Pre-merge author checklist

Pre-merge reviewer checklist

  • I've manually tested the PR (e.g. pull and build branch, run the app, test code being changed).
  • I confirm that this PR addresses all acceptance criteria described in the ticket it closes and includes the necessary testing evidence such as recordings and or screenshots.

Note

Tweaks DeFiPositionsList.styles by removing height: '100%' and justifyContent: 'center' from emptyView and adding marginVertical: 8.

Written by Cursor Bugbot for commit 0a7e545. This will update automatically on new commits. Configure here.

@bergarces bergarces requested a review from a team as a code owner September 29, 2025 14:09
Copy link
Contributor

CLA Signature Action: All authors have signed the CLA. You may need to manually re-run the blocking PR check if it doesn't pass in a few minutes.

alignItems: 'center',
height: '100%',
justifyContent: 'center',
marginVertical: 8,
Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This is the same value used for the network filter wrapper to create a gap on top.

Copy link

@bergarces bergarces marked this pull request as draft September 30, 2025 07:37
@bergarces bergarces added the DO-NOT-MERGE Pull requests that should not be merged label Sep 30, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

DO-NOT-MERGE Pull requests that should not be merged size-XS team-assets

Projects

None yet

Development

Successfully merging this pull request may close these issues.

[Bug]: Perps and DeFi tab empty - need to scroll down to see the text when there are no open positions

2 participants