Skip to content

Conversation

PatrykLucka
Copy link
Contributor

@PatrykLucka PatrykLucka commented Sep 29, 2025

Description

This PR adds transition animation for account details and wallet details views.

Changelog

CHANGELOG entry: Added transition animation for account details and wallet details views

Related issues

Fixes:
Jira ticket: https://consensyssoftware.atlassian.net/browse/MUL-1109

Manual testing steps

Feature: Open wallet details

  Scenario: user opens wallet details
    Given multichain accounts are enabled

    When user navigates to accounts details
    Then navigates to wallet details
    Then transitions should be animated for both accounts details and wallet details

Screenshots/Recordings

Before

before.mov

After

after.mov

Pre-merge author checklist

Pre-merge reviewer checklist

  • I've manually tested the PR (e.g. pull and build branch, run the app, test code being changed).
  • I confirm that this PR addresses all acceptance criteria described in the ticket it closes and includes the necessary testing evidence such as recordings and or screenshots.

Note

Adds animated transitions for AccountGroupDetails and WalletDetails, inlining WalletDetails into the MultichainAccountDetails stack and removing the separate navigator.

  • Navigation:
    • Account Group Details: Add custom slide-in transition via cardStyleInterpolator for Routes.MULTICHAIN_ACCOUNTS.ACCOUNT_GROUP_DETAILS.
    • Wallet Details:
      • Inline Routes.MULTICHAIN_ACCOUNTS.WALLET_DETAILS into MultichainAccountDetails stack with animationEnabled: true.
      • Remove MultichainWalletDetails navigator and its AppFlow registration.

Written by Cursor Bugbot for commit b313801. This will update automatically on new commits. Configure here.

@PatrykLucka PatrykLucka self-assigned this Sep 29, 2025
@PatrykLucka PatrykLucka added No QA Needed Apply this label when your PR does not need any QA effort. team-accounts-deprecated DEPRECATED: please use "team-accounts-framework" instead labels Sep 29, 2025
Copy link
Contributor

CLA Signature Action: All authors have signed the CLA. You may need to manually re-run the blocking PR check if it doesn't pass in a few minutes.

@PatrykLucka PatrykLucka marked this pull request as ready for review September 29, 2025 14:37
cursor[bot]

This comment was marked as outdated.

Copy link

Quality Gate Failed Quality Gate failed

Failed conditions
0.0% Coverage on New Code (required ≥ 80%)

See analysis details on SonarQube Cloud

@PatrykLucka PatrykLucka added the skip-sonar-cloud Only used for bypassing sonar cloud when failures are not relevant to the changes. label Sep 29, 2025
Copy link
Contributor

@vinnyhoward vinnyhoward left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks much better. Approved

@PatrykLucka PatrykLucka added this pull request to the merge queue Sep 30, 2025
Merged via the queue into main with commit bb906a0 Sep 30, 2025
141 of 145 checks passed
@PatrykLucka PatrykLucka deleted the MUL-1109-mobile-improve-transition-between-accounts-screens branch September 30, 2025 07:42
@github-actions github-actions bot locked and limited conversation to collaborators Sep 30, 2025
@metamaskbot metamaskbot added the release-7.57.0 Issue or pull request that will be included in release 7.57.0 label Sep 30, 2025
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
No QA Needed Apply this label when your PR does not need any QA effort. release-7.57.0 Issue or pull request that will be included in release 7.57.0 size-S skip-sonar-cloud Only used for bypassing sonar cloud when failures are not relevant to the changes. team-accounts-deprecated DEPRECATED: please use "team-accounts-framework" instead
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants