Skip to content

Conversation

cmd-ob
Copy link
Contributor

@cmd-ob cmd-ob commented Sep 29, 2025

Description

  • Add option to skip react native reload
  • To be used for tests that need to preserve state in between tests
  • All other test will run the reload on cleanup
  • Multiple withFixtures can be used in it to prevent reloading

Changelog

CHANGELOG entry:

Related issues

Fixes:

Manual testing steps

Feature: my feature name

  Scenario: user [verb for user action]
    Given [describe expected initial app state]

    When user [verb for user action]
    Then [describe expected outcome]

Screenshots/Recordings

Before

After

Pre-merge author checklist

Pre-merge reviewer checklist

  • I've manually tested the PR (e.g. pull and build branch, run the app, test code being changed).
  • I confirm that this PR addresses all acceptance criteria described in the ticket it closes and includes the necessary testing evidence such as recordings and or screenshots.

Note

Adds skipReactNativeReload option to withFixtures (docs/types) and applies it across Snaps E2E tests; also sets Anvil port in network access test.

  • E2E Framework
    • withFixtures cleanup: Add options.skipReactNativeReload (default false) to conditionally skip device.reloadReactNative() in e2e/framework/fixtures/FixtureHelper.ts.
    • Types/Docs: Add skipReactNativeReload?: boolean with JSDoc in e2e/framework/types.ts; update options table in e2e/framework/fixtures/README.md.
  • Snaps E2E Tests
    • Pass skipReactNativeReload: true in multiple specs under e2e/specs/snaps/* to preserve state across it blocks.
    • Network Access test: set localNodeOptions[0].options.port to AnvilPort().

Written by Cursor Bugbot for commit 850af78. This will update automatically on new commits. Configure here.

@cmd-ob cmd-ob requested review from a team as code owners September 29, 2025 14:56
Copy link
Contributor

CLA Signature Action: All authors have signed the CLA. You may need to manually re-run the blocking PR check if it doesn't pass in a few minutes.

@metamaskbot metamaskbot added the team-qa QA team label Sep 29, 2025
@FrederikBolding FrederikBolding added the Run Flask E2E Trigger Flask e2e tests on Bitrise label Sep 29, 2025
Copy link
Contributor

github-actions bot commented Sep 29, 2025

https://bitrise.io/ Bitrise

❌❌❌ flask_smoke_e2e_pipeline failed on Bitrise! ❌❌❌

Commit hash: cb53ce8
Build link: https://app.bitrise.io/app/be69d4368ee7e86d/pipelines/921b55ca-404a-4b2e-b0db-8d4ce401d07d

Note

  • You can rerun any failed steps by opening the Bitrise build, tapping Rebuild on the upper right then Rebuild unsuccessful Workflows
  • You can kick off another flask_smoke_e2e_pipeline on Bitrise by removing and re-applying the run-ios-e2e-smoke label on the pull request

Tip

  • Check the documentation if you have any doubts on how to understand the failure on bitrise

Copy link
Contributor

@christopherferreira9 christopherferreira9 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@FrederikBolding FrederikBolding added Run Flask E2E Trigger Flask e2e tests on Bitrise and removed Run Flask E2E Trigger Flask e2e tests on Bitrise labels Sep 30, 2025
Copy link
Contributor

github-actions bot commented Sep 30, 2025

https://bitrise.io/ Bitrise

❌❌❌ flask_smoke_e2e_pipeline failed on Bitrise! ❌❌❌

Commit hash: 1a09aa9
Build link: https://app.bitrise.io/app/be69d4368ee7e86d/pipelines/073b8302-66b0-43ee-9b84-23d811e7cadd

Note

  • You can rerun any failed steps by opening the Bitrise build, tapping Rebuild on the upper right then Rebuild unsuccessful Workflows
  • You can kick off another flask_smoke_e2e_pipeline on Bitrise by removing and re-applying the run-ios-e2e-smoke label on the pull request

Tip

  • Check the documentation if you have any doubts on how to understand the failure on bitrise

@github-actions github-actions bot added size-M and removed size-S labels Oct 2, 2025
@cmd-ob cmd-ob added Run Flask E2E Trigger Flask e2e tests on Bitrise and removed Run Flask E2E Trigger Flask e2e tests on Bitrise labels Oct 2, 2025
Copy link
Contributor

github-actions bot commented Oct 2, 2025

https://bitrise.io/ Bitrise

❌❌❌ flask_smoke_e2e_pipeline failed on Bitrise! ❌❌❌

Commit hash: 899e548
Build link: https://app.bitrise.io/app/be69d4368ee7e86d/pipelines/535b4d3b-546b-41c9-b4ce-16a3ac392240

Note

  • You can rerun any failed steps by opening the Bitrise build, tapping Rebuild on the upper right then Rebuild unsuccessful Workflows
  • You can kick off another flask_smoke_e2e_pipeline on Bitrise by removing and re-applying the run-ios-e2e-smoke label on the pull request

Tip

  • Check the documentation if you have any doubts on how to understand the failure on bitrise

it('returns the client status', async () => {
await withFixtures(
{
fixture: new FixtureBuilder().build(),
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Test case above this needs skipReactNativeReload too

@cmd-ob cmd-ob added Run Flask E2E Trigger Flask e2e tests on Bitrise and removed Run Flask E2E Trigger Flask e2e tests on Bitrise labels Oct 2, 2025
Copy link
Contributor

github-actions bot commented Oct 2, 2025

https://bitrise.io/ Bitrise

❌❌❌ flask_smoke_e2e_pipeline failed on Bitrise! ❌❌❌

Commit hash: 126abce
Build link: https://app.bitrise.io/app/be69d4368ee7e86d/pipelines/c825544f-5bad-4a8b-a558-cdbeccdb0b83

Note

  • You can rerun any failed steps by opening the Bitrise build, tapping Rebuild on the upper right then Rebuild unsuccessful Workflows
  • You can kick off another flask_smoke_e2e_pipeline on Bitrise by removing and re-applying the run-ios-e2e-smoke label on the pull request

Tip

  • Check the documentation if you have any doubts on how to understand the failure on bitrise

@cmd-ob cmd-ob added Run Flask E2E Trigger Flask e2e tests on Bitrise and removed Run Flask E2E Trigger Flask e2e tests on Bitrise labels Oct 2, 2025
Copy link
Contributor

github-actions bot commented Oct 2, 2025

https://bitrise.io/ Bitrise

❌❌❌ flask_smoke_e2e_pipeline failed on Bitrise! ❌❌❌

Commit hash: 850af78
Build link: https://app.bitrise.io/app/be69d4368ee7e86d/pipelines/249565f3-0c07-402d-a37f-baa4c91a9ef8

Note

  • You can rerun any failed steps by opening the Bitrise build, tapping Rebuild on the upper right then Rebuild unsuccessful Workflows
  • You can kick off another flask_smoke_e2e_pipeline on Bitrise by removing and re-applying the run-ios-e2e-smoke label on the pull request

Tip

  • Check the documentation if you have any doubts on how to understand the failure on bitrise

Copy link

sonarqubecloud bot commented Oct 2, 2025

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Run Flask E2E Trigger Flask e2e tests on Bitrise size-M team-qa QA team
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants