-
-
Notifications
You must be signed in to change notification settings - Fork 1.4k
chore(test): add option to skip react native reload in test cleanup #20527
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
base: main
Are you sure you want to change the base?
Conversation
CLA Signature Action: All authors have signed the CLA. You may need to manually re-run the blocking PR check if it doesn't pass in a few minutes. |
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM
…ate during execution
|
|
it('returns the client status', async () => { | ||
await withFixtures( | ||
{ | ||
fixture: new FixtureBuilder().build(), |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Test case above this needs skipReactNativeReload
too
|
|
|
Description
withFixtures
can be used init
to prevent reloadingChangelog
CHANGELOG entry:
Related issues
Fixes:
Manual testing steps
Screenshots/Recordings
Before
After
Pre-merge author checklist
Pre-merge reviewer checklist
Note
Adds
skipReactNativeReload
option towithFixtures
(docs/types) and applies it across Snaps E2E tests; also sets Anvil port in network access test.withFixtures
cleanup: Addoptions.skipReactNativeReload
(defaultfalse
) to conditionally skipdevice.reloadReactNative()
ine2e/framework/fixtures/FixtureHelper.ts
.skipReactNativeReload?: boolean
with JSDoc ine2e/framework/types.ts
; update options table ine2e/framework/fixtures/README.md
.skipReactNativeReload: true
in multiple specs undere2e/specs/snaps/*
to preserve state acrossit
blocks.localNodeOptions[0].options.port
toAnvilPort()
.Written by Cursor Bugbot for commit 850af78. This will update automatically on new commits. Configure here.