Skip to content

Conversation

jvbriones
Copy link
Contributor

@jvbriones jvbriones commented Sep 29, 2025

Description

Changelog

CHANGELOG entry:

Related issues

Fixes:

Manual testing steps

Feature: my feature name

  Scenario: user [verb for user action]
    Given [describe expected initial app state]

    When user [verb for user action]
    Then [describe expected outcome]

Screenshots/Recordings

Before

After

Pre-merge author checklist

Pre-merge reviewer checklist

  • I've manually tested the PR (e.g. pull and build branch, run the app, test code being changed).
  • I confirm that this PR addresses all acceptance criteria described in the ticket it closes and includes the necessary testing evidence such as recordings and or screenshots.

Note

Introduces a network connection banner with redux state, SDKConnect V2 RPC bridge and controller wiring, new rewards UI components/hooks, multiple store migrations, and large E2E testing/infra additions (including AI-based test selector) with cleanup of legacy pieces.

  • Core/Engine:
    • Add controller init + messengers for PermissionController, PreferencesController, SelectedNetworkController, SubjectMetadataController, and PredictController.
    • Implement SDKConnect V2 RPCBridgeAdapter with onboarding/engine readiness utilities and logging.
    • Add QR keyring helpers and redux slice for QR scanner.
    • Expand Snaps permissions wiring.
  • Store/Migrations:
    • Migration 101: remove unused UserStorageController flags.
    • Migration 102: convert deposit order string IDs to typed objects.
    • Migration 103: rename popular network display names.
  • Networking:
    • New useNetworkConnectionBanner hook, reducer, selector; banner telemetry.
  • Rewards/UI:
    • Add RewardsThemeImageComponent, useRewardsAnimation, rewards intro modal hook; remove SeasonTierImage.
  • Deeplinks:
    • Add handlers for rewards and home URLs; replace Return-to-App modal with toast-based notification.
  • Analytics:
    • Add vault corruption tracking utility.
  • E2E/Infra:
    • Add extensive new specs (accounts, confirmations, networks, perps, performance), Appwright selectors/gestures, API mocks, and docs.
    • Introduce AI-driven E2E tag selector and GitHub workflow support; update environment/testing docs.
    • Add repack/fingerprint scripts; clean up legacy patches/scripts.

Written by Cursor Bugbot for commit 1d6e113. This will update automatically on new commits. Configure here.

@jvbriones jvbriones requested a review from a team as a code owner September 29, 2025 15:57
Copy link
Contributor

CLA Signature Action: All authors have signed the CLA. You may need to manually re-run the blocking PR check if it doesn't pass in a few minutes.

@jvbriones jvbriones requested review from a team as code owners October 2, 2025 22:02
setIsPlacing(false);
}
},
[reset, toastRef, buy, onError, currentOrder],
Copy link

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Bug: Error Handling Fails with Null Order

When an error occurs in placeBuyOrder, the onError callback is invoked with a null currentOrder because the order hasn't been successfully registered or processed. Additionally, the loading state remains true when onError is called, as setIsPlacing(false) is only executed in the finally block.

Fix in Cursor Fix in Web

@jvbriones jvbriones closed this Oct 2, 2025
@github-actions github-actions bot locked and limited conversation to collaborators Oct 2, 2025
@jvbriones jvbriones deleted the chore-e2e-docu branch October 2, 2025 22:26
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant