chore(deposit): revert fixes android region select bug (#17284)

[georgeweiler]

Description

This reverts commit d4a5f6f.

• Region list refactor: Replace custom touchable row in RegionSelectorModal.tsx with ListItemSelect
• Removes TouchableWithoutFeedback + manual selected/disabled styling.
• Trims FlatList props (removes removeClippedSubviews, scrollEnabled, nestedScrollEnabled).
• Simplifies style sheet; drops theme color usage and selectedItem/disabledItem rules.
• Adjusts listItem padding
• Tests: Updates snapshots to reflect new list item component and visuals.

Changelog

CHANGELOG entry: Refactored region selector to use ListItemSelect component, removing custom touchable implementation and simplifying styling and FlatList configuration.

Related issues

Fixes:

Manual testing steps

Feature: Deposit Region Selection on Android

  Scenario: user clicks the region button on the deposit feature
    Given user is on an android device

    When user scrolls the region list and selects a region
    Then region modal should close and display the user's choice

Screenshots/Recordings

Before

After

screen-20250930-094629.mp4

Pre-merge author checklist

• I’ve followed MetaMask Contributor Docs and MetaMask Mobile Coding Standards.
• I've completed the PR template to the best of my ability
• I’ve included tests if applicable
• I’ve documented my code using JSDoc format if applicable
• I’ve applied the right labels on the PR (see labeling guidelines). Not required for external contributors.

Pre-merge reviewer checklist

• I've manually tested the PR (e.g. pull and build branch, run the app, test code being changed).
• I confirm that this PR addresses all acceptance criteria described in the ticket it closes and includes the necessary testing evidence such as recordings and or screenshots.

---

Note

Refactors RegionSelectorModal to use ListItemSelect for region rows, simplifies styles (removes theme-based item states, adjusts padding), and drops extra FlatList props with snapshots updated.

• Deposit UI:
  • Region list refactor: Replace custom touchable row in RegionSelectorModal.tsx with ListItemSelect (uses isSelected, disabled, built-in selection visuals).
    • Removes TouchableWithoutFeedback + manual selected/disabled styling.
    • Trims FlatList props (removes removeClippedSubviews, scrollEnabled, nestedScrollEnabled).
  • Styles (RegionSelectorModal.styles.ts):
    • Simplifies style sheet; drops theme color usage and selectedItem/disabledItem rules.
    • Adjusts listItem padding (paddingVertical: 8).
  • Tests: Updates snapshots to reflect new list item component and visuals.

^{Written by Cursor Bugbot for commit 8fc31d8. This will update automatically on new commits. Configure here.}

[github-actions]

CLA Signature Action: All authors have signed the CLA. You may need to manually re-run the blocking PR check if it doesn't pass in a few minutes.

[sonarqubecloud]

Quality Gate passed

Issues
1 New issue
0 Accepted issues

Measures
0 Security Hotspots
100.0% Coverage on New Code
0.0% Duplication on New Code

See analysis details on SonarQube Cloud

[cursor]

Bug: Android Scrolling Bug Reintroduced in FlatList

Removing removeClippedSubviews={false}, scrollEnabled, and nestedScrollEnabled from the FlatList in the RegionSelectorModal reintroduces a previously fixed Android scrolling bug. These props are crucial for proper scrolling and preventing item clipping when the FlatList is nested within a BottomSheet on Android.

app/components/UI/Ramp/Deposit/Views/Modals/RegionSelectorModal/RegionSelectorModal.tsx#L198-L209

metamask-mobile/app/components/UI/Ramp/Deposit/Views/Modals/RegionSelectorModal/RegionSelectorModal.tsx

Lines 198 to 209 in 8fc31d8

	</View>
	<FlatList
	ref={listRef}
	style={styles.list}
	data={dataSearchResults}
	renderItem={renderRegionItem}
	extraData={selectedRegion?.isoCode}
	keyExtractor={(item) => item?.isoCode}
	ListEmptyComponent={renderEmptyList}
	keyboardDismissMode="none"
	keyboardShouldPersistTaps="always"
	/>

 

---