[Ignore] Deeplink to Settings View working

[smilingkylan]

My first thought was to just ask AI how to do it before having to dive into such a large codebase, but I decided to do it the manual way because a lot of devs may not have access to powerful AI. At multiple points I asked myself if there were any examples somewhere in the code base. A Readme file or comments in the files may be helpful.

1. Search “deep” and find “app/core/DeeplinkManager @MetaMask/mobile-platform” in the CODEOWNERS file
2. Go to app/core/DeeplinkManager, see “setDeepLink” which leads me nowhere, “addEventListener(‘url’)” doesn’t tell me much because “URL” is a common term so it’d be difficult to find where it is emitted. “handleDeeplink -> checkForDeepLink -> “CHECK_FOR_DEEPLINK” which leads to Sagas:

SharedDeeplinkManager.parse(deeplink, {
    origin: AppConstants.DEEPLINKS.ORIGIN_DEEPLINK,
});

Leads me to “parse” and then “parseDeepLink”

  `case PROTOCOLS.METAMASK which uses handleMetaMaskDeeplink`

3. Create conditional if LINK matches “SETTINGS” for example. Now we need to know how to do programmatically navigate the app. Maybe like this example from the handleMetaMaskDeeplink file?

      SDKConnect.getInstance().state.navigation?.navigate(
        Routes.MODAL.ROOT_MODAL_FLOW,
        {
          screen: Routes.SDK.RETURN_TO_DAPP_TOAST,
        },
      )

4. AI wants to help me code complete but I’ll resist for now. Is SDKConnect.getInstance().state.navigation really what we want to be using? Take a look at the “Routes” file and see one for settings. But what are the two parameters that “navigate” needs to take? They look similar in that example… both routes? Looks like first param is the route but why does the second variable have a “screen” field? I think that must be a misnomer for a stage of a modal process. I will remove the second parameter and use the Routes. I search in app for Routes.SETTINGS_VIEW to see if I need to pass a second param. Looks like this call should hopefully do the trick:

navigation.navigate(Routes.SETTINGS_VIEW, {
     screen: 'Settings',
});

5. Find deeplinks.ts file for the actual string route paths

6. Does React Native have link components? Documentation says no but we can create a button and use Linking.openURL(theUrl)


7. Button link works!

[github-actions]

CLA Signature Action: All authors have signed the CLA. You may need to manually re-run the blocking PR check if it doesn't pass in a few minutes.

[cursor]

Bug: Deeplink Handler Missing Return

Missing return statement after handling SETTINGS_VIEW deeplink. Without a return, the code will continue executing subsequent if conditions, potentially triggering multiple handlers for the same URL. All other similar deeplink handlers in this function include return statements to prevent this fall-through behavior.

 

[cursor]

Bug: Missing Prefix for Settings View Action

Missing PREFIXES entry for SETTINGS_VIEW action. All other actions in the ACTIONS enum have corresponding entries in the PREFIXES object (lines 42-62), but SETTINGS_VIEW is missing. This creates an inconsistent pattern and could cause issues if code elsewhere expects all actions to have defined prefixes.