Skip to content

Conversation

AxelGes
Copy link
Contributor

@AxelGes AxelGes commented Sep 29, 2025

Description

Similar to the aggregator effort: #20206

The Deposit flow is already largely prepared for multichain support. The remaining tasks are:

  1. Remove the network selector when pressing the account.
  2. Display the "Incompatible Account" modal only when:
    a. An EVM-only account tries to buy Solana, or
    b. A Solana-only account tries to buy an EVM token.

Changelog

CHANGELOG entry:

Related issues

Fixes:

Manual testing steps

Feature: my feature name

  Scenario: user [verb for user action]
    Given [describe expected initial app state]

    When user [verb for user action]
    Then [describe expected outcome]

Screenshots/Recordings

Before

After

Pre-merge author checklist

Pre-merge reviewer checklist

  • I've manually tested the PR (e.g. pull and build branch, run the app, test code being changed).
  • I confirm that this PR addresses all acceptance criteria described in the ticket it closes and includes the necessary testing evidence such as recordings and or screenshots.

Note

Use selectedWalletAddress (derived per token chain) to gate continue flow instead of useAccountTokenCompatible, update SDK to provide it, switch account navigation, and adjust tests.

  • Deposit UI:
    • Replace useAccountTokenCompatible check with selectedWalletAddress presence in Views/BuildQuote/BuildQuote and route to IncompatibleAccountTokenModal when absent.
    • Pass isEvmOnly=false to AccountSelector.
  • SDK:
    • Provide selectedWalletAddress via useRampAccountAddress(chainId) in sdk/index and change its type to string | null.
  • Navigation/Account Selector:
    • Switch to createAccountSelectorNavDetails and simplify selected address checks in components/AccountSelector.
  • Tests:
    • Update BuildQuote.test to remove token-compatibility mock and assert incompatible modal when selectedWalletAddress is null.
    • Include selectedWalletAddress in SDK mocks for useIdProofPolling, useKycPolling, and useUserDetailsPolling tests.
    • Remove useAccountTokenCompatible hook and its tests.

Written by Cursor Bugbot for commit ef33df0. This will update automatically on new commits. Configure here.

Copy link
Contributor

CLA Signature Action: All authors have signed the CLA. You may need to manually re-run the blocking PR check if it doesn't pass in a few minutes.

@metamaskbot metamaskbot added the team-ramp issues related to Ramp features label Sep 29, 2025
@AxelGes AxelGes marked this pull request as ready for review September 29, 2025 18:40
@AxelGes AxelGes requested a review from a team as a code owner September 29, 2025 18:40
@github-actions github-actions bot added size-M and removed size-S labels Sep 29, 2025
Copy link

@AxelGes AxelGes added this pull request to the merge queue Sep 30, 2025
Merged via the queue into main with commit 266f8cc Sep 30, 2025
87 of 89 checks passed
@AxelGes AxelGes deleted the feat/deposit/remove-selected-address-dep branch September 30, 2025 12:30
@github-actions github-actions bot locked and limited conversation to collaborators Sep 30, 2025
@metamaskbot metamaskbot added the release-7.57.0 Issue or pull request that will be included in release 7.57.0 label Sep 30, 2025
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
release-7.57.0 Issue or pull request that will be included in release 7.57.0 size-M team-ramp issues related to Ramp features
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants