fix: standardize button icon sizes to md (default) for bottomsheets, navigation and modals

[georgewrmarshall]

Description

Updated button icon sizes to md (default) for bottomsheets, navigation and modals as part of design system standardization. Since md is the default size, this involved removing explicit md size specifications and cleaning up unused ButtonIconSizes imports that were causing ESLint errors.

What is the reason for the change?
Design system standardization requires consistent button icon sizes across bottomsheets, navigation and modals.

What is the improvement/solution?

• Standardized button icon sizes to md (default) across target components
• Removed explicit md size specifications since it's the default
• Cleaned up unused ButtonIconSizes imports that were no longer needed

Changelog

CHANGELOG entry: null

Related issues

Fixes: https://consensyssoftware.atlassian.net/browse/DSYS-226

Reference: https://consensys.slack.com/archives/C0354T27M5M/p1758912397636659

Manual testing steps

Feature: Button icon size standardization

  Scenario: user navigates through bottomsheets, navigation and modals
    Given the app is running with updated button icon sizes
    When user opens any bottomsheet component
    Then button icons should display at md size (default)
    When user navigates through navigation components  
    Then button icons should display at md size (default)
    When user opens any modal component
    Then button icons should display at md size (default)
    And no visual regression should be apparent
    And linting should pass without errors

Screenshots/Recordings

Before

After

Pre-merge author checklist

• I've followed MetaMask Contributor Docs and MetaMask Mobile Coding Standards.
• I've completed the PR template to the best of my ability
• I've included tests if applicable
• I've documented my code using JSDoc format if applicable
• I've applied the right labels on the PR (see labeling guidelines). Not required for external contributors.

Pre-merge reviewer checklist

• I've manually tested the PR (e.g. pull and build branch, run the app, test code being changed).
• I confirm that this PR addresses all acceptance criteria described in the ticket it closes and includes the necessary testing evidence such as recordings and or screenshots.

---

Note

Standardizes ButtonIcon to md as the default size, removes explicit size props/imports in headers/modals, and updates snapshots to reflect 28x28 buttons with 20x20 icons.

• Component Library:
  • Set DEFAULT_BUTTONICON_SIZE to ButtonIconSizes.Md in components/Buttons/ButtonIcon/ButtonIcon.constants.ts.
• UI Components:
  • Remove explicit size prop and ButtonIconSizes imports from headers/modals (e.g., HintModal, PermissionsSummary, MultichainPermissionsSummary, gas-fee-token-modal, gas-modal-header, typed-sign simulation value displays).
• Tests/Snapshots:
  • Update snapshots across many components to reflect standardized sizes:
    • Button containers from 24x24 to 28x28 and icons from 16x16 to 20x20 (e.g., CellSelectWithMenu, ListItemMultiSelect*, ButtonIcon, various Bridge, Ramp, Earn, Stake, selectors, modals, and lists).

^{Written by Cursor Bugbot for commit 275add5. This will update automatically on new commits. Configure here.}

[github-actions]

CLA Signature Action: All authors have signed the CLA. You may need to manually re-run the blocking PR check if it doesn't pass in a few minutes.

[georgewrmarshall]

Aligns with design system default

[sonarqubecloud]

Quality Gate passed

Issues
3 New issues
0 Accepted issues

Measures
0 Security Hotspots
100.0% Coverage on New Code
0.0% Duplication on New Code

See analysis details on SonarQube Cloud