-
-
Notifications
You must be signed in to change notification settings - Fork 1.4k
refactor: ramp payment modal bottom sheet #20562
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
This reverts commit d4a5f6f.
CLA Signature Action: All authors have signed the CLA. You may need to manually re-run the blocking PR check if it doesn't pass in a few minutes. |
c7b9683
to
fe3fb35
Compare
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Would be good to add the following :
- Related Issue in the PR description so that it serves as the reference for the issue when planning in the future
- Adding manual steps for Testing so that QA/release team or others who have no context are easily able to test
- Completing the Pre merge checklist to make sure that you are not missing anything when submitting the PR up for review
Couple of other PR's for reference to maintain the quality :
Description
This PR refactors the ramp payment selector modal to use the bottom sheet pattern which will remove the flashy UI that existed previously.
Changelog
CHANGELOG entry: changed ramp payment method selector modal to a bottom sheet
Related issues
Fixes:
Manual testing steps
Screenshots/Recordings
Before
ScreenRecording_09-30-2025.22-13-29_1.MP4
After
ScreenRecording_09-30-2025.22-11-36_1.MP4
Pre-merge author checklist
Pre-merge reviewer checklist
Note
Replaces in-view PaymentMethodModal with a navigated bottom-sheet PaymentMethodSelectorModal and updates BuildQuote, routes, and tests accordingly.
PaymentMethodModal
with bottom-sheetPaymentMethodSelectorModal
.BuildQuote
, payment method "Change" now navigates toRampModals/RampPaymentMethodSelectorModal
viacreatePaymentMethodSelectorModalNavigationDetails
.handleShowPaymentMethodsModal
navigation.Routes.RAMP.MODALS.PAYMENT_METHOD_SELECTOR
and register inRampModalsRoutes
.components/PaymentMethodSelectorModal
(styles, index, tests, snapshots).components/PaymentMethodModal.tsx
.BuildQuote.test.tsx
to expect navigation to selector modal instead of direct selection.PaymentMethodSelectorModal
, including analytics on selection.Written by Cursor Bugbot for commit 8ad1e90. This will update automatically on new commits. Configure here.