Skip to content

Conversation

georgeweiler
Copy link
Contributor

@georgeweiler georgeweiler commented Sep 30, 2025

Description

This PR refactors the ramp payment selector modal to use the bottom sheet pattern which will remove the flashy UI that existed previously.

Changelog

CHANGELOG entry: changed ramp payment method selector modal to a bottom sheet

Related issues

Fixes:

Manual testing steps

Feature: my feature name

  Scenario: user [verb for user action]
    Given [describe expected initial app state]

    When user [verb for user action]
    Then [describe expected outcome]

Screenshots/Recordings

Before

ScreenRecording_09-30-2025.22-13-29_1.MP4

After

ScreenRecording_09-30-2025.22-11-36_1.MP4

Pre-merge author checklist

Pre-merge reviewer checklist

  • I've manually tested the PR (e.g. pull and build branch, run the app, test code being changed).
  • I confirm that this PR addresses all acceptance criteria described in the ticket it closes and includes the necessary testing evidence such as recordings and or screenshots.

Note

Replaces in-view PaymentMethodModal with a navigated bottom-sheet PaymentMethodSelectorModal and updates BuildQuote, routes, and tests accordingly.

  • UI/Flow (Ramp):
    • Replace PaymentMethodModal with bottom-sheet PaymentMethodSelectorModal.
    • In BuildQuote, payment method "Change" now navigates to RampModals/RampPaymentMethodSelectorModal via createPaymentMethodSelectorModalNavigationDetails.
    • Remove local modal state/handlers; add handleShowPaymentMethodsModal navigation.
  • Navigation:
    • Add Routes.RAMP.MODALS.PAYMENT_METHOD_SELECTOR and register in RampModalsRoutes.
  • Components:
    • Add components/PaymentMethodSelectorModal (styles, index, tests, snapshots).
    • Delete legacy components/PaymentMethodModal.tsx.
  • Tests:
    • Update BuildQuote.test.tsx to expect navigation to selector modal instead of direct selection.
    • Add unit tests and snapshots for PaymentMethodSelectorModal, including analytics on selection.

Written by Cursor Bugbot for commit 8ad1e90. This will update automatically on new commits. Configure here.

@georgeweiler georgeweiler requested a review from a team as a code owner September 30, 2025 02:54
@georgeweiler georgeweiler added QA Passed QA testing has been completed and passed team-ramp issues related to Ramp features Run Smoke E2E Requires smoke E2E testing no-changelog no-changelog Indicates no external facing user changes, therefore no changelog documentation needed labels Sep 30, 2025
@github-actions
Copy link
Contributor

CLA Signature Action: All authors have signed the CLA. You may need to manually re-run the blocking PR check if it doesn't pass in a few minutes.

cursor[bot]

This comment was marked as outdated.

@github-actions github-actions bot added size-L and removed size-M labels Oct 1, 2025
cursor[bot]

This comment was marked as outdated.

wachunei
wachunei previously approved these changes Oct 1, 2025
@wachunei wachunei added this pull request to the merge queue Oct 1, 2025
@wachunei wachunei removed this pull request from the merge queue due to a manual request Oct 1, 2025
@wachunei wachunei force-pushed the aggregator-payment-modal branch from c7b9683 to fe3fb35 Compare October 1, 2025 11:35
@sonarqubecloud
Copy link

sonarqubecloud bot commented Oct 1, 2025

@georgeweiler georgeweiler enabled auto-merge October 1, 2025 18:03
@georgeweiler georgeweiler added this pull request to the merge queue Oct 1, 2025
Copy link
Contributor

@amitabh94 amitabh94 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Would be good to add the following :

  • Related Issue in the PR description so that it serves as the reference for the issue when planning in the future
  • Adding manual steps for Testing so that QA/release team or others who have no context are easily able to test
  • Completing the Pre merge checklist to make sure that you are not missing anything when submitting the PR up for review

Couple of other PR's for reference to maintain the quality :

#18547
#16924

Merged via the queue into main with commit 85acceb Oct 1, 2025
105 of 109 checks passed
@georgeweiler georgeweiler deleted the aggregator-payment-modal branch October 1, 2025 18:24
@github-actions github-actions bot locked and limited conversation to collaborators Oct 1, 2025
@metamaskbot metamaskbot added the release-7.57.0 Issue or pull request that will be included in release 7.57.0 label Oct 1, 2025
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.

Labels

no-changelog no-changelog Indicates no external facing user changes, therefore no changelog documentation needed QA Passed QA testing has been completed and passed release-7.57.0 Issue or pull request that will be included in release 7.57.0 Run Smoke E2E Requires smoke E2E testing size-L team-ramp issues related to Ramp features

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants