-
-
Notifications
You must be signed in to change notification settings - Fork 1.5k
feat: OTA update exp workflow #22168
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
base: main
Are you sure you want to change the base?
Conversation
|
CLA Signature Action: All authors have signed the CLA. You may need to manually re-run the blocking PR check if it doesn't pass in a few minutes. |
asalsys
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Approving to test the workflow:
https://github.com/MetaMask/metamask-mobile/actions/workflows/push-eas-update.yml
|
No dependency changes detected. Learn more about Socket for GitHub. 👍 No dependency changes detected in pull request |
4c3ed7f to
b1d7c08
Compare
3d065a3 to
07fe206
Compare
🔍 Smart E2E Test Selection
click to see 🤖 AI reasoning detailsThis change introduces a new GitHub Actions workflow file (.github/workflows/push-eas-update.yml) for publishing OTA (Over-The-Air) updates via Expo EAS. Key findings:
The OTA updates functionality already exists in the application (confirmed by finding useOTAUpdates hook in app/components/hooks/useOTAUpdates.ts), so this workflow is just adding a new distribution mechanism, not changing app behavior. Since this is a workflow for deployment/release processes and doesn't modify any runtime application code, E2E test infrastructure, or critical paths, no E2E tests are needed to validate this change. The workflow itself should be tested through its own execution (running the workflow), not through application E2E tests. |
|
Cal-L
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I may have missed it - Are there docs on how the workflow is used especially for release engineers?



Description
New OTA updates workflow:

Changelog
CHANGELOG entry: Added OTA updates workflow
Related issues
Fixes: 21215
Manual testing steps
Screenshots/Recordings
Before
After
I was testing it with on pushing my branch. It was working from checking fingerprints to deploying EAS updates.

I haven't tested the part where we input PR number and branch name but I hardcoded these before so they should work with inputs as well. This can only be tested when this PR is merged into main.
Pre-merge author checklist
Pre-merge reviewer checklist
Note
Adds a GitHub Actions workflow to publish Expo EAS OTA updates gated by fingerprint comparison and team approval.
/.github/workflows/push-eas-update.ymlfor Expo EAS OTA updates:fingerprint-comparison: checks out PR and base branch, installs deps, generates Expo fingerprints, compares, and records summary.approval: requiresmobile-platformteam approval for OTA when fingerprints match.push-update: verifieseasscript and required secrets/vars, prepares signing key, and publisheseas updateto the configuredEXPO_CHANNEL, adding success/failure summaries.fingerprint-mismatch: fails the run if fingerprints differ (native changes detected).Written by Cursor Bugbot for commit bf2fc08. This will update automatically on new commits. Configure here.