Skip to content

Conversation

@matthewwalsh0
Copy link
Member

@matthewwalsh0 matthewwalsh0 commented Nov 14, 2025

Description

Minor design fixes for Predict deposit confirmation.

  • Increase height of confirm button.
  • Update keyboard done label.
  • Hide alert banner.

Changelog

CHANGELOG entry: null

Related issues

Fixes: #22726 #22731 #22761

Manual testing steps

Screenshots/Recordings

Before

After

Pre-merge author checklist

Pre-merge reviewer checklist

  • I've manually tested the PR (e.g. pull and build branch, run the app, test code being changed).
  • I confirm that this PR addresses all acceptance criteria described in the ticket it closes and includes the necessary testing evidence such as recordings and or screenshots.

Note

Hides the alert banner for predict/perps flows, enlarges the confirm button, renames the keyboard “Done” action to “Continue,” and updates tests/i18n accordingly.

  • Confirmations UI:
    • Extend AlertBanner ignore list to perpsDeposit, predictDeposit, predictWithdraw.
    • Centralize scroll disabling via TRANSACTION_TYPES_DISABLE_SCROLL; apply to ScrollView.
  • Custom Amount / Keyboard:
    • Keyboard done label now uses strings('confirm.edit_amount_done') (text changed to “Continue”).
    • Confirm button set to ButtonSize.Lg.
  • Tests & i18n:
    • Update tests to reference strings('confirm.edit_amount_done').
    • Update locales/languages/en.json: confirm.edit_amount_done → "Continue".

Written by Cursor Bugbot for commit dd2677c. This will update automatically on new commits. Configure here.

@matthewwalsh0 matthewwalsh0 added team-confirmations Push issues to confirmations team no-changelog no-changelog Indicates no external facing user changes, therefore no changelog documentation needed labels Nov 14, 2025
@matthewwalsh0 matthewwalsh0 marked this pull request as ready for review November 14, 2025 21:23
@matthewwalsh0 matthewwalsh0 requested a review from a team as a code owner November 14, 2025 21:23
@matthewwalsh0 matthewwalsh0 force-pushed the fix/predict-confirmation-layout branch from a75e9da to 9c0aa82 Compare November 17, 2025 10:36
@github-actions github-actions bot added size-S and removed size-XS labels Nov 17, 2025
@matthewwalsh0 matthewwalsh0 changed the title fix: predict confirmation design fix: cp-7.60.0 predict confirmation design Nov 17, 2025
@github-actions
Copy link
Contributor

🔍 Smart E2E Test Selection

  • Selected E2E tags: SmokeAccounts, SmokeCore, SmokeConfirmationsRedesigned, SmokeIdentity, SmokeNetworkAbstractions, SmokeNetworkExpansion, SmokeTrade, SmokeWalletPlatform, SmokeWalletUX, SmokeAssets, SmokeSwaps, SmokeStake, SmokeCard, SmokeNotifications, SmokeRewards, SmokePerps, SmokeRamps, SmokeMultiChainPermissions, SmokeAnalytics, SmokeMultiChainAPI, SmokePredictions
  • Risk Level: high
  • AI Confidence: %
click to see 🤖 AI reasoning details

Fallback: AI analysis did not complete successfully. Running all tests.

View GitHub Actions results

@sonarqubecloud
Copy link

@matthewwalsh0 matthewwalsh0 added this pull request to the merge queue Nov 17, 2025
Merged via the queue into main with commit 4ba3db2 Nov 17, 2025
72 of 73 checks passed
@matthewwalsh0 matthewwalsh0 deleted the fix/predict-confirmation-layout branch November 17, 2025 16:22
@github-actions github-actions bot locked and limited conversation to collaborators Nov 17, 2025
@metamaskbot metamaskbot added the release-7.61.0 Issue or pull request that will be included in release 7.61.0 label Nov 17, 2025
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.

Labels

no-changelog no-changelog Indicates no external facing user changes, therefore no changelog documentation needed release-7.61.0 Issue or pull request that will be included in release 7.61.0 size-S team-confirmations Push issues to confirmations team

Projects

None yet

Development

Successfully merging this pull request may close these issues.

[Bug]: Perps & Predict: update keypad CTA to "Continue" instead of "Add funds"

4 participants