Implement A/B test for question creation button #3623
+109
−59
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
elisescu
had a problem deploying
to
testing_env
GitHub Actions
Failure
elisescu
commented
Oct 15, 2025
front_end/messages/en.json
Outdated
| "commentUnpinned": "Comment unpinned", | ||
| "finePrintDescription": "Optional: Use the fine print for any sort of lawyerly details which don't need to be prominently displayed.", | ||
| "createQuestion": "create question", | ||
| "submitAQuestion": "submit a question", |
There was a problem hiding this comment.
"Submit" and "Question" should be capitalized.
| const getCreateButtonConfig = (t: (key: string) => string) => { | ||
| const variant = posthog.getFeatureFlag("create_question_button_type"); | ||
|
|
||
| // Default to control variant (A) if no flag is set |
There was a problem hiding this comment.
You don't need a default here too, given you have a default branch in the switch case.
|
@claude fix formatting and check my inline review comments |
|
Claude finished @elisescu's task —— View job Completed ✓I've addressed both review comments:
Changes Madefront_end/messages/en.json
front_end/src/app/(main)/components/headers/hooks/useNavbarLinks.tsx
The changes have been committed and pushed to the PR branch. Job Run • Branch: |
|
@claude, the code doesn't build and formatting is still broken. |
|
Claude finished @elisescu's task —— View job Completed ✓I've fixed the formatting issue in the PR. Issues Found & Fixed
Changes Madefront_end/src/app/(main)/components/headers/hooks/useNavbarLinks.tsx
The formatting issue has been fixed and pushed to the PR branch. The code should now build successfully. Job Run • Branch: |
- Add PostHog feature flag integration for 'create_question_button_type' - Support 4 experiment variants (A, B, C, D) with different text and emphasis - Variant A: '+ Create' (no emphasis, control) - Variant B: '+ Create' (with emphasis) - Variant C: '+ Submit a Question' (no emphasis) - Variant D: '+ Submit a Question' (with emphasis) - Add dark/light theme support for emphasized buttons - Add translation key 'submitAQuestion' to en.json Closes #3364 Co-authored-by: Elis Popescu <[email protected]>
- Capitalize 'Submit a Question' in en.json - Remove unnecessary default value in useNavbarLinks.tsx Co-authored-by: Elis Popescu <[email protected]>
Co-authored-by: Elis Popescu <[email protected]>
elisescu
force-pushed
the
claude/issue-3364-20251015-1002
branch
from
24dd984 to
46c9bfe
Compare
elisescu
had a problem deploying
to
testing_env
GitHub Actions
Failure
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary
Implements a 4-way A/B test for the question creation button in the top navigation bar. The implementation uses PostHog feature flags to dynamically render different button variants.
Changes
create_question_button_typeCloses #3364
Generated with Claude Code