FIX for generation custom id #19
Open
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Podczas dodawania drugiego module (dokładnie tego samego urządzenia), wcześniej generowane ID, było pobranym z api emodul, a tam to było zwykłym integerem od 100 się zaczynającym (drugi ten sam modul generował to samo id) i podczas podłączania nie mógł dodać nowych encji bo to ID już było zajęte.
FIX jaki zrobiłem, to generowanie unique_id na podstawie id (udid) moduły + id strefy (zone id).
Nie znam pythona, i nie wiem jak się zachowa gdy ["zone"]["id] przekazane do funkcji str będzie stringiem
Ale nie wiem czy w tech sterownikach jakieś id nie są integerami.