Make function helpers temporay in upgrade/downgrade script #18007
+126
−125
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Member
Author
|
!ci-build-me |
Member
Author
|
!ci-build-me |
dkijania
reviewed
Nov 3, 2025
Member
dkijania
left a comment
dkijania
left a comment
There was a problem hiding this comment.
+1 for using pg_temp.. Why we replaced order of dealing with tables? Is it intentional?
Member
Author
|
Yes, I want the order of 2 scripts completely reversed. I guess there's no big point on it. Which way do you think it's more maintainable? |
Member
|
Can you help me understand why we want to reverse it ? |
Member
Author
|
It doesn't have to. I can revert it if you like. The reason I have put it in this shape is because I have the mental model of DB rollbacks. BEGIN;
UPDATE accounts SET balance = balance - 100 WHERE id = 1;
UPDATE accounts SET balance = balance + 100 WHERE id = 2;
ROLLBACK;Something like this. |
Member
|
ok, understand now. Please add changelog as well. Starting from this pr we will be using pg_temp, maybe it is useful information for some archive operators |
dkijania
approved these changes
Nov 3, 2025
Member
Author
|
!ci-build-me |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
As title. so we're not polluting pgsql db.