Fix simple sql bind parameters throwing errors #657
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
I did not dive into what active record change caused this change in behavior, nor when a simple parameter is passed. But after upgrading to rails 7.1, this started showing up for many queries for me. Old Rails ========= The `binds` parameters, passed to sql are of the following forms: - ["parameter_name", "parameter_value"] - ActiveRecord::Relation::QueryAttribute Rails 7.1 (or maybe 7.0?) ============== The `binds` parameters, passed to sql are of the following forms: - ["parameter_name", "parameter_value"] - ActiveRecord::Relation::QueryAttribute - Simple class like Date, String The simple types caused an issue when trying to call String#name or String#value. After this commit ================= It is able to handle when simple objects are passed into rails If a password is passed as a simple parameter, that will get leaked, since the name of the parameter is no longer passed by rails.
kbrock
changed the title
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
I did not dive into what active record change caused this change in behavior,
nor when a simple parameter is passed. But after upgrading to rails 7.1,
this started showing up for many queries for me.
Old Rails
The
bindsparameters, passed to sql are of the following forms:Rails 7.1 (or maybe 7.0?)
The
bindsparameters, passed to sql are of the following forms:The simple types caused an issue when trying to call String#name or String#value.
After this commit
It is able to handle when simple objects are passed into rails
If a password is passed as a simple parameter, that will get leaked,
since the name of the parameter is no longer passed by rails.