Skip to content

Conversation

@ANRudrapatna
Copy link
Collaborator

Added additional arguments with associated descriptions.

Added additional arguments with associated descriptions.
## Required Arguments

### `--prediction`
### `-bed, --bed, -bw, --bw, --bigwig`
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

We do not have flags as listed here. The flags are usually --signal for a bw prediction track and different flags for bed files ("--bed", "--peaks", "--regions", "--roi", "-roi", and "--windows", "-w" for 1024 bp wide windowed BED file inputs. Please re-write, Thank you!

Copy link
Collaborator Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Hmmm, are you sure this is the case? I am currently running benchmark successfully with the --bw option, and the current version of parser.py accepts the listed arguments (as indicated in this screenshot).
parser_screenshot

### `-bed, --bed, -bw, --bw, --bigwig`

The input bigwig file of transcription factor binding predictions. This file can also be any bigwig signal track that you want to compare against a gold standard.
The input file of transcription factor binding predictions (in either BED or bigWig format). This file can also be any BED/bigWig signal track that you want to compare against a gold standard.
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

How do you get a BED file at the end of prediction? You should only be getting a bw file. The input flag should --bw here

Copy link
Collaborator Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I might totally be wrong, but this is what I was pointing out in the previous screenshot! Please let me know if I am wrong and I am happy to change what I have written.

Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This seems to be from one of the Tariean's update here: e08be57#diff-2b28b3ee9d11c4502b4d3fa82584cd292b165b7ee3f43cfb7873d31005bbba87L673, in parser.py file and around line 670 in the updated version.

We might want to also update the *.md file to mention the mutually exclusive nature between bed input and bw input.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants