-
Notifications
You must be signed in to change notification settings - Fork 11
Update benchmark.md #138
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
base: main
Are you sure you want to change the base?
Update benchmark.md #138
Conversation
Added additional arguments with associated descriptions.
| ## Required Arguments | ||
|
|
||
| ### `--prediction` | ||
| ### `-bed, --bed, -bw, --bw, --bigwig` |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
We do not have flags as listed here. The flags are usually --signal for a bw prediction track and different flags for bed files ("--bed", "--peaks", "--regions", "--roi", "-roi", and "--windows", "-w" for 1024 bp wide windowed BED file inputs. Please re-write, Thank you!
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
| ### `-bed, --bed, -bw, --bw, --bigwig` | ||
|
|
||
| The input bigwig file of transcription factor binding predictions. This file can also be any bigwig signal track that you want to compare against a gold standard. | ||
| The input file of transcription factor binding predictions (in either BED or bigWig format). This file can also be any BED/bigWig signal track that you want to compare against a gold standard. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
How do you get a BED file at the end of prediction? You should only be getting a bw file. The input flag should --bw here
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I might totally be wrong, but this is what I was pointing out in the previous screenshot! Please let me know if I am wrong and I am happy to change what I have written.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
This seems to be from one of the Tariean's update here: e08be57#diff-2b28b3ee9d11c4502b4d3fa82584cd292b165b7ee3f43cfb7873d31005bbba87L673, in parser.py file and around line 670 in the updated version.
We might want to also update the *.md file to mention the mutually exclusive nature between bed input and bw input.

Added additional arguments with associated descriptions.